[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18390: [fix](executor)fix error pending finish status for scan operator

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #18390:
URL: https://github.com/apache/doris/pull/18390#discussion_r1157111063


##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -60,9 +60,11 @@ class PipScannerContext : public vectorized::ScannerContext {
         {
             if (has_enough_space_in_blocks_queue()) {
                 std::unique_lock<std::mutex> l(_transfer_lock);
-                auto submit_st = _scanner_scheduler->submit(this);
-                if (submit_st.ok()) {
-                    _num_scheduling_ctx++;
+                if (!done()) {
+                    auto submit_st = _scanner_scheduler->submit(this);

Review Comment:
   warning: member access into incomplete type 'doris::vectorized::ScannerScheduler' [clang-diagnostic-error]
   ```cpp
                       auto submit_st = _scanner_scheduler->submit(this);
                                                          ^
   ```
   **be/src/runtime/exec_env.h:31:** forward declaration of 'doris::vectorized::ScannerScheduler'
   ```cpp
   class ScannerScheduler;
         ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org