[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6742: support registerTable in GlueCatalog

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6742:
URL: https://github.com/apache/iceberg/pull/6742#discussion_r1096433760


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -437,6 +439,44 @@ public void renameTable(TableIdentifier from, TableIdentifier to) {
     LOG.info("Successfully renamed table from {} to {}", from, to);
   }
 
+  @Override
+  public org.apache.iceberg.Table registerTable(TableIdentifier identifier, String metadataFileLocation) {

Review Comment:
   I think we might want to have a feature flag like `glue.register-table.create-new-metadata-enabled` (for the lack of a better name) in `AwsProperties` to distinguish 2 behaviors, to either create a new metadata file or not. If the flag is false (by default), it can call the base class method directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org