You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <st...@dev.static-void.de> on 2015/04/06 19:12:16 UTC
Review Request 32889: Only perform escalation wait when http teardown
signal could be dispatched
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Only perform escalation wait when http teardown signal could be dispatched
Diffs
-----
src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021
src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50
src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
Diff: https://reviews.apache.org/r/32889/diff/
Testing
-------
./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner
In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster.
Thanks,
Stephan Erb
Re: Review Request 32889: Only perform escalation wait when http
teardown signal could be dispatched
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889/#review78972
-----------------------------------------------------------
Ship it!
Master (5587bce) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2015, 5:12 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32889/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 5:12 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only perform escalation wait when http teardown signal could be dispatched
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021
> src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
>
> Diff: https://reviews.apache.org/r/32889/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner
>
> In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster.
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 32889: Only perform escalation wait when http
teardown signal could be dispatched
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889/#review78935
-----------------------------------------------------------
Master (27a602d) is red with this patch.
./build-support/jenkins/build.sh
:check
:build
:api:assemble
:api:compileTestJava UP-TO-DATE
:api:processTestResources UP-TO-DATE
:api:testClasses UP-TO-DATE
:api:test UP-TO-DATE
:api:check UP-TO-DATE
:api:build
:buildSrc:compileJava UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
BUILD SUCCESSFUL
Total time: 4 mins 1.812 secs
+ export PIP_DEFAULT_TIMEOUT=60
+ PIP_DEFAULT_TIMEOUT=60
+ mkdir -p third_party
+ pip install -d third_party -r /dev/fd/63
++ grep -v mesos.native 3rdparty/python/requirements.txt
Downloading/unpacking bottle==0.11.6 (from -r /dev/fd/63 (line 1))
Saved ./third_party/bottle-0.11.6-py2.py3-none-any.whl
Downloading/unpacking CherryPy==3.6.0 (from -r /dev/fd/63 (line 2))
pip can't proceed with requirement 'CherryPy==3.6.0 (from -r /dev/fd/63 (line 2))' due to a pre-existing build directory.
location: /tmp/user/2395/pip_build_jenkins/CherryPy
This is likely due to a previous installation that failed.
pip is being responsible and not assuming it can delete this.
Please delete it and try again.
Storing debug log for failure in /home/jenkins/.pip/pip.log
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2015, 5:12 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32889/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 5:12 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only perform escalation wait when http teardown signal could be dispatched
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021
> src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
>
> Diff: https://reviews.apache.org/r/32889/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner
>
> In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster.
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 32889: Only perform escalation wait when http
teardown signal could be dispatched
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889/#review78933
-----------------------------------------------------------
The discusson on the mailinglist regarding [this issue](https://mail-archives.apache.org/mod_mbox/incubator-aurora-dev/201503.mbox/%3Cea362985d93941b1b12fc028e8aca10d@Ex2013-3.phi-tps.local%3E) never really took off. I thought I might as well let to code speak for itself and see what you think about it.
- Stephan Erb
On April 6, 2015, 7:12 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32889/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 7:12 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only perform escalation wait when http teardown signal could be dispatched
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021
> src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
>
> Diff: https://reviews.apache.org/r/32889/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner
>
> In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster.
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 32889: Only perform escalation wait when http
teardown signal could be dispatched
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889/#review78968
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On April 6, 2015, 7:12 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32889/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 7:12 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only perform escalation wait when http teardown signal could be dispatched
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021
> src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
>
> Diff: https://reviews.apache.org/r/32889/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner
>
> In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster.
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 32889: Only perform escalation wait when http
teardown signal could be dispatched
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889/#review78942
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On April 6, 2015, 7:12 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32889/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 7:12 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only perform escalation wait when http teardown signal could be dispatched
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021
> src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
>
> Diff: https://reviews.apache.org/r/32889/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner
>
> In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster.
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 32889: Only perform escalation wait when http
teardown signal could be dispatched
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889/#review78949
-----------------------------------------------------------
Master (27a602d) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2015, 5:12 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32889/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 5:12 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only perform escalation wait when http teardown signal could be dispatched
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021
> src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
>
> Diff: https://reviews.apache.org/r/32889/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner
>
> In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster.
>
>
> Thanks,
>
> Stephan Erb
>
>