[jira] [Comment Edited] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

["Uwe Schindler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464033#comment-17464033 ] 

Uwe Schindler edited comment on LUCENE-10335 at 12/22/21, 8:23 PM:
-------------------------------------------------------------------

This should work inside the same module. It only does not work if you read some file in another package.

We use getResourceAsStream everywhere in Lucene, but we only load resources from same package. So why remove it. Or is this problematic as it is caller sensitive?


was (Author: thetaphi):
This should work inside the same module.

> IOUtils.getDecodingReader(Class<?>, String) is broken with modules
> ------------------------------------------------------------------
>
>                 Key: LUCENE-10335
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10335
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Priority: Major
>
> This method calls clazz.getResourceAsStream() but in a modular application the method won't see any of the resources in clazz's module, causing an NPE. We should deprecate or even remove this method entirely, leaving only getDecodingReader(InputStream) and opening the resource on the caller's side.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org