You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by huaxingao <gi...@git.apache.org> on 2015/11/04 08:41:17 UTC
[GitHub] spark pull request: Spark 11474
GitHub user huaxingao opened a pull request:
https://github.com/apache/spark/pull/9461
Spark 11474
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huaxingao/spark spark_11474
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9461.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9461
----
commit 75b7f57b42a1f0e88258187f75ab6b36a8706b0f
Author: Huaxin Gao <hu...@us.ibm.com>
Date: 2015-10-09T00:49:50Z
add write.mode for insertIntoJDBC when the parm overwrite is false
commit 684f4e9388f94d5102554a02c9497f23c40ef139
Author: Huaxin Gao <hu...@oc0558782468.ibm.com>
Date: 2015-10-24T06:13:00Z
Merge remote branch 'upstream/master' into spark8386
commit 495faae98d4f8d31e68d9736ef6f22aee2c514a6
Author: Huaxin Gao <hu...@oc0558782468.ibm.com>
Date: 2015-11-04T05:58:34Z
Merge remote branch 'upstream/master' into spark8386
commit becdb71bc0cfed3a71ec100fbcfa922728a40af8
Author: Huaxin Gao <hu...@oc0558782468.ibm.com>
Date: 2015-11-04T07:28:30Z
change fetchSize to fetchsize becasue the properties has lower case value
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11474]Options to jdbc load are lower ca...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9461#discussion_r43852227
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala ---
@@ -487,4 +488,9 @@ private[sql] class JDBCRDD(
nextValue
}
}
+
+ /**
+ * Compute an RDD partition or read it from a checkpoint if the RDD is checkpointing.
+ */
+ override private[spark] def computeOrReadCheckpoint(split: Partition, context: TaskContext): Iterator[InternalRow] = super.computeOrReadCheckpoint(split, context)
--- End diff --
Why this override? Seems to do nothing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11474]Options to jdbc load are lower ca...
Posted by huaxingao <gi...@git.apache.org>.
Github user huaxingao closed the pull request at:
https://github.com/apache/spark/pull/9461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 11474
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9461#issuecomment-153621309
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11474]Options to jdbc load are lower ca...
Posted by huaxingao <gi...@git.apache.org>.
Github user huaxingao commented on the pull request:
https://github.com/apache/spark/pull/9461#issuecomment-153832023
I am closing this pull request as i think i reused my previous branch.. i would like to start clean. I will open a new pull request shortly. Sorry for the confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org