[jira] [Commented] (SAMZA-371) Rename job.systemstreampartition.grouper.factory

["Yan Fang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097558#comment-14097558 ] 

Yan Fang commented on SAMZA-371:
--------------------------------

I realized that we did not put the job.partition.grouper.factory in the configuration table. Do we need to add it there?

BTW, could you apply the patch after SAMZA-259? I will apply that patch tonight. Just do not want to confused with conflict. :( 

> Rename job.systemstreampartition.grouper.factory
> ------------------------------------------------
>
>                 Key: SAMZA-371
>                 URL: https://issues.apache.org/jira/browse/SAMZA-371
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.8.0
>            Reporter: Chris Riccomini
>             Fix For: 0.8.0
>
>         Attachments: SAMZA-371-0.patch
>
>
> The config name job.systemstreampartition.grouper.factory, introduced in SAMZA-123, is a bit long and unwieldy. I think we should rename it. Some proposals:
> # job.input.grouper.factory
> # job.partition.grouper.factory
> # job.task.grouper.factory
> # job.grouper.factory
> (1) is my preference.



--
This message was sent by Atlassian JIRA
(v6.2#6252)