You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "tqchen (via GitHub)" <gi...@apache.org> on 2023/03/19 14:27:26 UTC

[GitHub] [tvm] tqchen opened a new pull request, #14332: [CODEGEN][METAL] Fix unaligned vector load

tqchen opened a new pull request, #14332:
URL: https://github.com/apache/tvm/pull/14332

   This PR fixes the implementation of unaligned vector load. Previously vector construction was printed as (float2)(v0, v1). This will cause problem as C have comma expression, and (v0, v1) will be evaluated as v1. The final result will become float2(v1, v1). The bug affects all codegen that uses the default implementation, such as metal. We added a testcase on metal to cover this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tqchen commented on pull request #14332: [CODEGEN][METAL] Fix unaligned vector load

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14332:
URL: https://github.com/apache/tvm/pull/14332#issuecomment-1475380496

   seems that `(float2)(v0,v1)` was the right syntax for opencl, will add an overload to the opencl codegen


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tqchen commented on pull request #14332: [CODEGEN][METAL] Fix unaligned vector load

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14332:
URL: https://github.com/apache/tvm/pull/14332#issuecomment-1475324278

   I have thought a bit about it in the end feel test correctness coverage is better in this case if we want future edits. We can indeed followup with source checking if new related regression arises


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #14332: [CODEGEN][METAL] Fix unaligned vector load

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14332:
URL: https://github.com/apache/tvm/pull/14332#issuecomment-1475276471

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @echuraev <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tqchen commented on pull request #14332: [CODEGEN][METAL] Fix unaligned vector load

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14332:
URL: https://github.com/apache/tvm/pull/14332#issuecomment-1475379760

   interesting, will dig a bit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #14332: [CODEGEN][METAL] Fix unaligned vector load

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14332:
URL: https://github.com/apache/tvm/pull/14332#issuecomment-1475359983

   it seems that this patch breaks OpenCL/Vulkan codegen..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] MasterJH5574 merged pull request #14332: [CODEGEN][METAL] Fix unaligned vector load

Posted by "MasterJH5574 (via GitHub)" <gi...@apache.org>.
MasterJH5574 merged PR #14332:
URL: https://github.com/apache/tvm/pull/14332


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org