You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2017/10/10 22:29:02 UTC
[lang] Make private fields final.
Repository: commons-lang
Updated Branches:
refs/heads/master 9a7de3974 -> 1e9e36640
Make private fields final.
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/1e9e3664
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/1e9e3664
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/1e9e3664
Branch: refs/heads/master
Commit: 1e9e36640f762d29c07d8322c361ece163b179fb
Parents: 9a7de39
Author: Gary Gregory <gg...@apache.org>
Authored: Tue Oct 10 16:28:59 2017 -0600
Committer: Gary Gregory <gg...@apache.org>
Committed: Tue Oct 10 16:28:59 2017 -0600
----------------------------------------------------------------------
.../builder/ReflectionDiffBuilderTest.java | 32 ++++++++++----------
...ionToStringBuilderExcludeNullValuesTest.java | 4 +--
2 files changed, 18 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/1e9e3664/src/test/java/org/apache/commons/lang3/builder/ReflectionDiffBuilderTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/builder/ReflectionDiffBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/ReflectionDiffBuilderTest.java
index 8fcc76a..b957f3a 100644
--- a/src/test/java/org/apache/commons/lang3/builder/ReflectionDiffBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/ReflectionDiffBuilderTest.java
@@ -27,25 +27,25 @@ public class ReflectionDiffBuilderTest {
@SuppressWarnings("unused")
private static class TypeTestClass implements Diffable<TypeTestClass> {
- private ToStringStyle style = SHORT_STYLE;
- private boolean booleanField = true;
- private boolean[] booleanArrayField = {true};
- private byte byteField = (byte) 0xFF;
- private byte[] byteArrayField = {(byte) 0xFF};
+ private final ToStringStyle style = SHORT_STYLE;
+ private final boolean booleanField = true;
+ private final boolean[] booleanArrayField = {true};
+ private final byte byteField = (byte) 0xFF;
+ private final byte[] byteArrayField = {(byte) 0xFF};
private char charField = 'a';
private char[] charArrayField = {'a'};
- private double doubleField = 1.0;
- private double[] doubleArrayField = {1.0};
- private float floatField = 1.0f;
- private float[] floatArrayField = {1.0f};
+ private final double doubleField = 1.0;
+ private final double[] doubleArrayField = {1.0};
+ private final float floatField = 1.0f;
+ private final float[] floatArrayField = {1.0f};
int intField = 1;
- private int[] intArrayField = {1};
- private long longField = 1L;
- private long[] longArrayField = {1L};
- private short shortField = 1;
- private short[] shortArrayField = {1};
- private Object objectField = null;
- private Object[] objectArrayField = {null};
+ private final int[] intArrayField = {1};
+ private final long longField = 1L;
+ private final long[] longArrayField = {1L};
+ private final short shortField = 1;
+ private final short[] shortArrayField = {1};
+ private final Object objectField = null;
+ private final Object[] objectArrayField = {null};
private static int staticField;
private transient String transientField;
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/1e9e3664/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeNullValuesTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeNullValuesTest.java b/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeNullValuesTest.java
index 914700a..f100d7d 100644
--- a/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeNullValuesTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeNullValuesTest.java
@@ -26,9 +26,9 @@ public class ReflectionToStringBuilderExcludeNullValuesTest {
static class TestFixture {
@SuppressWarnings("unused")
- private Integer testIntegerField;
+ private final Integer testIntegerField;
@SuppressWarnings("unused")
- private String testStringField;
+ private final String testStringField;
TestFixture(Integer a, String b) {
this.testIntegerField = a;