You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2016/05/06 06:11:00 UTC

[Impala-CR](cdh5-trunk) IMPALA-3488: test_ddl.py failure on LocalFS run

Sailesh Mukil has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2980

Change subject: IMPALA-3488: test_ddl.py failure on LocalFS run
......................................................................

IMPALA-3488: test_ddl.py failure on LocalFS run

Our test_ddl.py always had a bug where in the _cleanup() function,
we used the hdfs_client on local FS runs. It always ended up passing
because we caught generic exceptions in hdfs_client.delete_file_dir()
while checking if a file existed which always caused the test to pass.

With the introduction of an hdfs_client.exists() function in
IMPALA-1878 which catches only the right FileNotFound exception, this
bug was exposed causing our local FS runs to fail.

This patch returns from the _cleanup() function if it's a local FS run
because the directories of the tables it cleans up are not used in
these runs.

Change-Id: Ie0c9eec31a90e8f66102d18d900c613bd1306968
---
M tests/metadata/test_ddl.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/80/2980/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0c9eec31a90e8f66102d18d900c613bd1306968
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>