You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:46:16 UTC
[GitHub] [airflow] ashb opened a new pull request #16391: Remove old test dag that is out of place
ashb opened a new pull request #16391:
URL: https://github.com/apache/airflow/pull/16391
This dag hasn't been used in tests since about 2017, and is the last file in the top level `dags/` folder -- it's high time we removed it.
From what I can see this isn't used in the tests anymore.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16391: Remove old test dag that is out of place
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16391:
URL: https://github.com/apache/airflow/pull/16391#issuecomment-859625151
> I'll wait for the tests on this one, in case my grep failed to turn up something.
Yep. I looked it up to. The dag is copied to "examples of image customizations" but it is used from during CI rather than from here so it should be good .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #16391: Remove old test dag that is out of place
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #16391:
URL: https://github.com/apache/airflow/pull/16391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16391: Remove old test dag that is out of place
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16391:
URL: https://github.com/apache/airflow/pull/16391#issuecomment-859644124
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #16391: Remove old test dag that is out of place
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16391:
URL: https://github.com/apache/airflow/pull/16391#issuecomment-859620976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org