You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/28 21:35:10 UTC

[GitHub] [avro] ffontaine opened a new pull request #1025: AVRO-2898: Build failure without a C++ compiler (again)

ffontaine opened a new pull request #1025:
URL: https://github.com/apache/avro/pull/1025


   avro-c fails to build (again) without a C++ compiler because commit
   664c2fc7fba19709c1f974055f9cf4c8a799e108 reverted the change made by
   commit 414a51fdc1856083bb16851f09a4c61a48796132
   
   Fixes:
    - http://autobuild.buildroot.org/results/cfa91db53cf5502cbb6f902d1e7ad6397c8d70fd
   
   Signed-off-by: Fabrice Fontaine <fo...@gmail.com>
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #1025: AVRO-2898: Build failure without a C++ compiler (again)

Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1025:
URL: https://github.com/apache/avro/pull/1025#issuecomment-735812763


   Hey, thanks for following up on this!  @kraj was reverting this change deliberate?
   
   I'm not super familiar with cmake, but this PR looks like the [right thing to do](https://cmake.org/cmake/help/v3.7/command/project.html#command:project).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba merged pull request #1025: AVRO-2898: Build failure without a C++ compiler (again)

Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1025:
URL: https://github.com/apache/avro/pull/1025


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] kraj commented on pull request #1025: AVRO-2898: Build failure without a C++ compiler (again)

Posted by GitBox <gi...@apache.org>.
kraj commented on pull request #1025:
URL: https://github.com/apache/avro/pull/1025#issuecomment-735987153


   > Hey, thanks for following up on this! @kraj was reverting this change deliberate?
   > 
   > I'm not super familiar with cmake, but this PR looks like the [right thing to do](https://cmake.org/cmake/help/v3.7/command/project.html#command:project).
   
   this change is not intentional, in fact the pull I see here https://github.com/apache/avro/pull/749/commits/f42f97c74c322a7a17da884a2d319a3275093544
   does not actually have it, so I don't know how it got in


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #1025: AVRO-2898: Build failure without a C++ compiler (again)

Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1025:
URL: https://github.com/apache/avro/pull/1025#issuecomment-763444847


   Thanks for finding this mistake!  I cherry-picked this to [branch-1.10](https://github.com/apache/avro/commit/88ff4fe454f5784a0d7eeae01ca9ce35f2c44695).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org