You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@commons.apache.org by stevebosman <gi...@git.apache.org> on 2018/11/29 08:43:22 UTC

[GitHub] commons-numbers pull request #17: NUMBERS-76 Make "Quaternion" a ValJO

GitHub user stevebosman opened a pull request:

    https://github.com/apache/commons-numbers/pull/17

    NUMBERS-76 Make "Quaternion" a ValJO

    I've done the following 
    
    * changed the constructors to private and added equivalent of methods.
    * added a parse method
    * altered equals so that (like Complex) it uses Double.equals - gets round an edge case where Quaternions with the equivalence of -0 and 0 discovered while adding tests for hashCode
    * added a divide by scalar method
    * added a norm2 (square of norm) method
    * added some additional unit tests so it should now have 100% coverage
    
    I have also emailed an ICLA.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stevebosman/commons-numbers master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-numbers/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 9c6f77801265abe079b4054c3c90d55e956ee7cd
Author: Steve Bosman <st...@...>
Date:   2018-11-28T23:15:01Z

    NUMBERS-76 Make "Quaternion" a VALJO

commit 2f33d38d6ec5513ebbad44ffad237ebbc1ae9199
Author: Steve Bosman <st...@...>
Date:   2018-11-28T23:23:57Z

    NUMBERS-76 Make "Quaternion" a VALJO - correct Javadoc

----


---

[GitHub] commons-numbers issue #17: NUMBERS-76 Make "Quaternion" a ValJO

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-numbers/pull/17
  
    
    [![Coverage Status](https://coveralls.io/builds/20354285/badge)](https://coveralls.io/builds/20354285)
    
    Coverage decreased (-0.2%) to 78.642% when pulling **2f33d38d6ec5513ebbad44ffad237ebbc1ae9199 on stevebosman:master** into **447ced4cc9f53ed3dbf02588599c9797aabb1ea7 on apache:master**.



---

[GitHub] commons-numbers pull request #17: NUMBERS-76 Make "Quaternion" a ValJO

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/commons-numbers/pull/17


---