You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2022/01/06 15:02:08 UTC

[logging-log4j2] 02/03: Add org.apache.logging.log4j.core.appender.AsyncAppender.getAppenders() to more easily port from org.apache.log4j.AsyncAppender.getAllAppenders().

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit d0c0c10707137c3a9bc1257284dd5caae618b5df
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Jan 6 10:01:53 2022 -0500

    Add org.apache.logging.log4j.core.appender.AsyncAppender.getAppenders()
    to more easily port from
    org.apache.log4j.AsyncAppender.getAllAppenders().
    
    Commit 2/3 to allow some cherry-picking to master.
---
 .../logging/log4j/core/appender/AsyncAppenderTest.java    | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java
index d89aaee..a1c1026 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java
@@ -25,10 +25,12 @@ import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.util.List;
+import java.util.Objects;
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
 
 import org.apache.logging.log4j.LoggingException;
+import org.apache.logging.log4j.core.Appender;
 import org.apache.logging.log4j.core.LoggerContext;
 import org.apache.logging.log4j.junit.LoggerContextSource;
 import org.apache.logging.log4j.junit.Named;
@@ -41,6 +43,7 @@ import org.junit.jupiter.api.Timeout;
 public class AsyncAppenderTest {
 
     static void exceptionTest(final LoggerContext context) throws InterruptedException {
+        assertNotNull(context);
         final ExtendedLogger logger = context.getLogger(AsyncAppender.class);
         final Exception parent = new IllegalStateException("Test");
         final Throwable child = new LoggingException("This is a test", parent);
@@ -58,6 +61,7 @@ public class AsyncAppenderTest {
     }
 
     static void rewriteTest(final LoggerContext context) throws InterruptedException {
+        assertNotNull(context);
         final ExtendedLogger logger = context.getLogger(AsyncAppender.class);
         logger.error("This is a test");
         logger.warn("Hello world!");
@@ -115,6 +119,17 @@ public class AsyncAppenderTest {
 
     @Test
     @LoggerContextSource("log4j-asynch.xml")
+    public void testGetAppenders(final LoggerContext context) throws InterruptedException {
+        final AsyncAppender appender = context.getConfiguration().getAppender("Async");
+        final List<Appender> appenders = appender.getAppenders();
+        assertEquals(1, appenders.size());
+        final Appender listAppender = appenders.get(0);
+        assertEquals("List", listAppender.getName());
+        assertTrue(listAppender instanceof ListAppender);
+    }
+
+    @Test
+    @LoggerContextSource("log4j-asynch.xml")
     public void testGetErrorRef(final LoggerContext context) throws InterruptedException {
         final AsyncAppender appender = context.getConfiguration().getAppender("Async");
         assertEquals("STDOUT", appender.getErrorRef());