You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/12 19:12:03 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #28311: Migrate remaining API tests to `pytest`

Taragolis commented on code in PR #28311:
URL: https://github.com/apache/airflow/pull/28311#discussion_r1046262155


##########
tests/api/common/test_mark_tasks.py:
##########
@@ -631,9 +632,10 @@ def test_set_success_dag_run_to_success(self):
         self._verify_task_instance_states(self.dag1, date, State.SUCCESS)
         self._verify_dag_run_dates(self.dag1, date, State.SUCCESS, middle_time)
 
-    def test_set_success_dag_run_to_failed(self):
+    @pytest.mark.parametrize("completed_state", [State.SUCCESS, State.FAILED])
+    def test_set_completed_dag_run_to_failed(self, completed_state):

Review Comment:
   There were two identical test before:
   `test_set_success_dag_run_to_failed ` and `test_set_failed_dag_run_to_failed `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org