You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/08/23 16:49:06 UTC

[I] build(desktop): goal services adapter test uses removed SessionChangedEvent field [maka]

liuxiaocs7 opened a new issue, #3641:
URL: https://github.com/apache/maka/issues/3641

   ## What happened
   
   Running the Desktop build from the current `main` branch fails during `build:main`. The new Goal services adapter test constructs three `SessionChangedEvent` fixtures with a `type: 'sessions_changed'` property, but that property is no longer part of the shared interface.
   
   Expected behavior: `npm run build` succeeds and test fixtures conform to the current `SessionChangedEvent` contract.
   
   ## How to reproduce
   
   1. Check out commit `e6e0c34c7` or the current `main` branch.
   2. Install dependencies from the repository root.
   3. Run:
   
      ```sh
      npm --workspace @maka/desktop run build:main
      ```
   
   4. TypeScript reports `TS2353` at lines 64, 70, and 76 of `apps/desktop/src/main/__tests__/goal-services-adapter.test.ts`.
   
   ## Environment
   
   - Maka commit: `e6e0c34c7`
   - OS: macOS 15.7.3, Apple Silicon
   - Surface: Desktop
   - Node.js: 24.14.0
   - npm: 11.19.0
   
   ## Logs, screenshots, or additional context
   
   ```text
   src/main/__tests__/goal-services-adapter.test.ts(64,7): error TS2353:
   Object literal may only specify known properties, and 'type' does not exist in type 'SessionChangedEvent'.
   
   src/main/__tests__/goal-services-adapter.test.ts(70,7): error TS2353:
   Object literal may only specify known properties, and 'type' does not exist in type 'SessionChangedEvent'.
   
   src/main/__tests__/goal-services-adapter.test.ts(76,7): error TS2353:
   Object literal may only specify known properties, and 'type' does not exist in type 'SessionChangedEvent'.
   ```
   
   PR #3613 removed the unused event discriminator from `SessionChangedEvent`. PR #3531 subsequently introduced the adapter test from a stale event shape. Open PR #3639 independently records this current-`main` failure as a blocker to full Desktop typechecking.
   
   The minimal fix is to remove the three stale `type` properties from the test fixtures.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [I] build(desktop): goal services adapter test uses removed SessionChangedEvent field [maka]

Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #3641:
URL: https://github.com/apache/maka/issues/3641#issuecomment-5387488041

   solved by https://github.com/apache/maka/pull/3642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [I] build(desktop): goal services adapter test uses removed SessionChangedEvent field [maka]

Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 closed issue #3641: build(desktop): goal services adapter test uses removed SessionChangedEvent field
URL: https://github.com/apache/maka/issues/3641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org