You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/23 21:20:00 UTC
[GitHub] [pinot] richardstartin commented on a change in pull request #7949: unpeel group by 3 ways to enable vectorization
richardstartin commented on a change in pull request #7949:
URL: https://github.com/apache/pinot/pull/7949#discussion_r774782149
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##########
@@ -257,19 +257,46 @@ public int getNumKeys() {
@Override
public void processSingleValue(int numDocs, int[] outGroupIds) {
- if (_numGroupByExpressions == 1) {
- processSingleValue(numDocs, _singleValueDictIds[0], outGroupIds);
- } else {
- processSingleValueGeneric(numDocs, outGroupIds);
+ switch (_numGroupByExpressions) {
+ case 1:
+ processSingleValue(numDocs, _singleValueDictIds[0], outGroupIds);
+ return;
+ case 2:
+ processSingleValue(numDocs, _singleValueDictIds[0], _singleValueDictIds[1], outGroupIds);
+ return;
+ case 3:
+ processSingleValue(numDocs, _singleValueDictIds[0], _singleValueDictIds[1], _singleValueDictIds[2],
+ outGroupIds);
+ return;
+ default:
}
+ processSingleValueGeneric(numDocs, outGroupIds);
}
private void processSingleValue(int numDocs, int[] dictIds, int[] outGroupIds) {
System.arraycopy(dictIds, 0, outGroupIds, 0, numDocs);
+ markGroups(numDocs, outGroupIds);
+ }
+
+ private void processSingleValue(int numDocs, int[] dictIds0, int[] dictIds1, int[] outGroupIds) {
+ for (int i = 0; i < numDocs; i++) {
+ outGroupIds[i] = dictIds1[i] * _cardinalities[0] + dictIds0[i];
Review comment:
Unfortunately, FMA is a floating point operation, and doesn't operate on integers. Besides, `Math.fma` was introduced in JDK9 so cannot be used (except with `MethodHandle`s) and maintain JDK8 source compatibility (yes, it would be nice to start using JDK9+ APIs which have been available for over 4 years).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org