You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ZENOTME (via GitHub)" <gi...@apache.org> on 2023/10/12 16:40:29 UTC
[I] struct value design [iceberg-rust]
ZENOTME opened a new issue, #77:
URL: https://github.com/apache/iceberg-rust/issues/77
Use lookup will make the memory cost if we have multiple struct with same type.
One solve way is to use `Arc<StructType>` in Struct. I try this design in https://github.com/icelake-io/icelake/pull/136.
Anyway I think it's ok to solve this Problem in another PR. If this desgin looks work, I'm glad to port it.
_Originally posted by @ZENOTME in https://github.com/apache/iceberg-rust/pull/20#discussion_r1282598302_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] struct value design [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #77: struct value design
URL: https://github.com/apache/iceberg-rust/issues/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] struct value design [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #77:
URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1813893291
Tracked in #96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] struct value design [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on issue #77:
URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1760655157
cc @JanKaul @Fokko @Xuanwo @liurenjie1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] struct value design [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on issue #77:
URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1759997715
I find that our struct value didn't include type info. Do we want include type info in it?
1. If we include info in struct, the struct value may look like
```
struct Struct {
type: Arc<StructType>
...
}
```
- The benefit of it is we can look up field info directly by struct.
- The drawback is that extra 8 bytes pointer cost.
2. Another solution is pass struct type as another parameter when we need it, e.g.
```
fn write(struct_value: Struct,struct_type: StructType)
```
- The benefit of it is save memory cost.
- The drawback is that I'm not sure whether the struct type is hard available in some case .
For now, I'm working on serialize/deserialize value. And both process seem can solve by second way. (pass a struct type as parameter)
But I'm not sure whether there is some scenario we must include info in struct value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] struct value design [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #77:
URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1760723094
> Another solution is pass struct type as another parameter when we need it, e.g.
I prefer this approach. It's weird for me to store types with values, and we can always to attach type to it when necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org