You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/10/05 20:59:31 UTC
[GitHub] [druid-website-src] fjy opened a new pull request #170: wording changes
fjy opened a new pull request #170:
URL: https://github.com/apache/druid-website-src/pull/170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid-website-src] gianm commented on a change in pull request #170: wording changes
Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #170:
URL: https://github.com/apache/druid-website-src/pull/170#discussion_r500452656
##########
File path: index.html
##########
@@ -30,35 +30,35 @@ <h2>
<div class="features">
<div class="feature">
<span class="fa fa-chart-line fa"></span>
- <h5>A modern cloud-native, stream-native, analytics database</h5>
+ <h5>Power data applications and products</h5>
Review comment:
IMO the _first_ thing here should still be about how Druid is a fast modern analytics database. To me the "powering data application" thing is an important point and should be the very next (second) one.
i.e. I'm suggesting the first point is "what Druid is" and the second point is "what Druid is typically used for"
##########
File path: package-lock.json
##########
@@ -15,14 +15,14 @@
"integrity": "sha512-nne9/IiQ/hzIhY6pdDnbBtz7DjPTKrY00P/zvPSm5pOFkl6xuGrGnXn/VtTNNfNtAfZ9/1RtehkszU9qcTii0Q=="
},
"ajv": {
- "version": "5.5.2",
- "resolved": "https://registry.npmjs.org/ajv/-/ajv-5.5.2.tgz",
- "integrity": "sha1-c7Xuyj+rZT49P5Qis0GtQiBdyWU=",
+ "version": "6.12.5",
Review comment:
What are all these changes about? Are they intentional?
##########
File path: package.json
##########
@@ -21,6 +21,6 @@
"gulp": "3.9.1",
"gulp-sass": "4.0.1",
"natives": "^1.1.6",
- "node-sass": "4.9.2"
+ "node-sass": "^4.14.1"
Review comment:
What's this change about? Is it intentional?
##########
File path: technology.md
##########
@@ -6,7 +6,7 @@ canonical: 'https://druid.apache.org/technology'
---
Apache Druid is an open source distributed data store.
-Druid’s core design combines ideas from [data warehouses](https://en.wikipedia.org/wiki/Data_warehouse), [timeseries databases](https://en.wikipedia.org/wiki/Time_series_database), and [search systems](https://en.wikipedia.org/wiki/Full-text_search) to create a unified system for real-time analytics for a broad range of [use cases](/use-cases). Druid merges key characteristics of each of the 3 systems into its ingestion layer, storage format, querying layer, and core architecture.
+Druid’s core design combines ideas from [data warehouses](https://en.wikipedia.org/wiki/Data_warehouse), [timeseries databases](https://en.wikipedia.org/wiki/Time_series_database), and [search systems](https://en.wikipedia.org/wiki/Full-text_search) to create a powerful query serving layer for a broad range of [use cases](/use-cases). Druid merges key characteristics of each of the 3 systems into its ingestion layer, storage format, querying layer, and core architecture.
Review comment:
IMO change this to:
> to create a powerful, high performance analytics database
It's a "what Druid is" sentence, and that is a "high performance real-time analytics database".
##########
File path: use-cases.md
##########
@@ -5,7 +5,7 @@ sectionid: use-cases
canonical: 'https://druid.apache.org/use-cases'
---
-## Real-time analytics and intelligence
+## Power data applications
Review comment:
This headline is too specific for the content below (many of the use cases are data applications, but not all of them are).
Suggest rewording it to something like:
> Power real-time analytics, data applications, and more
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid-website-src] vogievetsky merged pull request #170: wording changes
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #170:
URL: https://github.com/apache/druid-website-src/pull/170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid-website-src] fjy commented on a change in pull request #170: wording changes
Posted by GitBox <gi...@apache.org>.
fjy commented on a change in pull request #170:
URL: https://github.com/apache/druid-website-src/pull/170#discussion_r500639865
##########
File path: package.json
##########
@@ -21,6 +21,6 @@
"gulp": "3.9.1",
"gulp-sass": "4.0.1",
"natives": "^1.1.6",
- "node-sass": "4.9.2"
+ "node-sass": "^4.14.1"
Review comment:
no - this should be in gitignore. I'll revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid-website-src] gianm commented on a change in pull request #170: wording changes
Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #170:
URL: https://github.com/apache/druid-website-src/pull/170#discussion_r500675937
##########
File path: .gitignore
##########
@@ -3,6 +3,8 @@ Gemfile.lock
.DS_store
.idea
.jekyll-metadata
+package.json
Review comment:
@vogievetsky can you please comment on whether these belong in .gitignore or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid-website-src] vogievetsky commented on pull request #170: wording changes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #170:
URL: https://github.com/apache/druid-website-src/pull/170#issuecomment-704659181
Please revert all changes to package.json and package-lock.json and (.gitignore) and it is g2g
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid-website-src] vogievetsky commented on a change in pull request #170: wording changes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #170:
URL: https://github.com/apache/druid-website-src/pull/170#discussion_r500705578
##########
File path: .gitignore
##########
@@ -3,6 +3,8 @@ Gemfile.lock
.DS_store
.idea
.jekyll-metadata
+package.json
Review comment:
definitely not!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org