[GitHub] [arrow-rs] jychen7 commented on a diff in pull request #3541: Additional GCP authentication

["jychen7 (via GitHub)" <gi...@apache.org>]

jychen7 commented on code in PR #3541:
URL: https://github.com/apache/arrow-rs/pull/3541#discussion_r1084807893


##########
object_store/src/gcp/credential.rs:
##########
@@ -222,3 +327,118 @@ fn b64_encode_obj<T: serde::Serialize>(obj: &T) -> Result<String> {
     let string = serde_json::to_string(obj).context(EncodeSnafu)?;
     Ok(BASE64_URL_SAFE_NO_PAD.encode(string))
 }
+
+/// A provider that uses the Google Cloud Platform metadata server to fetch a token.
+#[derive(Debug, Default)]
+pub struct InstanceCredentialProvider {
+    audience: String,
+}
+
+impl InstanceCredentialProvider {
+    pub fn new<T: Into<String>>(audience: T) -> Self {
+        Self {
+            audience: audience.into(),
+        }
+    }
+}
+
+#[async_trait]
+impl TokenProvider for InstanceCredentialProvider {
+    async fn fetch_token(
+        &self,
+        client: &Client,
+        retry: &RetryConfig,
+    ) -> Result<TemporaryToken<String>> {
+        println!("fetching token from metadata server");
+        const TOKEN_URL: &str =
+            "http://metadata/computeMetadata/v1/instance/service-accounts/default/token";

Review Comment:
   ```suggestion
               "http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/token";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org