You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by ni...@apache.org on 2018/11/02 09:35:05 UTC
[09/12] ignite git commit: IGNITE-9312: Remove unnecessary
@SuppressWarnings annotation - Fixes #4632.
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicCache.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicCache.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicCache.java
index c7b6677..686aace 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicCache.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicCache.java
@@ -203,7 +203,6 @@ public class GridDhtAtomicCache<K, V> extends GridDhtCacheAdapter<K, V> {
super.init();
updateReplyClos = new UpdateReplyClosure() {
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
@Override public void apply(GridNearAtomicAbstractUpdateRequest req, GridNearAtomicUpdateResponse res) {
if (req.writeSynchronizationMode() != FULL_ASYNC)
sendNearUpdateReply(res.nodeId(), res);
@@ -221,7 +220,7 @@ public class GridDhtAtomicCache<K, V> extends GridDhtCacheAdapter<K, V> {
}
/** {@inheritDoc} */
- @SuppressWarnings({"IfMayBeConditional", "SimplifiableIfStatement"})
+ @SuppressWarnings({"IfMayBeConditional"})
@Override public void start() throws IgniteCheckedException {
super.start();
@@ -751,7 +750,6 @@ public class GridDhtAtomicCache<K, V> extends GridDhtCacheAdapter<K, V> {
* @param op Operation closure.
* @return Future.
*/
- @SuppressWarnings("unchecked")
private <T> IgniteInternalFuture<T> asyncOp(final CO<IgniteInternalFuture<T>> op) {
IgniteInternalFuture<T> fail = asyncOpAcquire(/*retry*/false);
@@ -870,7 +868,6 @@ public class GridDhtAtomicCache<K, V> extends GridDhtCacheAdapter<K, V> {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public <T> IgniteInternalFuture<Map<K, EntryProcessorResult<T>>> invokeAllAsync(Set<? extends K> keys,
final EntryProcessor<K, V, T> entryProcessor,
Object... args) {
@@ -3542,7 +3539,6 @@ public class GridDhtAtomicCache<K, V> extends GridDhtCacheAdapter<K, V> {
* @param nodeId Sender node ID.
* @param res Dht atomic update response.
*/
- @SuppressWarnings("unchecked")
private void processDhtAtomicUpdateResponse(UUID nodeId, GridDhtAtomicUpdateResponse res) {
GridDhtAtomicAbstractUpdateFuture updateFut =
(GridDhtAtomicAbstractUpdateFuture)ctx.mvcc().atomicFuture(res.futureId());
@@ -3565,7 +3561,6 @@ public class GridDhtAtomicCache<K, V> extends GridDhtCacheAdapter<K, V> {
* @param nodeId Sender node ID.
* @param res Deferred atomic update response.
*/
- @SuppressWarnings("unchecked")
private void processDhtAtomicDeferredUpdateResponse(UUID nodeId, GridDhtAtomicDeferredUpdateResponse res) {
GridLongList futIds = res.futureIds();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicAbstractUpdateFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicAbstractUpdateFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicAbstractUpdateFuture.java
index 983b18a..f91e3f3 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicAbstractUpdateFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicAbstractUpdateFuture.java
@@ -361,7 +361,6 @@ public abstract class GridNearAtomicAbstractUpdateFuture extends GridCacheFuture
}
/** {@inheritDoc} */
- @SuppressWarnings("ConstantConditions")
@Override public final boolean onDone(@Nullable Object res, @Nullable Throwable err) {
assert err != null : "onDone should be called only to finish future with error on cache/node stop";
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicSingleUpdateFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicSingleUpdateFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicSingleUpdateFuture.java
index 4c0d2db..486a6e0 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicSingleUpdateFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicSingleUpdateFuture.java
@@ -222,7 +222,7 @@ public class GridNearAtomicSingleUpdateFuture extends GridNearAtomicAbstractUpda
}
/** {@inheritDoc} */
- @SuppressWarnings({"unchecked", "ThrowableResultOfMethodCallIgnored"})
+ @SuppressWarnings({"unchecked"})
@Override public void onPrimaryResponse(UUID nodeId, GridNearAtomicUpdateResponse res, boolean nodeErr) {
GridNearAtomicAbstractUpdateRequest req;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateFuture.java
index 28ebfb1..7210dfe 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateFuture.java
@@ -347,7 +347,7 @@ public class GridNearAtomicUpdateFuture extends GridNearAtomicAbstractUpdateFutu
}
/** {@inheritDoc} */
- @SuppressWarnings({"unchecked", "ThrowableResultOfMethodCallIgnored"})
+ @SuppressWarnings({"unchecked"})
@Override public void onPrimaryResponse(UUID nodeId, GridNearAtomicUpdateResponse res, boolean nodeErr) {
GridNearAtomicAbstractUpdateRequest req;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java
index 37fe824..0e40788 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java
@@ -194,7 +194,6 @@ public class GridNearAtomicUpdateResponse extends GridCacheIdMessage implements
/**
* @param ret Return value.
*/
- @SuppressWarnings("unchecked")
public void returnValue(GridCacheReturn ret) {
this.ret = ret;
}
@@ -243,7 +242,6 @@ public class GridNearAtomicUpdateResponse extends GridCacheIdMessage implements
* @param ttl TTL for near cache update.
* @param expireTime Expire time for near cache update.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
void addNearTtl(int keyIdx, long ttl, long expireTime) {
initNearUpdates();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/NearCacheUpdates.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/NearCacheUpdates.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/NearCacheUpdates.java
index d922095..fe7e5d1 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/NearCacheUpdates.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/NearCacheUpdates.java
@@ -96,7 +96,6 @@ public class NearCacheUpdates implements Message {
* @param ttl TTL for near cache update.
* @param expireTime Expire time for near cache update.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
void addNearTtl(int keyIdx, long ttl, long expireTime) {
if (ttl >= 0) {
if (nearTtls == null) {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/colocated/GridDhtColocatedLockFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/colocated/GridDhtColocatedLockFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/colocated/GridDhtColocatedLockFuture.java
index 9dbb8be..f372769 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/colocated/GridDhtColocatedLockFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/colocated/GridDhtColocatedLockFuture.java
@@ -152,7 +152,6 @@ public final class GridDhtColocatedLockFuture extends GridCacheCompoundIdentityF
private final Map<KeyCacheObject, IgniteBiTuple<GridCacheVersion, CacheObject>> valMap;
/** */
- @SuppressWarnings("UnusedDeclaration")
private volatile int done;
/** Trackable flag (here may be non-volatile). */
@@ -537,7 +536,7 @@ public final class GridDhtColocatedLockFuture extends GridCacheCompoundIdentityF
* @param miniId Mini ID to find.
* @return Mini future.
*/
- @SuppressWarnings({"ForLoopReplaceableByForEach", "IfMayBeConditional"})
+ @SuppressWarnings({"IfMayBeConditional"})
private MiniFuture miniFuture(int miniId) {
// We iterate directly over the futs collection here to avoid copy.
synchronized (this) {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
index d2f8b13..332b09e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
@@ -85,7 +85,6 @@ import static org.apache.ignite.internal.processors.dr.GridDrType.DR_PRELOAD;
/**
* Thread pool for requesting partitions from other nodes and populating local cache.
*/
-@SuppressWarnings("NonConstantFieldWithUpperCaseName")
public class GridDhtPartitionDemander {
/** */
private final GridCacheSharedContext<?, ?> ctx;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
index d13a7a6..94116fe 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
@@ -234,7 +234,6 @@ public class GridDhtPartitionsExchangeFuture extends GridDhtTopologyFutureAdapte
private final Map<ClusterNode, GridDhtPartitionsFullMessage> fullMsgs = new ConcurrentHashMap<>();
/** */
- @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"})
@GridToStringInclude
private volatile IgniteInternalFuture<?> partReleaseFut;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPreloader.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPreloader.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPreloader.java
index 034bf72..f6032bb 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPreloader.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPreloader.java
@@ -116,7 +116,6 @@ public class GridDhtPreloader extends GridCachePreloaderAdapter {
}
/** {@inheritDoc} */
- @SuppressWarnings({"LockAcquiredButNotSafelyReleased"})
@Override public void onKernalStop() {
if (log.isDebugEnabled())
log.debug("DHT rebalancer onKernalStop callback.");
@@ -514,7 +513,6 @@ public class GridDhtPreloader extends GridCachePreloaderAdapter {
* @param keys Keys to request.
* @return Future for request.
*/
- @SuppressWarnings({"unchecked", "RedundantCast"})
@Override public GridDhtFuture<Object> request(GridCacheContext cctx,
Collection<KeyCacheObject> keys,
AffinityTopologyVersion topVer) {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridClientPartitionTopology.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridClientPartitionTopology.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridClientPartitionTopology.java
index cd6e254..01db508 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridClientPartitionTopology.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridClientPartitionTopology.java
@@ -718,7 +718,6 @@ public class GridClientPartitionTopology implements GridDhtPartitionTopology {
}
/** {@inheritDoc} */
- @SuppressWarnings({"MismatchedQueryAndUpdateOfCollection"})
@Override public boolean update(
@Nullable AffinityTopologyVersion exchangeVer,
GridDhtPartitionFullMap partMap,
@@ -885,7 +884,6 @@ public class GridClientPartitionTopology implements GridDhtPartitionTopology {
}
/** {@inheritDoc} */
- @SuppressWarnings({"MismatchedQueryAndUpdateOfCollection"})
@Override public boolean update(
@Nullable GridDhtPartitionExchangeId exchId,
GridDhtPartitionMap parts,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtLocalPartition.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtLocalPartition.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtLocalPartition.java
index 2ddc0d4..e58c85f 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtLocalPartition.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtLocalPartition.java
@@ -180,7 +180,6 @@ public class GridDhtLocalPartition extends GridCacheConcurrentMapImpl implements
* @param grp Cache group.
* @param id Partition ID.
*/
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
public GridDhtLocalPartition(GridCacheSharedContext ctx,
CacheGroupContext grp,
int id) {
@@ -1224,7 +1223,6 @@ public class GridDhtLocalPartition extends GridCacheConcurrentMapImpl implements
}
/** {@inheritDoc} */
- @SuppressWarnings({"OverlyStrongTypeCast"})
@Override public boolean equals(Object obj) {
return obj instanceof GridDhtLocalPartition && (obj == this || ((GridDhtLocalPartition)obj).id() == id);
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionTopologyImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionTopologyImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionTopologyImpl.java
index b109e34..01f3d6c 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionTopologyImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionTopologyImpl.java
@@ -1345,7 +1345,6 @@ public class GridDhtPartitionTopologyImpl implements GridDhtPartitionTopology {
}
/** {@inheritDoc} */
- @SuppressWarnings({"MismatchedQueryAndUpdateOfCollection"})
@Override public boolean update(
@Nullable AffinityTopologyVersion exchangeVer,
GridDhtPartitionFullMap partMap,
@@ -1719,7 +1718,6 @@ public class GridDhtPartitionTopologyImpl implements GridDhtPartitionTopology {
}
/** {@inheritDoc} */
- @SuppressWarnings({"MismatchedQueryAndUpdateOfCollection"})
@Override public boolean update(
@Nullable GridDhtPartitionExchangeId exchId,
GridDhtPartitionMap parts,
@@ -2433,7 +2431,6 @@ public class GridDhtPartitionTopologyImpl implements GridDhtPartitionTopology {
* @param affVer Affinity version.
* @return Update sequence.
*/
- @SuppressWarnings({"MismatchedQueryAndUpdateOfCollection"})
private long updateLocal(int p, GridDhtPartitionState state, long updateSeq, AffinityTopologyVersion affVer) {
assert lock.isWriteLockedByCurrentThread();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearCacheEntry.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearCacheEntry.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearCacheEntry.java
index c953beb..a52e23e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearCacheEntry.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearCacheEntry.java
@@ -46,7 +46,7 @@ import static org.apache.ignite.events.EventType.EVT_CACHE_OBJECT_READ;
/**
* Near cache entry.
*/
-@SuppressWarnings({"NonPrivateFieldAccessedInSynchronizedContext", "TooBroadScope"})
+@SuppressWarnings({"TooBroadScope"})
public class GridNearCacheEntry extends GridDistributedCacheEntry {
/** */
private static final int NEAR_SIZE_OVERHEAD = 36 + 16;
@@ -55,7 +55,6 @@ public class GridNearCacheEntry extends GridDistributedCacheEntry {
private volatile AffinityTopologyVersion topVer = AffinityTopologyVersion.NONE;
/** DHT version which caused the last update. */
- @SuppressWarnings("FieldAccessedSynchronizedAndUnsynchronized")
private GridCacheVersion dhtVer;
/** Partition. */
@@ -380,7 +379,6 @@ public class GridNearCacheEntry extends GridDistributedCacheEntry {
* @throws IgniteCheckedException In case of error.
* @throws GridCacheEntryRemovedException If entry was removed.
*/
- @SuppressWarnings({"RedundantTypeArguments"})
public boolean loadedValue(@Nullable IgniteInternalTx tx,
UUID primaryNodeId,
CacheObject val,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearGetFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearGetFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearGetFuture.java
index f414dfb..d3c0245 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearGetFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearGetFuture.java
@@ -411,7 +411,6 @@ public final class GridNearGetFuture<K, V> extends CacheDistributedGetFutureAdap
* @param saved Reserved near cache entries.
* @return Map.
*/
- @SuppressWarnings("unchecked")
private Map<KeyCacheObject, GridNearCacheEntry> map(
KeyCacheObject key,
Map<ClusterNode, LinkedHashMap<KeyCacheObject, Boolean>> mappings,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java
index 6cd4514..2b3b5ea 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java
@@ -148,7 +148,6 @@ public final class GridNearLockFuture extends GridCacheCompoundIdentityFuture<Bo
private final Map<KeyCacheObject, IgniteBiTuple<GridCacheVersion, CacheObject>> valMap;
/** */
- @SuppressWarnings("UnusedDeclaration")
private volatile int done;
/** Keys locked so far. */
@@ -448,7 +447,6 @@ public final class GridNearLockFuture extends GridCacheCompoundIdentityFuture<Bo
* @param nodeId Left node ID
* @return {@code True} if node was in the list.
*/
- @SuppressWarnings({"ThrowableInstanceNeverThrown"})
@Override public boolean onNodeLeft(UUID nodeId) {
boolean found = false;
@@ -576,7 +574,7 @@ public final class GridNearLockFuture extends GridCacheCompoundIdentityFuture<Bo
* @param miniId Mini ID to find.
* @return Mini future.
*/
- @SuppressWarnings({"ForLoopReplaceableByForEach", "IfMayBeConditional"})
+ @SuppressWarnings({"IfMayBeConditional"})
private MiniFuture miniFuture(int miniId) {
// We iterate directly over the futs collection here to avoid copy.
synchronized (this) {
@@ -1213,7 +1211,6 @@ public final class GridNearLockFuture extends GridCacheCompoundIdentityFuture<Bo
*
* @throws IgniteCheckedException If mapping can not be completed.
*/
- @SuppressWarnings("unchecked")
private void proceedMapping0()
throws IgniteCheckedException {
GridNearLockMapping map;
@@ -1485,7 +1482,6 @@ public final class GridNearLockFuture extends GridCacheCompoundIdentityFuture<Bo
private Set<IgniteTxKey> requestedKeys;
/** {@inheritDoc} */
- @SuppressWarnings({"ThrowableInstanceNeverThrown"})
@Override public void onTimeout() {
if (log.isDebugEnabled())
log.debug("Timed out waiting for lock response: " + this);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticSerializableTxPrepareFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticSerializableTxPrepareFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticSerializableTxPrepareFuture.java
index 2c8fe21..a7142f9 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticSerializableTxPrepareFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticSerializableTxPrepareFuture.java
@@ -232,7 +232,6 @@ public class GridNearOptimisticSerializableTxPrepareFuture extends GridNearOptim
* @param miniId Mini ID to find.
* @return Mini future.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
private MiniFuture miniFuture(int miniId) {
// We iterate directly over the futs collection here to avoid copy.
synchronized (GridNearOptimisticSerializableTxPrepareFuture.this) {
@@ -810,7 +809,6 @@ public class GridNearOptimisticSerializableTxPrepareFuture extends GridNearOptim
private GridDistributedTxMapping m;
/** Flag to signal some result being processed. */
- @SuppressWarnings("UnusedDeclaration")
private volatile int rcvRes;
/**
@@ -884,7 +882,7 @@ public class GridNearOptimisticSerializableTxPrepareFuture extends GridNearOptim
* @param res Result callback.
* @param updateMapping Update mapping flag.
*/
- @SuppressWarnings({"unchecked", "ThrowableResultOfMethodCallIgnored"})
+ @SuppressWarnings({"unchecked"})
void onResult(final GridNearTxPrepareResponse res, boolean updateMapping) {
if (isDone())
return;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticTxPrepareFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticTxPrepareFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticTxPrepareFuture.java
index e1bfa90..809d149 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticTxPrepareFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearOptimisticTxPrepareFuture.java
@@ -216,7 +216,6 @@ public class GridNearOptimisticTxPrepareFuture extends GridNearOptimisticTxPrepa
/**
* @return Keys for which {@code MiniFuture} isn't completed.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
public Set<IgniteTxKey> requestedKeys() {
synchronized (this) {
int size = futuresCountNoLock();
@@ -248,7 +247,6 @@ public class GridNearOptimisticTxPrepareFuture extends GridNearOptimisticTxPrepa
* @param miniId Mini ID to find.
* @return Mini future.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
private MiniFuture miniFuture(int miniId) {
// We iterate directly over the futs collection here to avoid copy.
synchronized (this) {
@@ -761,7 +759,6 @@ public class GridNearOptimisticTxPrepareFuture extends GridNearOptimisticTxPrepa
/**
*
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
private void onTimeout() {
if (cctx.tm().deadlockDetectionEnabled()) {
Set<IgniteTxKey> keys = null;
@@ -917,7 +914,6 @@ public class GridNearOptimisticTxPrepareFuture extends GridNearOptimisticTxPrepa
private GridDistributedTxMapping m;
/** Flag to signal some result being processed. */
- @SuppressWarnings("UnusedDeclaration")
private volatile int rcvRes;
/** Mappings to proceed prepare. */
@@ -1002,7 +998,6 @@ public class GridNearOptimisticTxPrepareFuture extends GridNearOptimisticTxPrepa
/**
* @param res Result callback.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
void onResult(final GridNearTxPrepareResponse res) {
if (isDone())
return;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearPessimisticTxPrepareFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearPessimisticTxPrepareFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearPessimisticTxPrepareFuture.java
index 86fe475..ef41f5e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearPessimisticTxPrepareFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearPessimisticTxPrepareFuture.java
@@ -143,7 +143,6 @@ public class GridNearPessimisticTxPrepareFuture extends GridNearTxPrepareFutureA
* @param miniId Mini ID to find.
* @return Mini future.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
private MiniFuture miniFuture(int miniId) {
// We iterate directly over the futs collection here to avoid copy.
synchronized (this) {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java
index 494f388..3f7e48a 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java
@@ -214,7 +214,6 @@ public class GridNearTransactionalCache<K, V> extends GridNearCacheAdapter<K, V>
* @param nodeId Node ID.
* @param req Request.
*/
- @SuppressWarnings({"RedundantTypeArguments"})
public void clearLocks(UUID nodeId, GridDhtUnlockRequest req) {
assert nodeId != null;
@@ -279,7 +278,6 @@ public class GridNearTransactionalCache<K, V> extends GridNearCacheAdapter<K, V>
* @throws IgniteCheckedException If failed.
* @throws GridDistributedLockCancelledException If lock has been cancelled.
*/
- @SuppressWarnings({"RedundantTypeArguments", "ForLoopReplaceableByForEach"})
@Nullable public GridNearTxRemote startRemoteTx(UUID nodeId, GridDhtLockRequest req)
throws IgniteCheckedException, GridDistributedLockCancelledException {
List<KeyCacheObject> nearKeys = req.nearKeys();
@@ -634,7 +632,6 @@ public class GridNearTransactionalCache<K, V> extends GridNearCacheAdapter<K, V>
* @param ver Lock version.
* @param keys Keys.
*/
- @SuppressWarnings({"unchecked"})
public void removeLocks(GridCacheVersion ver, Collection<KeyCacheObject> keys) {
if (keys.isEmpty())
return;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxEnlistFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxEnlistFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxEnlistFuture.java
index 098b062..ef5b898 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxEnlistFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxEnlistFuture.java
@@ -567,7 +567,6 @@ public class GridNearTxEnlistFuture extends GridNearTxAbstractEnlistFuture<GridC
* @param err Exception.
* @return {@code True} if future was completed by this call.
*/
- @SuppressWarnings("unchecked")
public boolean checkResponse(UUID nodeId, GridNearTxEnlistResponse res, Throwable err) {
assert res != null || err != null : this;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxFinishFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxFinishFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxFinishFuture.java
index b79346b..20d9e50 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxFinishFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxFinishFuture.java
@@ -190,7 +190,6 @@ public final class GridNearTxFinishFuture<K, V> extends GridCacheCompoundIdentit
* @param nodeId Sender.
* @param res Result.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
public void onResult(UUID nodeId, GridNearTxFinishResponse res) {
if (!isDone()) {
FinishMiniFuture finishFut = null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java
index d8e4353..d4e6ca4 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java
@@ -151,12 +151,10 @@ public class GridNearTxLocal extends GridDhtTxLocalAdapter implements GridTimeou
private IgniteTxMappings mappings;
/** Prepare future. */
- @SuppressWarnings("UnusedDeclaration")
@GridToStringExclude
private volatile IgniteInternalFuture<?> prepFut;
/** Commit future. */
- @SuppressWarnings("UnusedDeclaration")
@GridToStringExclude
private volatile NearTxFinishFuture finishFut;
@@ -3607,7 +3605,6 @@ public class GridNearTxLocal extends GridDhtTxLocalAdapter implements GridTimeou
}
/** {@inheritDoc} */
- @SuppressWarnings({"CatchGenericClass", "ThrowableInstanceNeverThrown"})
@Override public boolean localFinish(boolean commit, boolean clearThreadMap) throws IgniteCheckedException {
if (log.isDebugEnabled())
log.debug("Finishing near local tx [tx=" + this + ", commit=" + commit + "]");
@@ -3838,7 +3835,6 @@ public class GridNearTxLocal extends GridDhtTxLocalAdapter implements GridTimeou
*
* @return Rollback future.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public IgniteInternalFuture<IgniteInternalTx> rollbackNearTxLocalAsync(final boolean clearThreadMap,
final boolean onTimeout) {
if (log.isDebugEnabled())
@@ -4425,7 +4421,6 @@ public class GridNearTxLocal extends GridDhtTxLocalAdapter implements GridTimeou
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Nullable @Override public IgniteInternalFuture<?> currentPrepareFuture() {
return prepFut;
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFutureAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFutureAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFutureAdapter.java
index 285481d..35d38aa 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFutureAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFutureAdapter.java
@@ -195,7 +195,6 @@ public abstract class GridNearTxPrepareFutureAdapter extends
* @param res Response.
* @param updateMapping Update mapping flag.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
final void onPrepareResponse(GridDistributedTxMapping m,
GridNearTxPrepareResponse res,
boolean updateMapping) {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/GridLocalLockFuture.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/GridLocalLockFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/GridLocalLockFuture.java
index fb8c396..c1bd858 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/GridLocalLockFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/GridLocalLockFuture.java
@@ -100,7 +100,6 @@ public final class GridLocalLockFuture<K, V> extends GridCacheFutureAdapter<Bool
private GridCacheVersion lockVer;
/** Error. */
- @SuppressWarnings("UnusedDeclaration")
private volatile Throwable err;
/** Timeout object. */
@@ -443,7 +442,6 @@ public final class GridLocalLockFuture<K, V> extends GridCacheFutureAdapter<Bool
}
/** {@inheritDoc} */
- @SuppressWarnings({"ThrowableInstanceNeverThrown"})
@Override public boolean cancel() {
if (onCancelled()) {
// Remove all locks.
@@ -495,7 +493,7 @@ public final class GridLocalLockFuture<K, V> extends GridCacheFutureAdapter<Bool
}
/** {@inheritDoc} */
- @SuppressWarnings({"ThrowableInstanceNeverThrown", "ForLoopReplaceableByForEach"})
+ @SuppressWarnings({"ForLoopReplaceableByForEach"})
@Override public void onTimeout() {
if (log.isDebugEnabled())
log.debug("Timed out waiting for lock response: " + this);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/atomic/GridLocalAtomicCache.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/atomic/GridLocalAtomicCache.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/atomic/GridLocalAtomicCache.java
index b615952..4cacb47 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/atomic/GridLocalAtomicCache.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/local/atomic/GridLocalAtomicCache.java
@@ -1347,7 +1347,7 @@ public class GridLocalAtomicCache<K, V> extends GridLocalCache<K, V> {
* @param transformed {@code True} if transform operation performed.
* @return Partial update exception.
*/
- @SuppressWarnings({"unchecked", "ConstantConditions", "ForLoopReplaceableByForEach"})
+ @SuppressWarnings({"unchecked", "ConstantConditions"})
@Nullable private CachePartialUpdateCheckedException updatePartialBatch(
List<GridCacheEntryEx> entries,
final GridCacheVersion ver,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
index ce01431..b517da6 100755
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
@@ -1516,7 +1516,6 @@ public class GridCacheDatabaseSharedManager extends IgniteCacheDatabaseSharedMan
* state.
* @throws IgniteException If failed.
*/
- @SuppressWarnings("LockAcquiredButNotSafelyReleased")
@Override public void checkpointReadLock() {
if (checkpointLock.writeLock().isHeldByCurrentThread())
return;
@@ -3479,7 +3478,6 @@ public class GridCacheDatabaseSharedManager extends IgniteCacheDatabaseSharedMan
/**
*
*/
- @SuppressWarnings("WaitNotInLoop")
private void waitCheckpointEvent() {
boolean cancel = false;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/PagesList.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/PagesList.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/PagesList.java
index f1cc32a..e79570e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/PagesList.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/PagesList.java
@@ -852,7 +852,6 @@ public abstract class PagesList extends DataStructure {
* @return {@code true} If succeeded.
* @throws IgniteCheckedException if failed.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
private boolean putReuseBag(
final long pageId,
final long page,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
index 591616d..8d54498 100755
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
@@ -118,7 +118,7 @@ import static org.apache.ignite.internal.util.GridUnsafe.wrapPointer;
* Note that first 8 bytes of page header are used either for page marker or for next relative pointer depending
* on whether the page is in use or not.
*/
-@SuppressWarnings({"LockAcquiredButNotSafelyReleased", "FieldAccessedSynchronizedAndUnsynchronized"})
+@SuppressWarnings({"LockAcquiredButNotSafelyReleased"})
public class PageMemoryImpl implements PageMemoryEx {
/** */
public static final long PAGE_MARKER = 0x0000000000000001L;
@@ -398,7 +398,6 @@ public class PageMemoryImpl implements PageMemoryEx {
}
/** {@inheritDoc} */
- @SuppressWarnings("OverlyStrongTypeCast")
@Override public void stop(boolean deallocate) throws IgniteException {
if (log.isDebugEnabled())
log.debug("Stopping page memory.");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/BPlusTree.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/BPlusTree.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/BPlusTree.java
index fd7fba6..17799d3 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/BPlusTree.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/BPlusTree.java
@@ -86,7 +86,7 @@ import static org.apache.ignite.internal.processors.cache.persistence.tree.BPlus
/**
* Abstract B+Tree.
*/
-@SuppressWarnings({"RedundantThrowsDeclaration", "ConstantValueVariableUse"})
+@SuppressWarnings({"ConstantValueVariableUse"})
public abstract class BPlusTree<L, T extends L> extends DataStructure implements IgniteTree<L, T> {
/** */
private static final Object[] EMPTY = {};
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java
index 1cc2bf3..fbc4f6c 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java
@@ -1865,7 +1865,6 @@ public class FileWriteAheadLogManager extends GridCacheSharedManagerAdapter impl
* @return <ul><li>{@code True} if can read, no lock is held, </li><li>{@code false} if work segment, need
* release segment later, use {@link #releaseWorkSegment} for unlock</li> </ul>
*/
- @SuppressWarnings("NonPrivateFieldAccessedInSynchronizedContext")
public boolean checkCanReadArchiveOrReserveWorkSegment(long absIdx) {
return segmentAware.checkCanReadArchiveOrReserveWorkSegment(absIdx);
}
@@ -1873,7 +1872,6 @@ public class FileWriteAheadLogManager extends GridCacheSharedManagerAdapter impl
/**
* @param absIdx Segment absolute index.
*/
- @SuppressWarnings("NonPrivateFieldAccessedInSynchronizedContext")
public void releaseWorkSegment(long absIdx) {
segmentAware.releaseWorkSegment(absIdx);
}
@@ -3294,7 +3292,6 @@ public class FileWriteAheadLogManager extends GridCacheSharedManagerAdapter impl
/**
* WAL writer worker.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
private class WALWriter extends GridWorker {
/** Unconditional flush. */
private static final long UNCONDITIONAL_FLUSH = -1L;
@@ -3485,7 +3482,6 @@ public class FileWriteAheadLogManager extends GridCacheSharedManagerAdapter impl
/**
* @param expPos Expected position.
*/
- @SuppressWarnings("ForLoopReplaceableByForEach")
void flushBuffer(long expPos) throws IgniteCheckedException {
if (mmap)
return;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FsyncModeFileWriteAheadLogManager.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FsyncModeFileWriteAheadLogManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FsyncModeFileWriteAheadLogManager.java
index c74c7ef..c9919f5 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FsyncModeFileWriteAheadLogManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FsyncModeFileWriteAheadLogManager.java
@@ -1761,7 +1761,6 @@ public class FsyncModeFileWriteAheadLogManager extends GridCacheSharedManagerAda
* @return <ul><li>{@code True} if can read, no lock is held, </li><li>{@code false} if work segment, need
* release segment later, use {@link #releaseWorkSegment} for unlock</li> </ul>
*/
- @SuppressWarnings("NonPrivateFieldAccessedInSynchronizedContext")
private boolean checkCanReadArchiveOrReserveWorkSegment(long absIdx) {
synchronized (this) {
if (lastAbsArchivedIdx >= absIdx) {
@@ -1788,7 +1787,6 @@ public class FsyncModeFileWriteAheadLogManager extends GridCacheSharedManagerAda
/**
* @param absIdx Segment absolute index.
*/
- @SuppressWarnings("NonPrivateFieldAccessedInSynchronizedContext")
private void releaseWorkSegment(long absIdx) {
synchronized (this) {
Integer cur = locked.get(absIdx);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/aware/SegmentLockStorage.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/aware/SegmentLockStorage.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/aware/SegmentLockStorage.java
index f638d4d..6588769 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/aware/SegmentLockStorage.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/aware/SegmentLockStorage.java
@@ -46,7 +46,6 @@ public class SegmentLockStorage extends SegmentObservable {
* @return <ul><li>{@code True} if can read, no lock is held, </li><li>{@code false} if work segment, need release
* segment later, use {@link #releaseWorkSegment} for unlock</li> </ul>
*/
- @SuppressWarnings("NonPrivateFieldAccessedInSynchronizedContext")
boolean lockWorkSegment(long absIdx) {
locked.compute(absIdx, (idx, count) -> count == null ? 1 : count + 1);
@@ -56,7 +55,6 @@ public class SegmentLockStorage extends SegmentObservable {
/**
* @param absIdx Segment absolute index.
*/
- @SuppressWarnings("NonPrivateFieldAccessedInSynchronizedContext")
void releaseWorkSegment(long absIdx) {
locked.compute(absIdx, (idx, count) -> {
assert count != null && count >= 1 : "cur=" + count + ", absIdx=" + absIdx;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordDataV1Serializer.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordDataV1Serializer.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordDataV1Serializer.java
index ee40039..0ad92e3 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordDataV1Serializer.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordDataV1Serializer.java
@@ -1797,7 +1797,6 @@ public class RecordDataV1Serializer implements RecordDataSerializer {
* @param buf Buffer.
* @param rowBytes Row bytes.
*/
- @SuppressWarnings("unchecked")
private static void putRow(ByteBuffer buf, byte[] rowBytes) {
assert rowBytes.length > 0;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV1Serializer.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV1Serializer.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV1Serializer.java
index 31efa1f..ee5a1e2 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV1Serializer.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV1Serializer.java
@@ -218,7 +218,6 @@ public class RecordV1Serializer implements RecordSerializer {
}
/** {@inheritDoc} */
- @SuppressWarnings("CastConflictsWithInstanceof")
@Override public void writeRecord(WALRecord rec, ByteBuffer buf) throws IgniteCheckedException {
writeWithCrc(rec, buf, recordIO);
}
@@ -229,7 +228,6 @@ public class RecordV1Serializer implements RecordSerializer {
}
/** {@inheritDoc} */
- @SuppressWarnings("CastConflictsWithInstanceof")
@Override public int size(WALRecord record) throws IgniteCheckedException {
return recordIO.sizeWithHeaders(record);
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java
index ce9a175..36ee3ba 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java
@@ -527,7 +527,7 @@ public class GridCacheQueryAdapter<T> implements CacheQuery<T> {
}
/** {@inheritDoc} */
- @SuppressWarnings({"IfMayBeConditional", "unchecked"})
+ @SuppressWarnings({"unchecked"})
@Override public GridCloseableIterator executeScanQuery() throws IgniteCheckedException {
assert type == SCAN : "Wrong processing of query: " + type;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryFutureAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryFutureAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryFutureAdapter.java
index 9a5dd26..140966e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryFutureAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryFutureAdapter.java
@@ -360,7 +360,7 @@ public abstract class GridCacheQueryFutureAdapter<K, V, R> extends GridFutureAda
* @param err Error (if was).
* @param finished Finished or not.
*/
- @SuppressWarnings({"unchecked", "NonPrivateFieldAccessedInSynchronizedContext"})
+ @SuppressWarnings({"unchecked"})
public void onPage(@Nullable UUID nodeId, @Nullable Collection<?> data, @Nullable Throwable err, boolean finished) {
if (isCancelled())
return;
@@ -438,7 +438,6 @@ public abstract class GridCacheQueryFutureAdapter<K, V, R> extends GridFutureAda
* @param col Collection.
* @return Collection with masked {@code null} values.
*/
- @SuppressWarnings("unchecked")
private Collection<Object> maskNulls(Collection<Object> col) {
assert col != null;
@@ -453,7 +452,6 @@ public abstract class GridCacheQueryFutureAdapter<K, V, R> extends GridFutureAda
* @param col Collection.
* @return Collection with unmasked {@code null} values.
*/
- @SuppressWarnings("unchecked")
private Collection<Object> unmaskNulls(Collection<Object> col) {
assert col != null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
index 914ff0f..f42164e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
@@ -319,7 +319,6 @@ public abstract class GridCacheQueryManager<K, V> extends GridCacheManagerAdapte
* @param cancel Cancel queries.
* @param destroy Cache destroy flag..
*/
- @SuppressWarnings({"LockAcquiredButNotSafelyReleased"})
@Override public final void stop0(boolean cancel, boolean destroy) {
if (log.isDebugEnabled())
log.debug("Stopped cache query manager.");
@@ -1576,9 +1575,7 @@ public abstract class GridCacheQueryManager<K, V> extends GridCacheManagerAdapte
* @return Fields query result.
* @throws IgniteCheckedException In case of error.
*/
- @SuppressWarnings({
- "SynchronizationOnLocalVariableOrMethodParameter",
- "NonPrivateFieldAccessedInSynchronizedContext"})
+ @SuppressWarnings("SynchronizationOnLocalVariableOrMethodParameter")
private FieldsResult fieldsQueryResult(Map<Long, GridFutureAdapter<FieldsResult>> resMap,
GridCacheQueryInfo qryInfo, String taskName) throws IgniteCheckedException {
assert resMap != null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryListener.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryListener.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryListener.java
index 029b6d8..34e3d86 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryListener.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryListener.java
@@ -18,7 +18,6 @@
package org.apache.ignite.internal.processors.cache.query.continuous;
import java.util.Map;
-import org.apache.ignite.cache.query.ContinuousQuery;
import org.apache.ignite.internal.GridKernalContext;
import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
import org.apache.ignite.internal.processors.cache.GridCacheContext;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheStoreManagerAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheStoreManagerAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheStoreManagerAdapter.java
index ab28aa3..2f7b02b 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheStoreManagerAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheStoreManagerAdapter.java
@@ -459,7 +459,6 @@ public abstract class GridCacheStoreManagerAdapter extends GridCacheManagerAdapt
try {
IgniteBiInClosure<Object, Object> c = new CI2<Object, Object>() {
- @SuppressWarnings("ConstantConditions")
@Override public void apply(Object k, Object val) {
if (convert) {
Object v = convert(val);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTransactionsImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTransactionsImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTransactionsImpl.java
index 11bf219..5d2686c 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTransactionsImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTransactionsImpl.java
@@ -151,7 +151,6 @@ public class IgniteTransactionsImpl<K, V> implements IgniteTransactionsEx {
* @param sysCacheCtx System cache context.
* @return Transaction.
*/
- @SuppressWarnings("unchecked")
private GridNearTxLocal txStart0(
TransactionConcurrency concurrency,
TransactionIsolation isolation,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java
index 399359b..8d2d50b 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java
@@ -479,7 +479,6 @@ public abstract class IgniteTxAdapter extends GridMetadataAwareAdapter implement
/**
* Uncommits transaction by invalidating all of its entries. Courtesy to minimize inconsistency.
*/
- @SuppressWarnings({"CatchGenericClass"})
protected void uncommit() {
for (IgniteTxEntry e : writeMap().values()) {
try {
@@ -837,7 +836,6 @@ public abstract class IgniteTxAdapter extends GridMetadataAwareAdapter implement
}
/** {@inheritDoc} */
- @SuppressWarnings("SimplifiableIfStatement")
@Override public boolean ownsLock(GridCacheEntryEx entry) throws GridCacheEntryRemovedException {
GridCacheContext<?, ?> cacheCtx = entry.context();
@@ -853,7 +851,6 @@ public abstract class IgniteTxAdapter extends GridMetadataAwareAdapter implement
}
/** {@inheritDoc} */
- @SuppressWarnings("SimplifiableIfStatement")
@Override public boolean ownsLockUnsafe(GridCacheEntryEx entry) {
GridCacheContext cacheCtx = entry.context();
@@ -1045,7 +1042,6 @@ public abstract class IgniteTxAdapter extends GridMetadataAwareAdapter implement
}
/** {@inheritDoc} */
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
@Override public IgniteInternalFuture<IgniteInternalTx> finishFuture() {
GridFutureAdapter<IgniteInternalTx> fut = finFut;
@@ -1402,7 +1398,6 @@ public abstract class IgniteTxAdapter extends GridMetadataAwareAdapter implement
* @param writeEntries Transaction write set.
* @throws IgniteCheckedException If batch update failed.
*/
- @SuppressWarnings({"CatchGenericClass"})
protected final void batchStoreCommit(Iterable<IgniteTxEntry> writeEntries) throws IgniteCheckedException {
if (!storeEnabled() || internal() ||
(!local() && near())) // No need to work with local store at GridNearTxRemote.
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxEntry.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxEntry.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxEntry.java
index 8e65605..7d0f988 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxEntry.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxEntry.java
@@ -176,7 +176,6 @@ public class IgniteTxEntry implements GridPeerDeployAware, Message {
private GridCacheContext<?, ?> ctx;
/** Prepared flag to prevent multiple candidate add. */
- @SuppressWarnings("UnusedDeclaration")
@GridDirectTransient
private transient volatile int prepared;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java
index cb5ec91..df43615 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java
@@ -126,7 +126,6 @@ public abstract class IgniteTxLocalAdapter extends IgniteTxAdapter implements Ig
protected GridCacheVersion minVer;
/** Flag indicating with TM commit happened. */
- @SuppressWarnings("UnusedDeclaration")
protected volatile int doneFlag;
/** Committed versions, relative to base. */
@@ -400,7 +399,6 @@ public abstract class IgniteTxLocalAdapter extends IgniteTxAdapter implements Ig
}
/** {@inheritDoc} */
- @SuppressWarnings({"RedundantTypeArguments"})
@Nullable @Override public GridTuple<CacheObject> peek(
GridCacheContext cacheCtx,
boolean failFast,
@@ -427,7 +425,6 @@ public abstract class IgniteTxLocalAdapter extends IgniteTxAdapter implements Ig
* @param entries Entries to lock or {@code null} if use default {@link IgniteInternalTx#optimisticLockEntries()}.
* @throws IgniteCheckedException If prepare step failed.
*/
- @SuppressWarnings({"CatchGenericClass"})
public void userPrepare(@Nullable Collection<IgniteTxEntry> entries) throws IgniteCheckedException {
if (state() != PREPARING) {
if (remainingTime() == -1)
@@ -553,7 +550,6 @@ public abstract class IgniteTxLocalAdapter extends IgniteTxAdapter implements Ig
}
/** {@inheritDoc} */
- @SuppressWarnings({"CatchGenericClass"})
@Override public void userCommit() throws IgniteCheckedException {
TransactionState state = state();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java
index 032df22..bb4ad5d 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java
@@ -733,7 +733,7 @@ public class IgniteTxManager extends GridCacheSharedManagerAdapter {
/**
* @return Transaction for current thread.
*/
- @SuppressWarnings({"unchecked", "RedundantCast"})
+ @SuppressWarnings({"unchecked"})
public <T> T tx() {
IgniteInternalTx tx = txContext();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TransactionProxyRollbackOnlyImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TransactionProxyRollbackOnlyImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TransactionProxyRollbackOnlyImpl.java
index 74735f9..1bc5ecd 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TransactionProxyRollbackOnlyImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TransactionProxyRollbackOnlyImpl.java
@@ -26,7 +26,6 @@ import org.apache.ignite.lang.IgniteFuture;
/**
* Cache transaction proxy which support only rollback or close operations and getters.
*/
-@SuppressWarnings("unchecked")
public class TransactionProxyRollbackOnlyImpl<K, V> extends TransactionProxyImpl<K, V> {
/** */
private static final long serialVersionUID = 0L;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersion.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersion.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersion.java
index 67bd49e..07388e0 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersion.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersion.java
@@ -220,7 +220,6 @@ public class GridCacheVersion implements Message, Comparable<GridCacheVersion>,
}
/** {@inheritDoc} */
- @SuppressWarnings("IfMayBeConditional")
@Override public int compareTo(GridCacheVersion other) {
int res = Integer.compare(topologyVersion(), other.topologyVersion());
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersionManager.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersionManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersionManager.java
index 2a6526a..7ed29cb 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersionManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheVersionManager.java
@@ -60,7 +60,6 @@ public class GridCacheVersionManager extends GridCacheSharedManagerAdapter {
private volatile GridCacheVersion last;
/** Data center ID. */
- @SuppressWarnings("FieldAccessedSynchronizedAndUnsynchronized")
private byte dataCenterId;
/** */
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/IgniteCacheObjectProcessorImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/IgniteCacheObjectProcessorImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/IgniteCacheObjectProcessorImpl.java
index 7f55614..2170d54 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/IgniteCacheObjectProcessorImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/IgniteCacheObjectProcessorImpl.java
@@ -127,7 +127,6 @@ public class IgniteCacheObjectProcessorImpl extends GridProcessorAdapter impleme
* before stored in cache.
* @return Key cache object.
*/
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
protected KeyCacheObject toCacheKeyObject0(CacheObjectContext ctx,
@Nullable GridCacheContext cctx,
Object obj,
@@ -243,7 +242,6 @@ public class IgniteCacheObjectProcessorImpl extends GridProcessorAdapter impleme
* before stored in cache.
* @return Cache object.
*/
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
protected CacheObject toCacheObject0(@Nullable Object obj, boolean userObj) {
assert obj != null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicReferenceImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicReferenceImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicReferenceImpl.java
index df126d9..0c98ba1 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicReferenceImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicReferenceImpl.java
@@ -273,7 +273,6 @@ public final class GridCacheAtomicReferenceImpl<T> extends AtomicDataStructurePr
* @return Reconstructed object.
* @throws ObjectStreamException Thrown in case of unmarshalling error.
*/
- @SuppressWarnings("unchecked")
private Object readResolve() throws ObjectStreamException {
try {
IgniteBiTuple<GridKernalContext, String> t = stash.get();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicSequenceImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicSequenceImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicSequenceImpl.java
index 4e20267..be2efa3 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicSequenceImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicSequenceImpl.java
@@ -181,7 +181,6 @@ public final class GridCacheAtomicSequenceImpl extends AtomicDataStructureProxy<
* @return Sequence value.
* @throws IgniteCheckedException If update failed.
*/
- @SuppressWarnings("SignalWithoutCorrespondingAwait")
private long internalUpdate(long l, @Nullable Callable<Long> updateCall, boolean updated) throws IgniteCheckedException {
checkRemoved();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicStampedImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicStampedImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicStampedImpl.java
index c30f662..c193918 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicStampedImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheAtomicStampedImpl.java
@@ -244,7 +244,6 @@ public final class GridCacheAtomicStampedImpl<T, S> extends AtomicDataStructureP
* @return Reconstructed object.
* @throws ObjectStreamException Thrown in case of unmarshalling error.
*/
- @SuppressWarnings("unchecked")
private Object readResolve() throws ObjectStreamException {
try {
IgniteBiTuple<GridKernalContext, String> t = stash.get();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheLockImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheLockImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheLockImpl.java
index 6b80e9e..0a59e1f 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheLockImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheLockImpl.java
@@ -1030,7 +1030,6 @@ public final class GridCacheLockImpl extends AtomicDataStructureProxy<GridCacheL
* @param key Reentrant lock key.
* @param lockView Reentrant lock projection.
*/
- @SuppressWarnings("unchecked")
public GridCacheLockImpl(String name,
GridCacheInternalKey key,
IgniteInternalCache<GridCacheInternalKey, GridCacheLockState> lockView) {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueAdapter.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueAdapter.java
index 6505624..d591a29 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueAdapter.java
@@ -105,7 +105,6 @@ public abstract class GridCacheQueueAdapter<T> extends AbstractCollection<T> imp
* @param hdr Queue hdr.
* @param cctx Cache context.
*/
- @SuppressWarnings("unchecked")
protected GridCacheQueueAdapter(String queueName, GridCacheQueueHeader hdr, GridCacheContext<?, ?> cctx) {
this.cctx = cctx;
this.queueName = queueName;
@@ -567,7 +566,6 @@ public abstract class GridCacheQueueAdapter<T> extends AbstractCollection<T> imp
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public void close() {
if (rmvd)
return;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueProxy.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueProxy.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueProxy.java
index b74b67f..627f8ec 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueProxy.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueProxy.java
@@ -123,7 +123,6 @@ public class GridCacheQueueProxy<T> implements IgniteQueue<T>, Externalizable {
}
/** {@inheritDoc} */
- @SuppressWarnings("SuspiciousMethodCalls")
@Override public boolean contains(final Object item) {
gate.enter();
@@ -160,7 +159,6 @@ public class GridCacheQueueProxy<T> implements IgniteQueue<T>, Externalizable {
}
/** {@inheritDoc} */
- @SuppressWarnings("SuspiciousMethodCalls")
@Override public boolean remove(final Object item) {
gate.enter();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheSetImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheSetImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheSetImpl.java
index f6a1378..8aae9d0 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheSetImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheSetImpl.java
@@ -181,7 +181,6 @@ public class GridCacheSetImpl<T> extends AbstractCollection<T> implements Ignite
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public boolean isEmpty() {
onAccess();
@@ -514,7 +513,6 @@ public class GridCacheSetImpl<T> extends AbstractCollection<T> implements Ignite
* @return Nodes where set data request should be sent.
* @throws IgniteCheckedException If all cache nodes left grid.
*/
- @SuppressWarnings("unchecked")
private Collection<ClusterNode> dataNodes(AffinityTopologyVersion topVer) throws IgniteCheckedException {
if (ctx.isLocal() || ctx.isReplicated())
return Collections.singleton(ctx.localNode());
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridSetQueryPredicate.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridSetQueryPredicate.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridSetQueryPredicate.java
index 2de3dec..a9b37c3 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridSetQueryPredicate.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridSetQueryPredicate.java
@@ -89,7 +89,6 @@ public class GridSetQueryPredicate<K, V> implements IgniteBiPredicate<K, V>, Ext
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public boolean apply(K k, V v) {
return !filter || ctx.affinity().primaryByKey(ctx.localNode(), k, ctx.affinity().affinityTopologyVersion());
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopClassLoader.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopClassLoader.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopClassLoader.java
index 7dfc138..74dcde2 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopClassLoader.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopClassLoader.java
@@ -85,7 +85,6 @@ public class HadoopClassLoader extends URLClassLoader implements ClassCache {
private final ConcurrentMap<String, Class> cacheMap = new ConcurrentHashMap<>();
/** Diagnostic name of this class loader. */
- @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"})
private final String name;
/** Igfs Helper. */
@@ -384,7 +383,6 @@ public class HadoopClassLoader extends URLClassLoader implements ClassCache {
* @param clsName Class name.
* @return Whether class must be loaded by current classloader without delegation.
*/
- @SuppressWarnings("RedundantIfStatement")
public static boolean loadByCurrentClassloader(String clsName) {
// All impl classes.
if (clsName.startsWith("org.apache.ignite.internal.processors.hadoop.impl"))
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopNoopHelper.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopNoopHelper.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopNoopHelper.java
index 986af1f..111b591 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopNoopHelper.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopNoopHelper.java
@@ -32,7 +32,6 @@ public class HadoopNoopHelper implements HadoopHelper {
*
* @param ctx Kernal context.
*/
- @SuppressWarnings("UnusedParameters")
public HadoopNoopHelper(GridKernalContext ctx) {
// No-op.
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsDataManager.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsDataManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsDataManager.java
index 5f5b69d..5f8f314 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsDataManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsDataManager.java
@@ -1080,7 +1080,6 @@ public class IgfsDataManager extends IgfsManager {
* @param blocks Blocks to write.
* @return Future that will be completed after put is done.
*/
- @SuppressWarnings("unchecked")
private IgniteInternalFuture<?> storeBlocksAsync(Map<IgfsBlockKey, byte[]> blocks) {
assert !blocks.isEmpty();
return dataCachePrj.putAllAsync(blocks);
@@ -1118,7 +1117,6 @@ public class IgfsDataManager extends IgfsManager {
* @param nodeId Node ID.
* @param ackMsg Write acknowledgement message.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void processAckMessage(UUID nodeId, IgfsAckMessage ackMsg) {
try {
ackMsg.finishUnmarshal(igfsCtx.kernalContext().config().getMarshaller(), null);