[GitHub] [superset] ad-m commented on pull request #18170: refactor: extract json_required view decorator

[GitBox <gi...@apache.org>]

ad-m commented on pull request #18170:
URL: https://github.com/apache/superset/pull/18170#issuecomment-1022108096


   I like to make it even more generic. I will apply you suggestion soon!
   
   śr., 26 sty 2022, 12:21 użytkownik Michael S. Molina <
   ***@***.***> napisał:
   
   > Thank you for the PR @ad-m <https://github.com/ad-m>. Grabbing an example
   > from Java, I really like the abstraction of @Produces and @Consumes
   > annotations of JAX-RS
   > <https://docs.oracle.com/cd/E19798-01/821-1841/gipzh/index.html>. They
   > accept the MIME type as an argument.
   >
   > @Consumes("application/json")
   >
   > Since request.is_json
   > <https://flask.palletsprojects.com/en/2.0.x/api/#flask.Request.is_json>
   > is pretty much checking the MIME type we could create a generic decorator
   > the same way JAX-RS does. This will allow us to validate all request types
   > in our endpoints.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/superset/pull/18170#issuecomment-1022106122>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AA3TNL3EOCQQLMKJOC56K4LUX7KLRANCNFSM5MZ3RLVA>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org