You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/09/01 00:28:21 UTC
Re: Review Request 37939: RANGER-274: TagREST updated with new
methods; renamed RangerTag.attributeValues ==> attributes;
RangerServiceResource.resourceSpec ==> resourceElements
> On Aug. 31, 2015, 9:25 p.m., Abhay Kulkarni wrote:
> > security-admin/src/main/java/org/apache/ranger/rest/TagREST.java, line 720
> > <https://reviews.apache.org/r/37939/diff/1-3/?file=1060254#file1060254line720>
> >
> > How will a client compute correct resourceSignature?
Good point. TagREST should have retain the following deleted method to address this need: getServiceResource(serviceName, Map<String, PolicyResource>(). I will add it in the next iteration. Thanks!
> On Aug. 31, 2015, 9:25 p.m., Abhay Kulkarni wrote:
> > security-admin/src/main/java/org/apache/ranger/rest/TagREST.java, line 853
> > <https://reviews.apache.org/r/37939/diff/1-3/?file=1060254#file1060254line853>
> >
> > Why is this change (tagGuid->tag-guid, etc) necessary?
This is to avoid using of mixed case path/query params.
> On Aug. 31, 2015, 9:25 p.m., Abhay Kulkarni wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/store/TagPredicateUtil.java, line 46
> > <https://reviews.apache.org/r/37939/diff/3/?file=1060577#file1060577line46>
> >
> > TAG_DEF_NAME reuse here is confusing. I believe this is referring to 'name' attribute in RangerTag object. TAG_DEF_NAME is also used when adding another predicate addPredicateForTagDefName, which may cause more confusion.
I agree it is confusing to use TAG_DEF_NAME to search Tag objects. I renamed RangerTag.name ==> type (as used in RangerServiceDef and RangerService) and renamed the search paramter to TAG_TYPE.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37939/#review97148
-----------------------------------------------------------
On Aug. 31, 2015, 8:56 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37939/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 8:56 p.m.)
>
>
> Review request for ranger, Gautam Borad and Abhay Kulkarni.
>
>
> Bugs: RANGER-274
> https://issues.apache.org/jira/browse/RANGER-274
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - TagREST updates:
> - fix incorrect URLs
> - new methods deleteTagDefByGuid(), getTagDef(id), getTagDefByGuid(), getAllServiceResources(), deleteTagResourceMap(), deleteTagResourceMapByGuid(), getTagResourceMap(), getTagResourceMapByGuid(), getTagResourceMap(tagGuid, resourceGuid), getAllTagResourceMaps()
> - Fix: TagDBStore.deleteTagDef() to delete attributeDefs
> - Renamed: RangerTag.attributeValues ==> RangerTag.attributes
> - Renamed: RangerScriptExecutionContext.getAttributeValues() ==> RangerScriptExecutionContext.getAttributes()
> - Renamed: RangerServiceResource.resourceSpec ==> RangerServiceResource.resourceElements
> - Renamed: Inner class: ServiceResourceSpecSerializer ==> ServiceResourceSerializer
> - Added: TagStore.getTagResourceMapByGuid()
> - Added: TagFileStore.getTagResourceMapByGuid()
> - Added: TagDBStore.getTagResourceMapByGuid()
> - Added: TagValidator.preDeleteTagResourceMapById()
> - Added: TagValidator.preDeleteTagResourceMapByGuid()
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java 6fe5262
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagProvider.java 83600c9
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java c9e07eb
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTag.java 6e4685a
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagResourceMap.java 8fca4c7
> agents-common/src/main/java/org/apache/ranger/plugin/store/RangerServiceResourceSignature.java 1affec5
> agents-common/src/main/java/org/apache/ranger/plugin/store/TagPredicateUtil.java de48240
> agents-common/src/main/java/org/apache/ranger/plugin/store/TagStore.java f9d1086
> agents-common/src/main/java/org/apache/ranger/plugin/store/TagValidator.java 8c2b230
> agents-common/src/main/java/org/apache/ranger/plugin/store/file/TagFileStore.java 0b4f0ca
> agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 743df88
> agents-common/src/test/java/org/apache/ranger/plugin/store/TestTagStore.java 5424158
> agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json f7fab3d
> security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 629d1c4
> security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java 08a632c
> security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceDao.java 7e29e36
> security-admin/src/main/java/org/apache/ranger/db/XXTagDefDao.java f18fea8
> security-admin/src/main/java/org/apache/ranger/db/XXTagResourceMapDao.java 75d04ae
> security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 1d8493a
> security-admin/src/main/java/org/apache/ranger/rest/TagREST.java b06f5cc
> security-admin/src/main/java/org/apache/ranger/rest/TagRESTConstants.java 91525df
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java a81b981
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceServiceBase.java 1510ffa
> security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java 462b781
> security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java 6894e4e
> security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java 3d7ea24
> security-admin/src/main/java/org/apache/ranger/service/RangerTagServiceBase.java 359e7ae
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml a05e0bd
>
> Diff: https://reviews.apache.org/r/37939/diff/
>
>
> Testing
> -------
>
> Verified that TagREST methods work correctly.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>