You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@toree.apache.org by "lresende (via GitHub)" <gi...@apache.org> on 2025/10/06 05:37:12 UTC

Re: [PR] Jupyter Spark monitor [incubator-toree]

lresende commented on PR #229:
URL: https://github.com/apache/incubator-toree/pull/229#issuecomment-3369991807

   Hi @vincentye38, some things I noticed :
   - [x] make commands were not building the jar automatically 
   - [x] jar names were not being prefixed with `toree`
   - [x] rewrote the JSON parser using playjson to avoid adding new dependencies
   - [] Magic URL is a bit strange, but I understand this is something that was already there
   
   
   <img width="1481" height="417" alt="image" src="https://github.com/user-attachments/assets/93aac96b-2864-402d-92e9-1a70e8aa853a" />
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org