You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksei Zotov (Jira)" <ji...@apache.org> on 2021/10/13 10:14:00 UTC
[jira] [Updated] (CASSANDRA-16976) Make nodetool compactionstats
and sstable_tasks consistent
[ https://issues.apache.org/jira/browse/CASSANDRA-16976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksei Zotov updated CASSANDRA-16976:
--------------------------------------
Test and Documentation Plan: I wrote unit tests to cover both existing and new logic. Also I updated documentation.
Status: Patch Available (was: Open)
[~brandon.williams] [~stefan.miklosovic]
I created tests to validate outputs of the nodetool command and the VT. Could you please check the PR. In the meantime, I've triggered [CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1206/].
PS:
After checking the suggested dtest, I came to conclusion that it would be an overhead to generate a bunch of data to ensure that we catch compaction in progress. So I just start/finish compaction manually on some hardcoded data. Taking into account this functionality is trivial (and not mission critical) and we need to test output format only, I feel this is more than enough. Please, let me know if you have any concerns.
> Make nodetool compactionstats and sstable_tasks consistent
> ----------------------------------------------------------
>
> Key: CASSANDRA-16976
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16976
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Virtual Tables, Tool/nodetool
> Reporter: Aleksei Zotov
> Assignee: Aleksei Zotov
> Priority: Normal
> Fix For: 4.x
>
>
> Currently there is a difference in the output if {{nodetool compactionstats}} command and {{sstable_tasks}} virtual table (originally introduced by CASSANDRA-14457). They need to be aligned. The differences are:
>
> ||nodetool||VT||Comment||
> |percentComplete|completion_ratio|column naming is different only|
> |completed|progress|column naming is different only|
> |compaction type|kind|column naming is different only|
> |sstables|NA| |
> Additionally, please, update necessary documentation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org