You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/12/06 21:47:48 UTC
[PR] Align Jetty versions [maven-resolver]
cstamas opened a new pull request, #390:
URL: https://github.com/apache/maven-resolver/pull/390
Move off dead Jetty 9, and use 10.x in both modules, update to latest minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align Jetty versions [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #390:
URL: https://github.com/apache/maven-resolver/pull/390#discussion_r1418020910
##########
maven-resolver-transport-apache/pom.xml:
##########
@@ -128,6 +128,12 @@
<version>${jettyVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.http2</groupId>
+ <artifactId>http2-server</artifactId>
+ <version>${jettyVersion}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
@olamy while here: am a bit hesitating "pulling up" jetty version and thus locking the two together: jetty client used in jetty transport and jetty server used in "server" that is used in tests... or do you see any counter argument for doing that?
As in that case, I'd import Jetty BOM at top level POM...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-448] Align Jetty versions [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #390:
URL: https://github.com/apache/maven-resolver/pull/390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align Jetty versions [maven-resolver]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #390:
URL: https://github.com/apache/maven-resolver/pull/390#discussion_r1418016922
##########
maven-resolver-transport-apache/pom.xml:
##########
@@ -128,6 +128,12 @@
<version>${jettyVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.http2</groupId>
+ <artifactId>http2-server</artifactId>
+ <version>${jettyVersion}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Jetty is providing a bom ;) https://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-bom/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align Jetty versions [maven-resolver]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #390:
URL: https://github.com/apache/maven-resolver/pull/390#discussion_r1418119841
##########
maven-resolver-transport-apache/pom.xml:
##########
@@ -128,6 +128,12 @@
<version>${jettyVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.http2</groupId>
+ <artifactId>http2-server</artifactId>
+ <version>${jettyVersion}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
yup just align version as anyway you have a minimum build jdk requirement which is good enough for jetty 10.
Jetty 12 is another story as it's jdk17 required but you could simplify test and dependencies needed by simply using the new servlet API less handlers. (but that's another story :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org