You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/17 01:03:19 UTC
[kudu-CR](branch-1.11.x) webserver: support HTTP OPTIONS requests
Hello Thomas Tauber-Marshall, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14475
to review the following change.
Change subject: webserver: support HTTP OPTIONS requests
......................................................................
webserver: support HTTP OPTIONS requests
This is a port of IMPALA-8982 to Kudu, including:
- Updating squeasel to a newer revision that handles OPTIONS rather than
responding with an HTTP 500 error code.
- Modifying the webserver to let squeasel handle OPTIONS, bypassing SPNEGO
authentication.
Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Reviewed-on: http://gerrit.cloudera.org:8080/14439
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
(cherry picked from commit d6a6b54b175032c7d13d231ef6d156ef9d0e3ab0)
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
M thirdparty/vars.sh
5 files changed, 55 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/14475/1
--
To view, visit http://gerrit.cloudera.org:8080/14475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14475
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[kudu-CR](branch-1.11.x) webserver: support HTTP OPTIONS requests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14475 )
Change subject: webserver: support HTTP OPTIONS requests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14475
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2019 22:59:09 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) webserver: support HTTP OPTIONS requests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14475 )
Change subject: webserver: support HTTP OPTIONS requests
......................................................................
webserver: support HTTP OPTIONS requests
This is a port of IMPALA-8982 to Kudu, including:
- Updating squeasel to a newer revision that handles OPTIONS rather than
responding with an HTTP 500 error code.
- Modifying the webserver to let squeasel handle OPTIONS, bypassing SPNEGO
authentication.
Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Reviewed-on: http://gerrit.cloudera.org:8080/14439
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
(cherry picked from commit d6a6b54b175032c7d13d231ef6d156ef9d0e3ab0)
Reviewed-on: http://gerrit.cloudera.org:8080/14475
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
M thirdparty/vars.sh
5 files changed, 55 insertions(+), 8 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14475
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[kudu-CR](branch-1.11.x) webserver: support HTTP OPTIONS requests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: webserver: support HTTP OPTIONS requests
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14475
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[kudu-CR](branch-1.11.x) webserver: support HTTP OPTIONS requests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14475 )
Change subject: webserver: support HTTP OPTIONS requests
......................................................................
Patch Set 2: Verified+1
Unrelated test failures:
* org.apache.kudu.client.ITClientStress
--
To view, visit http://gerrit.cloudera.org:8080/14475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14475
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2019 22:49:33 +0000
Gerrit-HasComments: No