You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 19:13:04 UTC
[GitHub] [beam] damccorm opened a new pull request, #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
damccorm opened a new pull request, #18533:
URL: https://github.com/apache/beam/pull/18533
In #16729, we moved to using the RoleUrn for the Go Worker Binary, with the intent of removing the legacy check after a few sprints. That should be safe now.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1146281396
R: @lostluck since you have the most context - anything I'm missing here that makes this unsafe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1146284860
Run Go Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1146281116
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1146897475
Run Go Postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1146281115
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1146284732
Run Go Flink ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1147440688
Run Go Postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
damccorm closed pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
URL: https://github.com/apache/beam/pull/18533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1147804510
Welp, looks like we can't just do this for free. Any idea what's going on here/why this isn't safe to remove? I'll close for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1146282207
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #18533: [BEAM-13647] Remove legacy Go Worker artifact name check
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #18533:
URL: https://github.com/apache/beam/pull/18533#issuecomment-1146284943
Run Go Samza ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org