You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jyotirmoy-gh (via GitHub)" <gi...@apache.org> on 2023/02/22 11:16:26 UTC
[GitHub] [ozone] jyotirmoy-gh opened a new pull request, #4297: HDDS-8006. [snapshot] Add unit-testcases for snapshot delete
jyotirmoy-gh opened a new pull request, #4297:
URL: https://github.com/apache/ozone/pull/4297
## What changes were proposed in this pull request?
Add unit-testcases for snapshot delete - `TestOmSnapshot`
- testCreateSnapshotMissingMandatoryParams
- testDeleteSnapshotTwice
- testDeleteSnapshotFailure
- testDeleteSnapshotMissingMandatoryParams
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8006
## How was this patch tested?
Testcase files - `hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4297: HDDS-8006. [snapshot] Add unit test cases for snapshot delete
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4297:
URL: https://github.com/apache/ozone/pull/4297#issuecomment-1448851790
@smengcl thanks for submitting revert PR, but I don't think it is necessary. Only `testSnapDiffWithMultipleSSTs` is failing, which has been flaky even before this PR (HDDS-8005), only now it fails consistently. I propose to disable `testSnapDiffWithMultipleSSTs` (via `@Ignore`) and fix it in HDDS-8005, instead of reverting this PR. The new test cases are probably good in themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jyotirmoy-gh commented on pull request #4297: HDDS-8006. [snapshot] Add unit test cases for snapshot delete
Posted by "jyotirmoy-gh (via GitHub)" <gi...@apache.org>.
jyotirmoy-gh commented on PR #4297:
URL: https://github.com/apache/ozone/pull/4297#issuecomment-1449675215
PR for new changes - https://github.com/apache/ozone/pull/4331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl merged pull request #4297: HDDS-8006. [snapshot] Add unit test cases for snapshot delete
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl merged PR #4297:
URL: https://github.com/apache/ozone/pull/4297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #4297: HDDS-8006. [snapshot] Add unit test cases for snapshot delete
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #4297:
URL: https://github.com/apache/ozone/pull/4297#issuecomment-1448853962
> `TestOmSnapshot` (the class being changed) has failed:
>
> * in @jyotirmoy-gh's fork for all 3 commits
>
> * https://github.com/jyotirmoy-gh/ozone/actions/runs/4242114172/jobs/7373203285#step:5:7810
> * https://github.com/jyotirmoy-gh/ozone/actions/runs/4242173232/jobs/7373337122#step:5:3336
> * https://github.com/jyotirmoy-gh/ozone/actions/runs/4242211689/jobs/7373428163#step:5:3336
> * in the PR for both runs of the last commit (was cancelled in previous runs)
>
> * https://github.com/apache/ozone/actions/runs/4242212133/jobs/7373435640#step:5:3336
> * https://github.com/apache/ozone/actions/runs/4242212133/jobs/7474740898#step:5:3336
> * and now on `master`:
>
> * https://github.com/apache/ozone/actions/runs/4296771836/jobs/7488905670#step:5:3383
>
> Please do not merge with failing tests.
Thanks @adoroszlai for pointing that out. Sorry about the trouble. Not sure how I could have missed that in the first place. (Subconsciously I thought the other +1 implied a green CI.) Will double check from now on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #4297: HDDS-8006. [snapshot] Add unit test cases for snapshot delete
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #4297:
URL: https://github.com/apache/ozone/pull/4297#issuecomment-1448861038
> The new test cases are probably good in themselves.
I see. Now that it is reverted we can fix it in a new PR, together with the reverted changes. Would you file a new PR for this @jyotirmoy-gh ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jyotirmoy-gh commented on pull request #4297: HDDS-8006. [snapshot] Add unit test cases for snapshot delete
Posted by "jyotirmoy-gh (via GitHub)" <gi...@apache.org>.
jyotirmoy-gh commented on PR #4297:
URL: https://github.com/apache/ozone/pull/4297#issuecomment-1449326122
@smengcl , I will create a new PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jyotirmoy-gh commented on pull request #4297: HDDS-8006. [snapshot] Add unit-testcases for snapshot delete
Posted by "jyotirmoy-gh (via GitHub)" <gi...@apache.org>.
jyotirmoy-gh commented on PR #4297:
URL: https://github.com/apache/ozone/pull/4297#issuecomment-1439843629
@smengcl @sadanand48 @nilotpalnandi - Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4297: HDDS-8006. [snapshot] Add unit test cases for snapshot delete
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4297:
URL: https://github.com/apache/ozone/pull/4297#issuecomment-1448826355
`TestOmSnapshot` (the class being changed) has failed:
* in @jyotirmoy-gh's fork for all 3 commits
* https://github.com/jyotirmoy-gh/ozone/actions/runs/4242114172/jobs/7373203285#step:5:7810
* https://github.com/jyotirmoy-gh/ozone/actions/runs/4242173232/jobs/7373337122#step:5:3336
* https://github.com/jyotirmoy-gh/ozone/actions/runs/4242211689/jobs/7373428163#step:5:3336
* in the PR for both runs of the last commit (was cancelled in previous runs)
* https://github.com/apache/ozone/actions/runs/4242212133/jobs/7373435640#step:5:3336
* https://github.com/apache/ozone/actions/runs/4242212133/jobs/7474740898#step:5:3336
* and now on `master`:
* https://github.com/apache/ozone/actions/runs/4296771836/jobs/7488905670#step:5:3383
Please do not merge with failing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org