You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/05/16 08:15:23 UTC

[GitHub] [submarine] FYRichie commented on a diff in pull request #922: SUBMARINE-1204. Notebook names cannot start with "submarine"

FYRichie commented on code in PR #922:
URL: https://github.com/apache/submarine/pull/922#discussion_r873445570


##########
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java:
##########
@@ -466,7 +466,9 @@ private boolean isDeploymentAvailable(String name) throws ApiException{
   @Override
   public Notebook createNotebook(NotebookSpec spec, String notebookId) throws SubmarineRuntimeException {
     Notebook notebook;
-    final String name = spec.getMeta().getName();
+    // final String name = spec.getMeta().getName();

Review Comment:
   @pingsutw I will remove this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org