[GitHub] [doris] HappenLee commented on a diff in pull request #15569: [feature](mark join) Support mark join for hash join node

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #15569:
URL: https://github.com/apache/doris/pull/15569#discussion_r1061217020


##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -244,14 +245,30 @@ Status ProcessHashTableProbe<JoinOpType>::do_process(HashTableType& hash_table_c
 
             if constexpr (JoinOpType == TJoinOp::LEFT_ANTI_JOIN ||
                           JoinOpType == TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN) {
-                if (!find_result.is_found()) {
+                if (is_mark_join) {
                     ++current_offset;
+                    assert_cast<doris::vectorized::ColumnVector<UInt8>&>(*mcol[mcol.size() - 1])
+                            .get_data()
+                            .resize_fill(mcol[mcol.size() - 1]->size() + 1,

Review Comment:
   maybe call `push_back` is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org