You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/08/22 12:09:38 UTC
Review Request 13731: Marivn test for cpu and memory overcommit feature.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Marivn test for cpu and memory overcommit feature.
The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
Diffs
-----
test/integration/smoke/test_cpu_memory_overcommit.py PRE-CREATION
Diff: https://reviews.apache.org/r/13731/diff/
Testing
-------
Tested on 4.2
Thanks,
bharat kumar
Re: Review Request 13731: Marivn test for cpu and memory overcommit feature.
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/#review25413
-----------------------------------------------------------
test/integration/smoke/test_cpu_memory_overcommit.py
<https://reviews.apache.org/r/13731/#comment49826>
iterate through each cluster to find suitable cluster if not found, skip the test.
if not <suitablecluster>:
self.skipTest("No suitable cluster found for dedicating. Skipping")
- SrikanteswaraRao Talluri
On Aug. 22, 2013, 10:09 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13731/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 10:09 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Marivn test for cpu and memory overcommit feature.
>
> The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_cpu_memory_overcommit.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13731/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13731: Marivn test for cpu and memory overcommit feature.
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/#review25464
-----------------------------------------------------------
test/integration/component/test_cpu_memory_overcommit.py
<https://reviews.apache.org/r/13731/#comment49886>
you can check for any running VMs, as a cluster with stopped VMs can also be dedicated.
- SrikanteswaraRao Talluri
On Aug. 23, 2013, 9:17 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13731/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2013, 9:17 a.m.)
>
>
> Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Marivn test for cpu and memory overcommit feature.
>
> The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
>
>
> Diffs
> -----
>
> test/integration/component/test_cpu_memory_overcommit.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13731/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13731: Marivn test for cpu and memory overcommit feature.
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/#review25663
-----------------------------------------------------------
Ship it!
Ship It!
- SrikanteswaraRao Talluri
On Aug. 28, 2013, 8:52 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13731/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 8:52 a.m.)
>
>
> Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Marivn test for cpu and memory overcommit feature.
>
> The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
>
>
> Diffs
> -----
>
> test/integration/component/test_cpu_memory_overcommit.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13731/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13731: Marivn test for cpu and memory overcommit feature.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/
-----------------------------------------------------------
(Updated Aug. 28, 2013, 8:52 a.m.)
Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Marivn test for cpu and memory overcommit feature.
The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
Diffs (updated)
-----
test/integration/component/test_cpu_memory_overcommit.py PRE-CREATION
Diff: https://reviews.apache.org/r/13731/diff/
Testing
-------
Tested on 4.2
Thanks,
bharat kumar
Re: Review Request 13731: Marivn test for cpu and memory overcommit feature.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/
-----------------------------------------------------------
(Updated Aug. 23, 2013, 9:17 a.m.)
Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
Changes
-------
Added the code to iterate and pick suitable cluster for dedicating. if no suitable cluster is found we skip the test.
added the tag dedicatedCluster to indicate this test uses dedicated cluster and hence requires a cluster with no vms.
moved the test to components folder from smoke folder.
Repository: cloudstack-git
Description
-------
Marivn test for cpu and memory overcommit feature.
The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
Diffs (updated)
-----
test/integration/component/test_cpu_memory_overcommit.py PRE-CREATION
Diff: https://reviews.apache.org/r/13731/diff/
Testing
-------
Tested on 4.2
Thanks,
bharat kumar
Re: Review Request 13731: Marivn test for cpu and memory overcommit feature.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/
-----------------------------------------------------------
(Updated Aug. 23, 2013, 9:13 a.m.)
Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
Changes
-------
added talluri to the review.
Repository: cloudstack-git
Description
-------
Marivn test for cpu and memory overcommit feature.
The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
Diffs
-----
test/integration/smoke/test_cpu_memory_overcommit.py PRE-CREATION
Diff: https://reviews.apache.org/r/13731/diff/
Testing
-------
Tested on 4.2
Thanks,
bharat kumar
Re: Review Request 13731: Marivn test for cpu and memory overcommit feature.
Posted by bharat kumar <bh...@citrix.com>.
> On Aug. 22, 2013, 11:36 a.m., SrikanteswaraRao Talluri wrote:
> > test/integration/smoke/test_cpu_memory_overcommit.py, line 111
> > <https://reviews.apache.org/r/13731/diff/1/?file=343836#file343836line111>
> >
> > Is management server restart required to take these global setting changes into effect?
Hi Talluri,
listing VMs using hostid always gives a list of running VMs. However i have added state=Running parameter in the list virtual machines api call.
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/#review25412
-----------------------------------------------------------
On Aug. 28, 2013, 8:52 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13731/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 8:52 a.m.)
>
>
> Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Marivn test for cpu and memory overcommit feature.
>
> The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
>
>
> Diffs
> -----
>
> test/integration/component/test_cpu_memory_overcommit.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13731/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13731: Marivn test for cpu and memory overcommit feature.
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13731/#review25412
-----------------------------------------------------------
test/integration/smoke/test_cpu_memory_overcommit.py
<https://reviews.apache.org/r/13731/#comment49824>
Is management server restart required to take these global setting changes into effect?
test/integration/smoke/test_cpu_memory_overcommit.py
<https://reviews.apache.org/r/13731/#comment49825>
releaseDedicateCluster call is not required explicitly if the account is deleted. It doesn't harm though
you will see something like below exception:
Unexpected exception while executing org.apache.cloudstack.api.commands.ReleaseDedicatedClusterCmd
com.cloud.exception.InvalidParameterValueException: No Dedicated Resource available to release
at org.apache.cloudstack.dedicated.DedicatedResourceManagerImpl.releaseDedicatedResource(DedicatedResourceManagerImpl.java:907)
at org.apache.cloudstack.api.commands.ReleaseDedicatedClusterCmd.execute(ReleaseDedicatedClusterCmd.java:73)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
at com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:679)
2013-08-22 22:07:43,167 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Executor-11:job-2821 = [ fca03d52-fb50-425f-a98e-f12555f89713 ]) Complete async job-2821 = [ fca03d52-fb50-425f-a98e-f12555f89713 ], jobStatus: 2, resultCode: 530, result: Error Code: 530 Error text: No Dedicated Resource available to release
- SrikanteswaraRao Talluri
On Aug. 22, 2013, 10:09 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13731/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 10:09 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Marivn test for cpu and memory overcommit feature.
>
> The test requires using dedicated cluster. this can be done only if there are no VMs running in the cluster prior to dedication.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_cpu_memory_overcommit.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13731/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>