[2/2] impala git commit: IMPALA-6906: disable test that depends on memory estimates on S3

[ta...@apache.org]

IMPALA-6906: disable test that depends on memory estimates on S3

S3 divides up scan ranges into synthetic blocks smaller than the
equivalent HDFS blocks, which in turn affects the memory estimate
calculation, so the test that was tuned for HDFS does not work
in the same way as S3.

The test is exercising an admission control code path that is
independent of the filesystem, so we don't gain important coverage by
running this on S3.

ADLS can have similar block size issues, so skip that too.

Change-Id: Ida763a402203286c02ad3cbcbed5336c70abef7c
Reviewed-on: http://gerrit.cloudera.org:8080/10207
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/c557a5bf
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/c557a5bf
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/c557a5bf

Branch: refs/heads/master
Commit: c557a5bfb7695c9e6fb506b57d1c2d952cf5c3a4
Parents: 6165534
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Wed Apr 25 13:49:45 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Thu Apr 26 02:59:27 2018 +0000

----------------------------------------------------------------------
 tests/custom_cluster/test_admission_controller.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/c557a5bf/tests/custom_cluster/test_admission_controller.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_admission_controller.py b/tests/custom_cluster/test_admission_controller.py
index ab09069..5f3ee9e 100644
--- a/tests/custom_cluster/test_admission_controller.py
+++ b/tests/custom_cluster/test_admission_controller.py
@@ -30,6 +30,9 @@ from tests.beeswax.impala_beeswax import ImpalaBeeswaxException
 from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
 from tests.common.environ import specific_build_type_timeout, IMPALAD_BUILD
 from tests.common.impala_test_suite import ImpalaTestSuite
+from tests.common.skip import (
+    SkipIfS3,
+    SkipIfADLS)
 from tests.common.test_dimensions import (
     create_single_exec_option_dimension,
     create_uncompressed_text_dimension)
@@ -379,6 +382,8 @@ class TestAdmissionController(TestAdmissionControllerBase, HS2TestSuite):
       assert re.search("Rejected query from pool default-pool: request memory needed "
           ".* is greater than pool max mem resources 10.00 MB", str(ex))
 
+  @SkipIfS3.hdfs_block_size
+  @SkipIfADLS.hdfs_block_size
   @pytest.mark.execute_serially
   @CustomClusterTestSuite.with_args(
       impalad_args=impalad_admission_ctrl_flags(max_requests=1, max_queued=1,
@@ -386,7 +391,8 @@ class TestAdmissionController(TestAdmissionControllerBase, HS2TestSuite):
       statestored_args=_STATESTORED_ARGS)
   def test_memory_rejection(self, vector):
     """Test that rejection of queries based on reservation and estimates works as
-    expected."""
+    expected. The test depends on scanner memory estimates, which different on remote
+    filesystems with different (synthetic) block sizes."""
     # Test that the query will be rejected by admission control if:
     # a) the largest per-backend min buffer reservation is larger than the query mem limit
     # b) the largest per-backend min buffer reservation is larger than the