You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by amansinha100 <gi...@git.apache.org> on 2015/08/04 02:54:36 UTC
[GitHub] drill pull request: DRILL-2852: Examine the input of a CAST functi...
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/103
DRILL-2852: Examine the input of a CAST function when traversing the …
…expression tree for finding directory filters.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amansinha100/incubator-drill correlation3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit 8b02fa701d685b834585760639cdde3c056ccd2b
Author: Aman Sinha <as...@maprtech.com>
Date: 2015-08-03T23:08:54Z
DRILL-2852: Examine the input of a CAST function when traversing the expression tree for finding directory filters.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2852: Examine the input of a CAST functi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2852: Examine the input of a CAST functi...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/103#discussion_r36213289
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java ---
@@ -217,8 +218,21 @@ public Void visitCorrelVariable(RexCorrelVariable correlVariable) {
}
public Void visitCall(RexCall call) {
- // assume PUSH until proven otherwise
- analyzeCall(call, PushDirFilter.PUSH);
+ boolean visited = false;
+ // examine the input of a CAST function; this could be extended for
+ // other functions in the future.
--- End diff --
Looks like DRILL-3560 reported issues for partition pruning, when it involves a general expression including UDF. I think it would be fine that we address the general expression in DRILL-3560.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2852: Examine the input of a CAST functi...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/103#discussion_r36244389
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java ---
@@ -217,8 +218,21 @@ public Void visitCorrelVariable(RexCorrelVariable correlVariable) {
}
public Void visitCall(RexCall call) {
- // assume PUSH until proven otherwise
- analyzeCall(call, PushDirFilter.PUSH);
+ boolean visited = false;
+ // examine the input of a CAST function; this could be extended for
+ // other functions in the future.
--- End diff --
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2852: Examine the input of a CAST functi...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/103#discussion_r36149446
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java ---
@@ -217,8 +218,21 @@ public Void visitCorrelVariable(RexCorrelVariable correlVariable) {
}
public Void visitCall(RexCall call) {
- // assume PUSH until proven otherwise
- analyzeCall(call, PushDirFilter.PUSH);
+ boolean visited = false;
+ // examine the input of a CAST function; this could be extended for
+ // other functions in the future.
--- End diff --
As the comment indicated, this patch only solves the problem when there is CAST function. Is there any particular reason why other function is not supported? How much effort do we need to get other functions work as well?
I could hit the same problem, with the following filter:
where (dir0 - 1 = 1994 and o_totalprice < 40000) or dir0=1996"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---