You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by an...@apache.org on 2018/12/06 15:55:57 UTC
svn commit: r1848335 [2/2] - in /jackrabbit/oak/trunk:
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/
...
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserImporter.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserImporter.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserImporter.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserImporter.java Thu Dec 6 15:55:56 2018
@@ -411,7 +411,7 @@ class UserImporter implements ProtectedP
}
@Override
- public void startChildInfo(@NotNull NodeInfo childInfo, @NotNull List<PropInfo> propInfos) throws RepositoryException {
+ public void startChildInfo(@NotNull NodeInfo childInfo, @NotNull List<PropInfo> propInfos) {
checkState(currentMembership != null);
String ntName = childInfo.getPrimaryTypeName();
@@ -435,12 +435,12 @@ class UserImporter implements ProtectedP
}
@Override
- public void endChildInfo() throws RepositoryException {
+ public void endChildInfo() {
// nothing to do
}
@Override
- public void end(@NotNull Tree protectedParent) throws RepositoryException {
+ public void end(@NotNull Tree protectedParent) {
currentMembership = null;
}
@@ -454,7 +454,7 @@ class UserImporter implements ProtectedP
}
@NotNull
- private PrincipalManager getPrincipalManager() throws RepositoryException {
+ private PrincipalManager getPrincipalManager() {
return userManager.getPrincipalManager();
}
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java Thu Dec 6 15:55:56 2018
@@ -411,7 +411,7 @@ public class UserManagerImpl implements
}
@NotNull
- PrincipalManager getPrincipalManager() throws RepositoryException {
+ PrincipalManager getPrincipalManager() {
return securityProvider.getConfiguration(PrincipalConfiguration.class).getPrincipalManager(root, namePathMapper);
}
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserValidator.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserValidator.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserValidator.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserValidator.java Thu Dec 6 15:55:56 2018
@@ -129,7 +129,7 @@ class UserValidator extends DefaultValid
}
@Override
- public Validator childNodeChanged(String name, NodeState before, NodeState after) throws CommitFailedException {
+ public Validator childNodeChanged(String name, NodeState before, NodeState after) {
return newValidator(parentBefore.getChild(name),
parentAfter.getChild(name), provider);
}
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/autosave/AutoSaveEnabledManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/autosave/AutoSaveEnabledManager.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/autosave/AutoSaveEnabledManager.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/autosave/AutoSaveEnabledManager.java Thu Dec 6 15:55:56 2018
@@ -168,7 +168,7 @@ public class AutoSaveEnabledManager impl
}
@Override
- public void autoSave(boolean enable) throws RepositoryException {
+ public void autoSave(boolean enable) {
autosave = enable;
}
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/Condition.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/Condition.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/Condition.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/Condition.java Thu Dec 6 15:55:56 2018
@@ -40,7 +40,7 @@ interface Condition {
return pattern;
}
- public void accept(ConditionVisitor visitor) throws RepositoryException {
+ public void accept(ConditionVisitor visitor) {
visitor.visit(this);
}
}
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/ConditionVisitor.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/ConditionVisitor.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/ConditionVisitor.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/ConditionVisitor.java Thu Dec 6 15:55:56 2018
@@ -20,7 +20,7 @@ import javax.jcr.RepositoryException;
interface ConditionVisitor {
- void visit(Condition.Node node) throws RepositoryException;
+ void visit(Condition.Node node);
void visit(Condition.Property condition) throws RepositoryException;
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/XPathConditionVisitor.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/XPathConditionVisitor.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/XPathConditionVisitor.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/XPathConditionVisitor.java Thu Dec 6 15:55:56 2018
@@ -44,7 +44,7 @@ class XPathConditionVisitor implements C
//---------------------------------------------------< ConditionVisitor >---
@Override
- public void visit(Condition.Node condition) throws RepositoryException {
+ public void visit(Condition.Node condition) {
statement.append('(')
.append("jcr:like(@")
.append(QueryUtil.escapeForQuery(UserConstants.REP_AUTHORIZABLE_ID, namePathMapper))
Modified: jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModule.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModule.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModule.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModule.java Thu Dec 6 15:55:56 2018
@@ -186,7 +186,7 @@ public abstract class AbstractLoginModul
}
@Override
- public boolean logout() throws LoginException {
+ public boolean logout() {
boolean success = false;
if (!subject.getPrincipals().isEmpty() && !subject.getPublicCredentials(Credentials.class).isEmpty()) {
// clear subject if not readonly
Modified: jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ACE.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ACE.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ACE.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ACE.java Thu Dec 6 15:55:56 2018
@@ -93,7 +93,7 @@ public abstract class ACE implements Jac
@NotNull
@Override
- public String[] getRestrictionNames() throws RepositoryException {
+ public String[] getRestrictionNames() {
return Collections2.transform(restrictions, new Function<Restriction, String>() {
@Override
public String apply(Restriction restriction) {
@@ -124,7 +124,7 @@ public abstract class ACE implements Jac
@Nullable
@Override
- public Value[] getRestrictions(String restrictionName) throws RepositoryException {
+ public Value[] getRestrictions(String restrictionName) {
for (Restriction restriction : restrictions) {
String jcrName = getJcrName(restriction);
if (jcrName.equals(restrictionName)) {
Modified: jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlList.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlList.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlList.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlList.java Thu Dec 6 15:55:56 2018
@@ -79,7 +79,7 @@ public abstract class AbstractAccessCont
//--------------------------------------------------< AccessControlList >---
@Override
- public AccessControlEntry[] getAccessControlEntries() throws RepositoryException {
+ public AccessControlEntry[] getAccessControlEntries() {
List<? extends JackrabbitAccessControlEntry> entries = getEntries();
return entries.toArray(new JackrabbitAccessControlEntry[entries.size()]);
}
@@ -103,7 +103,7 @@ public abstract class AbstractAccessCont
@NotNull
@Override
- public String[] getRestrictionNames() throws RepositoryException {
+ public String[] getRestrictionNames() {
Collection<RestrictionDefinition> supported = getRestrictionProvider().getSupportedRestrictions(getOakPath());
return Collections2.transform(supported, new Function<RestrictionDefinition, String>() {
@Override
@@ -115,7 +115,7 @@ public abstract class AbstractAccessCont
}
@Override
- public int getRestrictionType(String restrictionName) throws RepositoryException {
+ public int getRestrictionType(String restrictionName) {
for (RestrictionDefinition definition : getRestrictionProvider().getSupportedRestrictions(getOakPath())) {
String jcrName = namePathMapper.getJcrName(definition.getName());
if (jcrName.equals(restrictionName)) {
@@ -128,7 +128,7 @@ public abstract class AbstractAccessCont
}
@Override
- public boolean isMultiValueRestriction(String restrictionName) throws RepositoryException {
+ public boolean isMultiValueRestriction(String restrictionName) {
for (RestrictionDefinition definition : getRestrictionProvider().getSupportedRestrictions(getOakPath())) {
String jcrName = namePathMapper.getJcrName(definition.getName());
if (jcrName.equals(restrictionName)) {
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/CompositeConfigurationTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/CompositeConfigurationTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/CompositeConfigurationTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/CompositeConfigurationTest.java Thu Dec 6 15:55:56 2018
@@ -51,7 +51,7 @@ public class CompositeConfigurationTest
private static final String NAME = "test";
@Before
- public void before() throws Exception {
+ public void before() {
compositeConfiguration = new CompositeConfiguration("test", new SecurityProvider() {
@NotNull
@Override
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/CompositeContextTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/CompositeContextTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/CompositeContextTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/CompositeContextTest.java Thu Dec 6 15:55:56 2018
@@ -37,7 +37,7 @@ import static org.junit.Assert.assertTru
public class CompositeContextTest extends AbstractCompositeConfigurationTest {
@Before
- public void before() throws Exception {
+ public void before() {
compositeConfiguration = new CompositeConfiguration("test", Mockito.mock(SecurityProvider.class)) {};
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/ConfigurationParametersTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/ConfigurationParametersTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/ConfigurationParametersTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/ConfigurationParametersTest.java Thu Dec 6 15:55:56 2018
@@ -209,7 +209,7 @@ public class ConfigurationParametersTest
}
@Test
- public void testCollectionAsArray() throws Exception{
+ public void testCollectionAsArray() {
String[] testArray = {"t"};
ConfigurationParameters options = ConfigurationParameters.of("test", Arrays.asList(testArray));
assertArrayEquals(testArray, options.getConfigValue("test", null, String[].class));
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModuleTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModuleTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModuleTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModuleTest.java Thu Dec 6 15:55:56 2018
@@ -80,14 +80,14 @@ public class AbstractLoginModuleTest {
}
@Test
- public void testLogout() throws LoginException {
+ public void testLogout() {
AbstractLoginModule loginModule = initLoginModule(TestCredentials.class, ImmutableMap.of());
assertFalse(loginModule.logout());
}
@Test
- public void testLogoutSuccess() throws LoginException {
+ public void testLogoutSuccess() {
Subject subject = new Subject(false, ImmutableSet.<Principal>of(new PrincipalImpl("pName")), ImmutableSet.of(new TestCredentials()), ImmutableSet.of());
AbstractLoginModule loginModule = new TestLoginModule(TestCredentials.class);
@@ -100,7 +100,7 @@ public class AbstractLoginModuleTest {
}
@Test
- public void testLogoutSuccess2() throws LoginException {
+ public void testLogoutSuccess2() {
Subject subject = new Subject(true, ImmutableSet.<Principal>of(new PrincipalImpl("pName")), ImmutableSet.of(new TestCredentials()), ImmutableSet.of());
AbstractLoginModule loginModule = new TestLoginModule(TestCredentials.class);
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/GuestLoginModuleTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/GuestLoginModuleTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/GuestLoginModuleTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/GuestLoginModuleTest.java Thu Dec 6 15:55:56 2018
@@ -16,7 +16,6 @@
*/
package org.apache.jackrabbit.oak.spi.security.authentication;
-import java.io.IOException;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
@@ -150,7 +149,7 @@ public class GuestLoginModuleTest {
this.creds = creds;
}
@Override
- public void handle(Callback[] callbacks) throws IOException, UnsupportedCallbackException {
+ public void handle(Callback[] callbacks) throws UnsupportedCallbackException {
for (Callback callback : callbacks) {
if (callback instanceof CredentialsCallback) {
((CredentialsCallback) callback).setCredentials(creds);
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/token/CompositeTokenConfigurationTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/token/CompositeTokenConfigurationTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/token/CompositeTokenConfigurationTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/token/CompositeTokenConfigurationTest.java Thu Dec 6 15:55:56 2018
@@ -34,7 +34,7 @@ import static org.junit.Assert.assertTru
public class CompositeTokenConfigurationTest extends AbstractCompositeConfigurationTest<TokenConfiguration> {
@Before
- public void before() throws Exception {
+ public void before() {
compositeConfiguration = new CompositeTokenConfiguration(createSecurityProvider());
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ACETest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ACETest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ACETest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ACETest.java Thu Dec 6 15:55:56 2018
@@ -73,7 +73,7 @@ public class ACETest extends AbstractAcc
return createEntry(testPrincipal, PrivilegeBits.BUILT_IN.get(PrivilegeConstants.JCR_READ), true, restrictions);
}
- private Restriction createRestriction(String name, String value) throws Exception {
+ private Restriction createRestriction(String name, String value) {
return new RestrictionImpl(PropertyStates.createProperty(name, value), false);
}
@@ -142,7 +142,7 @@ public class ACETest extends AbstractAcc
}
@Test
- public void testNullPrivileges() throws Exception {
+ public void testNullPrivileges() {
try {
new EmptyACE(null);
fail("Privileges must not be null");
@@ -152,7 +152,7 @@ public class ACETest extends AbstractAcc
}
@Test
- public void testEmptyPrivileges() throws Exception {
+ public void testEmptyPrivileges() {
try {
new EmptyACE(PrivilegeBits.EMPTY);
fail("Privileges must not be empty.");
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlListTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlListTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlListTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlListTest.java Thu Dec 6 15:55:56 2018
@@ -126,7 +126,7 @@ public class AbstractAccessControlListTe
}
@Test
- public void testGetNamePathMapper() throws Exception {
+ public void testGetNamePathMapper() {
assertSame(getNamePathMapper(), createEmptyACL().getNamePathMapper());
assertSame(NamePathMapper.DEFAULT, createACL(getTestPath(), ImmutableList.<JackrabbitAccessControlEntry>of(), NamePathMapper.DEFAULT).getNamePathMapper());
}
@@ -185,7 +185,7 @@ public class AbstractAccessControlListTe
}
@Test
- public void testEmptyAcl() throws RepositoryException {
+ public void testEmptyAcl() {
AbstractAccessControlList acl = createEmptyACL();
assertNotNull(acl.getAccessControlEntries());
@@ -224,7 +224,7 @@ public class AbstractAccessControlListTe
}
@Test
- public void testGetRestrictionNames() throws RepositoryException {
+ public void testGetRestrictionNames() {
AbstractAccessControlList acl = createEmptyACL();
String[] restrNames = acl.getRestrictionNames();
@@ -237,7 +237,7 @@ public class AbstractAccessControlListTe
}
@Test
- public void testGetRestrictionType() throws RepositoryException {
+ public void testGetRestrictionType() {
AbstractAccessControlList acl = createEmptyACL();
for (RestrictionDefinition def : getRestrictionProvider().getSupportedRestrictions(getTestPath())) {
int reqType = acl.getRestrictionType(getNamePathMapper().getJcrName(def.getName()));
@@ -248,7 +248,7 @@ public class AbstractAccessControlListTe
}
@Test
- public void testGetRestrictionTypeForUnknownName() throws RepositoryException {
+ public void testGetRestrictionTypeForUnknownName() {
AbstractAccessControlList acl = createEmptyACL();
// for backwards compatibility getRestrictionType(String) must return
// UNDEFINED for a unknown restriction name:
@@ -256,7 +256,7 @@ public class AbstractAccessControlListTe
}
@Test
- public void testIsMultiValueRestriction() throws RepositoryException {
+ public void testIsMultiValueRestriction() {
AbstractAccessControlList acl = createEmptyACL();
for (RestrictionDefinition def : getRestrictionProvider().getSupportedRestrictions(getTestPath())) {
boolean isMv = acl.isMultiValueRestriction(getNamePathMapper().getJcrName(def.getName()));
@@ -266,7 +266,7 @@ public class AbstractAccessControlListTe
}
@Test
- public void testIsMultiValueRestrictionForUnknownName() throws RepositoryException {
+ public void testIsMultiValueRestrictionForUnknownName() {
assertFalse(createEmptyACL().isMultiValueRestriction("unknownRestrictionName"));
}
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlManagerTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlManagerTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlManagerTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/AbstractAccessControlManagerTest.java Thu Dec 6 15:55:56 2018
@@ -161,22 +161,22 @@ public class AbstractAccessControlManage
}
@Test
- public void testGetRoot() throws Exception {
+ public void testGetRoot() {
assertSame(root, createAccessControlManager(root, getNamePathMapper()).getRoot());
}
@Test
- public void testGetLatestRoot() throws Exception {
+ public void testGetLatestRoot() {
assertNotSame(root, createAccessControlManager(root, getNamePathMapper()).getLatestRoot());
}
@Test
- public void testGetNamePathMapper() throws Exception {
+ public void testGetNamePathMapper() {
assertSame(getNamePathMapper(), createAccessControlManager(root, getNamePathMapper()).getNamePathMapper());
}
@Test
- public void testGetPrivilegeManager() throws Exception {
+ public void testGetPrivilegeManager() {
assertSame(privilegeManager, acMgr.getPrivilegeManager());
}
@@ -257,7 +257,7 @@ public class AbstractAccessControlManage
}
@Test
- public void testGetSupportedPrivilegesInvalidPath() throws Exception {
+ public void testGetSupportedPrivilegesInvalidPath() {
for (String path : getInvalidPaths()) {
try {
acMgr.getSupportedPrivileges(path);
@@ -315,7 +315,7 @@ public class AbstractAccessControlManage
}
@Test
- public void testHasPrivilegesInvalidPaths() throws Exception {
+ public void testHasPrivilegesInvalidPaths() {
for (String path : getInvalidPaths()) {
try {
acMgr.hasPrivileges(path, testPrivileges);
@@ -337,7 +337,7 @@ public class AbstractAccessControlManage
}
@Test
- public void testHasPrivilegesInvalidPathsEveryoneSet() throws Exception {
+ public void testHasPrivilegesInvalidPathsEveryoneSet() {
for (String path : getInvalidPaths()) {
try {
acMgr.hasPrivileges(path, ImmutableSet.<Principal>of(EveryonePrincipal.getInstance()), testPrivileges);
@@ -375,7 +375,7 @@ public class AbstractAccessControlManage
}
@Test
- public void testGetPrivilegesInvalidPaths() throws Exception {
+ public void testGetPrivilegesInvalidPaths() {
for (String path : getInvalidPaths()) {
try {
acMgr.getPrivileges(path);
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ImmutableACLTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ImmutableACLTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ImmutableACLTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/ImmutableACLTest.java Thu Dec 6 15:55:56 2018
@@ -50,7 +50,7 @@ public class ImmutableACLTest extends Ab
private Privilege[] testPrivileges;
@Before
- public void before() throws Exception {
+ public void before() {
testPrivileges = privilegesFromNames(PrivilegeConstants.JCR_READ, PrivilegeConstants.JCR_ADD_CHILD_NODES);
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/TestACL.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/TestACL.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/TestACL.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/accesscontrol/TestACL.java Thu Dec 6 15:55:56 2018
@@ -20,10 +20,8 @@ import java.security.Principal;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
-import javax.jcr.RepositoryException;
import javax.jcr.Value;
import javax.jcr.security.AccessControlEntry;
-import javax.jcr.security.AccessControlException;
import javax.jcr.security.Privilege;
import com.google.common.collect.Lists;
@@ -74,7 +72,7 @@ public final class TestACL extends Abstr
}
@Override
- public boolean addEntry(Principal principal, Privilege[] privileges, boolean isAllow, Map<String, Value> restrictions, Map<String, Value[]> mvRestrictions) throws AccessControlException, RepositoryException {
+ public boolean addEntry(Principal principal, Privilege[] privileges, boolean isAllow, Map<String, Value> restrictions, Map<String, Value[]> mvRestrictions) {
throw new UnsupportedOperationException();
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/AbstractRestrictionProviderTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/AbstractRestrictionProviderTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/AbstractRestrictionProviderTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/AbstractRestrictionProviderTest.java Thu Dec 6 15:55:56 2018
@@ -90,7 +90,7 @@ public class AbstractRestrictionProvider
};
}
- private Tree getAceTree(Restriction... restrictions) throws Exception {
+ private Tree getAceTree(Restriction... restrictions) {
Tree restrictionsTree = Mockito.mock(Tree.class);;
when(restrictionsTree.getName()).thenReturn(REP_RESTRICTIONS);
when(restrictionsTree.getProperty(JcrConstants.JCR_PRIMARYTYPE)).thenReturn(PropertyStates.createProperty(JcrConstants.JCR_PRIMARYTYPE, NT_REP_RESTRICTIONS, Type.NAME));
@@ -111,7 +111,7 @@ public class AbstractRestrictionProvider
}
@Test
- public void testGetSupportedRestrictions() throws Exception {
+ public void testGetSupportedRestrictions() {
Set<RestrictionDefinition> defs = restrictionProvider.getSupportedRestrictions(testPath);
assertNotNull(defs);
assertEquals(supported.size(), defs.size());
@@ -121,7 +121,7 @@ public class AbstractRestrictionProvider
}
@Test
- public void testGetSupportedRestrictionsForUnsupportedPath() throws Exception {
+ public void testGetSupportedRestrictionsForUnsupportedPath() {
Set<RestrictionDefinition> defs = restrictionProvider.getSupportedRestrictions(unsupportedPath);
assertNotNull(defs);
assertTrue(defs.isEmpty());
@@ -285,7 +285,7 @@ public class AbstractRestrictionProvider
}
@Test
- public void testReadRestrictionsForUnsupportedPath() throws Exception {
+ public void testReadRestrictionsForUnsupportedPath() {
Set<Restriction> restrictions = restrictionProvider.readRestrictions(unsupportedPath, getAceTree());
assertTrue(restrictions.isEmpty());
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/CompositeRestrictionProviderTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/CompositeRestrictionProviderTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/CompositeRestrictionProviderTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/CompositeRestrictionProviderTest.java Thu Dec 6 15:55:56 2018
@@ -102,7 +102,7 @@ public class CompositeRestrictionProvide
private ValueFactory vf = new ValueFactoryImpl(Mockito.mock(Root.class), NamePathMapper.DEFAULT);
- private Tree getAceTree(Restriction... restrictions) throws Exception {
+ private Tree getAceTree(Restriction... restrictions) {
Tree restrictionsTree = Mockito.mock(Tree.class);;
when(restrictionsTree.getName()).thenReturn(REP_RESTRICTIONS);
when(restrictionsTree.getProperty(JcrConstants.JCR_PRIMARYTYPE)).thenReturn(PropertyStates.createProperty(JcrConstants.JCR_PRIMARYTYPE, NT_REP_RESTRICTIONS, Type.NAME));
@@ -225,7 +225,7 @@ public class CompositeRestrictionProvide
}
@Test
- public void testReadRestrictions() throws Exception {
+ public void testReadRestrictions() {
Tree aceTree = getAceTree(NT_PREFIXES_RESTRICTION, MANDATORY_BOOLEAN_RESTRICTION, UNKNOWN_RESTRICTION);
Set<Restriction> restrictions = provider.readRestrictions("/test", aceTree);
@@ -306,13 +306,13 @@ public class CompositeRestrictionProvide
}
@Test
- public void testGetRestrictionPatternEmptyComposite() throws Exception {
+ public void testGetRestrictionPatternEmptyComposite() {
assertSame(RestrictionPattern.EMPTY, CompositeRestrictionProvider.newInstance().getPattern("/test", ImmutableSet.of(GLOB_RESTRICTION)));
}
@Test
- public void testGetRestrictionPatternSingleEmpty() throws Exception {
+ public void testGetRestrictionPatternSingleEmpty() {
assertSame(RestrictionPattern.EMPTY, CompositeRestrictionProvider.newInstance(new AbstractRestrictionProvider(ImmutableMap.of()) {
@NotNull
@Override
@@ -329,7 +329,7 @@ public class CompositeRestrictionProvide
}
@Test
- public void testGetRestrictionPatternAllEmpty() throws Exception {
+ public void testGetRestrictionPatternAllEmpty() {
assertSame(RestrictionPattern.EMPTY, CompositeRestrictionProvider.newInstance(new AbstractRestrictionProvider(ImmutableMap.of()) {
@NotNull
@Override
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/RestrictionDefinitionImplTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/RestrictionDefinitionImplTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/RestrictionDefinitionImplTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/RestrictionDefinitionImplTest.java Thu Dec 6 15:55:56 2018
@@ -37,7 +37,7 @@ public class RestrictionDefinitionImplTe
private RestrictionDefinitionImpl definition;
@Before
- public void before() throws Exception {
+ public void before() {
name = "test:defName";
definition = new RestrictionDefinitionImpl(name, Type.NAME, true);
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/RestrictionImplTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/RestrictionImplTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/RestrictionImplTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/restriction/RestrictionImplTest.java Thu Dec 6 15:55:56 2018
@@ -44,7 +44,7 @@ public class RestrictionImplTest {
private RestrictionImpl restriction;
@Before
- public void before() throws Exception {
+ public void before() {
PropertyState property = createProperty(name, value, type);
restriction = new RestrictionImpl(property, isMandatory);
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/CompositePrincipalConfigurationTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/CompositePrincipalConfigurationTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/CompositePrincipalConfigurationTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/CompositePrincipalConfigurationTest.java Thu Dec 6 15:55:56 2018
@@ -69,7 +69,7 @@ public class CompositePrincipalConfigura
}
@Test
- public void testEmptyGetProvider() throws Exception {
+ public void testEmptyGetProvider() {
PrincipalProvider pp = getComposite().getPrincipalProvider(root, NamePathMapper.DEFAULT);
assertFalse(pp instanceof CompositePrincipalProvider);
assertSame(EmptyPrincipalProvider.INSTANCE, pp);
@@ -85,7 +85,7 @@ public class CompositePrincipalConfigura
}
@Test
- public void testSingleGetProvider() throws Exception {
+ public void testSingleGetProvider() {
PrincipalConfiguration testConfig = new TestPrincipalConfiguration();
addConfiguration(testConfig);
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/EmptyPrincipalProviderTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/EmptyPrincipalProviderTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/EmptyPrincipalProviderTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/EmptyPrincipalProviderTest.java Thu Dec 6 15:55:56 2018
@@ -45,7 +45,7 @@ public class EmptyPrincipalProviderTest
}
@Test
- public void testGetPrincipals() throws Exception {
+ public void testGetPrincipals() {
assertTrue(principalProvider.getPrincipals("userId").isEmpty());
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/privilege/PrivilegeBitsProviderTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/privilege/PrivilegeBitsProviderTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/privilege/PrivilegeBitsProviderTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/privilege/PrivilegeBitsProviderTest.java Thu Dec 6 15:55:56 2018
@@ -55,7 +55,7 @@ public class PrivilegeBitsProviderTest i
private PrivilegeBitsProvider bitsProvider;
@Before
- public void before() throws Exception {
+ public void before() {
privTree = Mockito.mock(Tree.class);
root = Mockito.mock(Root.class);
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/AuthorizableTypeTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/AuthorizableTypeTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/AuthorizableTypeTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/AuthorizableTypeTest.java Thu Dec 6 15:55:56 2018
@@ -44,26 +44,26 @@ public class AuthorizableTypeTest {
}
@Test
- public void testGetType() throws Exception {
+ public void testGetType() {
assertSame(AuthorizableType.USER, AuthorizableType.getType(UserManager.SEARCH_TYPE_USER));
assertSame(AuthorizableType.GROUP, AuthorizableType.getType(UserManager.SEARCH_TYPE_GROUP));
assertSame(AuthorizableType.AUTHORIZABLE, AuthorizableType.getType(UserManager.SEARCH_TYPE_AUTHORIZABLE));
}
@Test(expected = IllegalArgumentException.class)
- public void testGetTypeIllegalSearchType() throws Exception {
+ public void testGetTypeIllegalSearchType() {
AuthorizableType.getType(0);
}
@Test
- public void testIsTypeUser() throws Exception {
+ public void testIsTypeUser() {
assertFalse(AuthorizableType.USER.isType(null));
assertTrue(AuthorizableType.USER.isType(user));
assertFalse(AuthorizableType.USER.isType(gr));
}
@Test
- public void testIsTypeGroup() throws Exception {
+ public void testIsTypeGroup() {
assertFalse(AuthorizableType.GROUP.isType(null));
assertFalse(AuthorizableType.GROUP.isType(user));
assertTrue(AuthorizableType.GROUP.isType(gr));
@@ -71,7 +71,7 @@ public class AuthorizableTypeTest {
}
@Test
- public void testIsTypeAuthorizable() throws Exception {
+ public void testIsTypeAuthorizable() {
assertFalse(AuthorizableType.AUTHORIZABLE.isType(null));
assertTrue(AuthorizableType.AUTHORIZABLE.isType(user));
assertTrue(AuthorizableType.AUTHORIZABLE.isType(gr));
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/ClearMembershipActionTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/ClearMembershipActionTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/ClearMembershipActionTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/ClearMembershipActionTest.java Thu Dec 6 15:55:56 2018
@@ -21,8 +21,6 @@ import java.util.Collections;
import java.util.HashSet;
import java.util.Iterator;
import java.util.Set;
-import javax.jcr.RepositoryException;
-import javax.jcr.UnsupportedRepositoryOperationException;
import javax.jcr.Value;
import com.google.common.collect.Iterators;
@@ -57,7 +55,7 @@ public class ClearMembershipActionTest {
private final TestGroup gr = new TestGroup();
@Before
- public void before() throws Exception {
+ public void before() {
action.init(securityProvider, ConfigurationParameters.EMPTY);
}
@@ -95,47 +93,47 @@ public class ClearMembershipActionTest {
Set<Authorizable> removed = new HashSet<>();
@Override
- public Iterator<Authorizable> getDeclaredMembers() throws RepositoryException {
+ public Iterator<Authorizable> getDeclaredMembers() {
throw new UnsupportedOperationException();
}
@Override
- public Iterator<Authorizable> getMembers() throws RepositoryException {
+ public Iterator<Authorizable> getMembers() {
throw new UnsupportedOperationException();
}
@Override
- public boolean isDeclaredMember(Authorizable authorizable) throws RepositoryException {
+ public boolean isDeclaredMember(Authorizable authorizable) {
throw new UnsupportedOperationException();
}
@Override
- public boolean isMember(Authorizable authorizable) throws RepositoryException {
+ public boolean isMember(Authorizable authorizable) {
throw new UnsupportedOperationException();
}
@Override
- public boolean addMember(Authorizable authorizable) throws RepositoryException {
+ public boolean addMember(Authorizable authorizable) {
throw new UnsupportedOperationException();
}
@Override
- public Set<String> addMembers(@NotNull String... strings) throws RepositoryException {
+ public Set<String> addMembers(@NotNull String... strings) {
throw new UnsupportedOperationException();
}
@Override
- public boolean removeMember(Authorizable authorizable) throws RepositoryException {
+ public boolean removeMember(Authorizable authorizable) {
return removed.add(authorizable);
}
@Override
- public Set<String> removeMembers(@NotNull String... strings) throws RepositoryException {
+ public Set<String> removeMembers(@NotNull String... strings) {
throw new UnsupportedOperationException();
}
@Override
- public String getID() throws RepositoryException {
+ public String getID() {
throw new UnsupportedOperationException();
}
@@ -145,62 +143,62 @@ public class ClearMembershipActionTest {
}
@Override
- public Principal getPrincipal() throws RepositoryException {
+ public Principal getPrincipal() {
throw new UnsupportedOperationException();
}
@Override
- public Iterator<Group> declaredMemberOf() throws RepositoryException {
+ public Iterator<Group> declaredMemberOf() {
return Collections.emptyIterator();
}
@Override
- public Iterator<Group> memberOf() throws RepositoryException {
+ public Iterator<Group> memberOf() {
throw new UnsupportedOperationException();
}
@Override
- public void remove() throws RepositoryException {
+ public void remove() {
throw new UnsupportedOperationException();
}
@Override
- public Iterator<String> getPropertyNames() throws RepositoryException {
+ public Iterator<String> getPropertyNames() {
throw new UnsupportedOperationException();
}
@Override
- public Iterator<String> getPropertyNames(String s) throws RepositoryException {
+ public Iterator<String> getPropertyNames(String s) {
throw new UnsupportedOperationException();
}
@Override
- public boolean hasProperty(String s) throws RepositoryException {
+ public boolean hasProperty(String s) {
throw new UnsupportedOperationException();
}
@Override
- public void setProperty(String s, Value value) throws RepositoryException {
+ public void setProperty(String s, Value value) {
throw new UnsupportedOperationException();
}
@Override
- public void setProperty(String s, Value[] values) throws RepositoryException {
+ public void setProperty(String s, Value[] values) {
throw new UnsupportedOperationException();
}
@Override
- public Value[] getProperty(String s) throws RepositoryException {
+ public Value[] getProperty(String s) {
throw new UnsupportedOperationException();
}
@Override
- public boolean removeProperty(String s) throws RepositoryException {
+ public boolean removeProperty(String s) {
throw new UnsupportedOperationException();
}
@Override
- public String getPath() throws UnsupportedRepositoryOperationException, RepositoryException {
+ public String getPath() {
throw new UnsupportedOperationException();
}
}
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/PasswordValidationActionTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/PasswordValidationActionTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/PasswordValidationActionTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/PasswordValidationActionTest.java Thu Dec 6 15:55:56 2018
@@ -42,7 +42,7 @@ public class PasswordValidationActionTes
private User user;
@Before
- public void before() throws Exception {
+ public void before() {
user = Mockito.mock(User.class);
pwAction.init(securityProvider, ConfigurationParameters.of(
PasswordValidationAction.CONSTRAINT, "^.*(?=.{8,})(?=.*[a-z])(?=.*[A-Z]).*"));
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/util/PasswordUtilTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/util/PasswordUtilTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/util/PasswordUtilTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/util/PasswordUtilTest.java Thu Dec 6 15:55:56 2018
@@ -133,19 +133,19 @@ public class PasswordUtilTest {
}
@Test
- public void testIsPlainTextPassword() throws Exception {
+ public void testIsPlainTextPassword() {
for (String pw : plainPasswords) {
assertTrue(pw + " should be plain text.", PasswordUtil.isPlainTextPassword(pw));
}
}
@Test
- public void testIsPlainTextForNull() throws Exception {
+ public void testIsPlainTextForNull() {
assertTrue(PasswordUtil.isPlainTextPassword(null));
}
@Test
- public void testIsPlainTextForPwHash() throws Exception {
+ public void testIsPlainTextForPwHash() {
for (String pwHash : hashedPasswords.values()) {
assertFalse(pwHash + " should not be plain text.", PasswordUtil.isPlainTextPassword(pwHash));
}
@@ -173,7 +173,7 @@ public class PasswordUtilTest {
}
@Test
- public void testIsNotSame() throws Exception {
+ public void testIsNotSame() {
String previous = null;
for (String pw : hashedPasswords.keySet()) {
String pwHash = hashedPasswords.get(pw);
Modified: jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/xml/PropInfoTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/xml/PropInfoTest.java?rev=1848335&r1=1848334&r2=1848335&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/xml/PropInfoTest.java (original)
+++ jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/xml/PropInfoTest.java Thu Dec 6 15:55:56 2018
@@ -144,7 +144,7 @@ public class PropInfoTest {
}
@Test
- public void testIsUnknownMultipleEmpty() throws Exception {
+ public void testIsUnknownMultipleEmpty() {
PropInfo propInfo = new PropInfo("longs", PropertyType.LONG, ImmutableList.of());
assertFalse(propInfo.isUnknownMultiple());
}