You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/20 06:06:27 UTC
[GitHub] [pulsar] RocMarshal opened a new pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.
RocMarshal opened a new pull request #14385:
URL: https://github.com/apache/pulsar/pull/14385
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Adjust PulsarAdminException to ParameterException in cli, which is more friendly when displaying error messages.
### Modifications
*pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14385:
URL: https://github.com/apache/pulsar/pull/14385#issuecomment-1046229410
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14385:
URL: https://github.com/apache/pulsar/pull/14385#issuecomment-1048485134
@codelipenghui @yuruguo Glad to do it. Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14385:
URL: https://github.com/apache/pulsar/pull/14385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14385:
URL: https://github.com/apache/pulsar/pull/14385#issuecomment-1051565784
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14385:
URL: https://github.com/apache/pulsar/pull/14385#issuecomment-1050865616
@RocMarshal Please help resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14385:
URL: https://github.com/apache/pulsar/pull/14385#issuecomment-1050441275
@codelipenghui @yuruguo I added the test case for the PR based on your comments.
PTAL,Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14385:
URL: https://github.com/apache/pulsar/pull/14385#issuecomment-1048446391
@RocMarshal The change looks good to me, could you please help add a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org