You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/25 07:40:26 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #7377: druid connector: avoid using 'dimensions' for scan queries

codecov-io commented on issue #7377: druid connector: avoid using 'dimensions' for scan queries
URL: https://github.com/apache/incubator-superset/pull/7377#issuecomment-486555607
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7377?src=pr&el=h1) Report
   > Merging [#7377](https://codecov.io/gh/apache/incubator-superset/pull/7377?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4fe152d1560764527c6d8eca19bc91f344c63e5e?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7377/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7377?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7377      +/-   ##
   ==========================================
   - Coverage   64.89%   64.89%   -0.01%     
   ==========================================
     Files         428      428              
     Lines       20979    20980       +1     
     Branches     2337     2337              
   ==========================================
     Hits        13615    13615              
   - Misses       7240     7241       +1     
     Partials      124      124
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7377?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/7377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.38% <0%> (-0.11%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7377?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7377?src=pr&el=footer). Last update [4fe152d...0f98d48](https://codecov.io/gh/apache/incubator-superset/pull/7377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org