You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Karl Wright (Created) (JIRA)" <ji...@apache.org> on 2012/03/06 18:00:58 UTC

[jira] [Created] (CONNECTORS-421) Test infrastructure's cleanup methods cause agents process to fail to start

Test infrastructure's cleanup methods cause agents process to fail to start
---------------------------------------------------------------------------

                 Key: CONNECTORS-421
                 URL: https://issues.apache.org/jira/browse/CONNECTORS-421
             Project: ManifoldCF
          Issue Type: Bug
          Components: Tests
    Affects Versions: ManifoldCF 0.5
            Reporter: Karl Wright
            Assignee: Karl Wright
            Priority: Minor
             Fix For: ManifoldCF 0.5


The testing infrastructure attempts to clean up from a previous run of a test.  If properties.xml is left around, however, this cleanup will succeed but prevent the agents process from starting in the test.  That's because the addShutdownHook() is called, and when resetEnvironment() is called agentStop() is thus invoked, and once agentStop() is invoked agentStart() will just exit next time it is called.

The fix is to make resetEnvironment() reset the agents stop flag so that starting agents will then work.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-421) Test infrastructure's cleanup methods cause agents process to fail to start

Posted by "Luca Stancapiano (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223441#comment-13223441 ] 

Luca Stancapiano commented on CONNECTORS-421:
---------------------------------------------

we could to move the stopAgentsRun variable from the org.apache.manifoldcf.agents.system.ManifoldCF class to the parent org.apache.manifoldcf.core.system.ManifoldCF class and hereditate it to the child. Let me see
                
> Test infrastructure's cleanup methods cause agents process to fail to start
> ---------------------------------------------------------------------------
>
>                 Key: CONNECTORS-421
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-421
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>            Priority: Minor
>             Fix For: ManifoldCF 0.5
>
>
> The testing infrastructure attempts to clean up from a previous run of a test.  If properties.xml is left around, however, this cleanup will succeed but prevent the agents process from starting in the test.  That's because the addShutdownHook() is called, and when resetEnvironment() is called agentStop() is thus invoked, and once agentStop() is invoked agentStart() will just exit next time it is called.
> The fix is to make resetEnvironment() reset the agents stop flag so that starting agents will then work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CONNECTORS-421) Test infrastructure's cleanup methods cause agents process to fail to start

Posted by "Karl Wright (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Wright resolved CONNECTORS-421.
------------------------------------

    Resolution: Fixed

r1297651

                
> Test infrastructure's cleanup methods cause agents process to fail to start
> ---------------------------------------------------------------------------
>
>                 Key: CONNECTORS-421
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-421
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>            Priority: Minor
>             Fix For: ManifoldCF 0.5
>
>
> The testing infrastructure attempts to clean up from a previous run of a test.  If properties.xml is left around, however, this cleanup will succeed but prevent the agents process from starting in the test.  That's because the addShutdownHook() is called, and when resetEnvironment() is called agentStop() is thus invoked, and once agentStop() is invoked agentStart() will just exit next time it is called.
> The fix is to make resetEnvironment() reset the agents stop flag so that starting agents will then work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-421) Test infrastructure's cleanup methods cause agents process to fail to start

Posted by "Luca Stancapiano (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223447#comment-13223447 ] 

Luca Stancapiano commented on CONNECTORS-421:
---------------------------------------------

If I reset the variable in the resetEnvironment() simply I get a shutdown and the test never start
                
> Test infrastructure's cleanup methods cause agents process to fail to start
> ---------------------------------------------------------------------------
>
>                 Key: CONNECTORS-421
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-421
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>            Priority: Minor
>             Fix For: ManifoldCF 0.5
>
>
> The testing infrastructure attempts to clean up from a previous run of a test.  If properties.xml is left around, however, this cleanup will succeed but prevent the agents process from starting in the test.  That's because the addShutdownHook() is called, and when resetEnvironment() is called agentStop() is thus invoked, and once agentStop() is invoked agentStart() will just exit next time it is called.
> The fix is to make resetEnvironment() reset the agents stop flag so that starting agents will then work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CONNECTORS-421) Test infrastructure's cleanup methods cause agents process to fail to start

Posted by "Luca Stancapiano (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223447#comment-13223447 ] 

Luca Stancapiano edited comment on CONNECTORS-421 at 3/6/12 5:31 PM:
---------------------------------------------------------------------

If I reset the variable in the resetEnvironment() simply I get a shutdown and the test never starts
                
      was (Author: luca.stancaqpiano):
    If I reset the variable in the resetEnvironment() simply I get a shutdown and the test never start
                  
> Test infrastructure's cleanup methods cause agents process to fail to start
> ---------------------------------------------------------------------------
>
>                 Key: CONNECTORS-421
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-421
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>            Priority: Minor
>             Fix For: ManifoldCF 0.5
>
>
> The testing infrastructure attempts to clean up from a previous run of a test.  If properties.xml is left around, however, this cleanup will succeed but prevent the agents process from starting in the test.  That's because the addShutdownHook() is called, and when resetEnvironment() is called agentStop() is thus invoked, and once agentStop() is invoked agentStart() will just exit next time it is called.
> The fix is to make resetEnvironment() reset the agents stop flag so that starting agents will then work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira