You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/23 01:24:20 UTC

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #5878: Add t3c manpages

rob05c commented on a change in pull request #5878:
URL: https://github.com/apache/trafficcontrol/pull/5878#discussion_r637471117



##########
File path: infrastructure/cdn-in-a-box/Makefile
##########
@@ -180,7 +180,7 @@ $(TS_DIST_RPM): $(TS_SOURCE)
 	"$(PKG_COMMAND)" $(PKG_FLAGS) traffic_stats$(BUILD_SUFFIX)
 
 $(ORT_DIST_RPM): $(ORT_SOURCE)
-	"$(PKG_COMMAND)" $(PKG_FLAGS) cache-config$(BUILD_SUFFIX)
+	"$(PKG_COMMAND)" -b $(PKG_FLAGS) cache-config$(BUILD_SUFFIX)

Review comment:
       I made those changes to make the Github checks pass. The build was failing because the Docker Hub images don't have the Dockerfile changes in this PR: https://github.com/apache/trafficcontrol/pull/5878/files#diff-bbc5344acb7207878d9fba88a12ae8a6149729c41b66a7e62377453133f1a208R46
   
   Is there a procedure for getting Github checks to pass when a Dockerfile needs updating?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org