You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/08 07:30:11 UTC
[GitHub] [spark] HeartSaVioR commented on a change in pull request #29970: [SPARK-33087][SQL] DataFrameWriterV2 should delegate table resolution to the analyzer
HeartSaVioR commented on a change in pull request #29970:
URL: https://github.com/apache/spark/pull/29970#discussion_r501500545
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -858,6 +858,16 @@ class Analyzer(
lookupTempView(ident)
.map(view => i.copy(table = view))
.getOrElse(i)
+ case write: V2WriteCommand =>
+ write.table match {
+ case UnresolvedRelation(ident, _, false) =>
+ lookupTempView(ident).map(EliminateSubqueryAliases(_)).map {
+ case r: DataSourceV2Relation => write.withNewTable(r)
Review comment:
Probably we can leave TODO to handle streaming writer case later, with mentioning SPARK-27484.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1010,6 +1031,23 @@ class Analyzer(
case other => i.copy(table = other)
}
+ case write: V2WriteCommand =>
+ write.table match {
+ case u: UnresolvedRelation if !u.isStreaming =>
Review comment:
ditto
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -933,6 +943,17 @@ class Analyzer(
.map(v2Relation => i.copy(table = v2Relation))
.getOrElse(i)
+ case write: V2WriteCommand =>
+ write.table match {
+ case u: UnresolvedRelation if !u.isStreaming =>
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org