You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by yi...@apache.org on 2016/11/16 10:20:50 UTC
git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on
Effects, so order is changed.
Repository: flex-asjs
Updated Branches:
refs/heads/develop 0491e484a -> 23740bcee
HTML now depends on Effects, so order is changed.
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/23740bce
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/23740bce
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/23740bce
Branch: refs/heads/develop
Commit: 23740bceecef86fddba25a6d7d10f5999e561100
Parents: 0491e48
Author: yishayw <yi...@hotmail.com>
Authored: Wed Nov 16 12:20:40 2016 +0200
Committer: yishayw <yi...@hotmail.com>
Committed: Wed Nov 16 12:20:40 2016 +0200
----------------------------------------------------------------------
frameworks/build.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/23740bce/frameworks/build.xml
----------------------------------------------------------------------
diff --git a/frameworks/build.xml b/frameworks/build.xml
index 40a3bf3..e5662a1 100644
--- a/frameworks/build.xml
+++ b/frameworks/build.xml
@@ -81,11 +81,11 @@
<antcall target="Graphics"/>
<antcall target="Binding"/>
<antcall target="Collections"/>
+ <antcall target="Effects"/>
<antcall target="HTML"/>
<antcall target="Flat"/>
<antcall target="Charts"/>
<antcall target="DragDrop"/>
- <antcall target="Effects"/>
<antcall target="Formatters"/>
<antcall target="GoogleMaps"/>
<antcall target="CreateJS"/>
Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends
on Effects, so order is changed.
Posted by Alex Harui <ah...@adobe.com>.
On 11/16/16, 10:23 AM, "Yishay Weiss" <yi...@hotmail.com> wrote:
>Basically, it comes down to whether HTML dependes on Effects or the other
>way around. I guess I can reverse it, but that would mean Effects will
>have a new dependency. I’ll try not to mess up Jenkins’ build this time.
Ah, I thought Effects already had dependencies on HTML. What is the exact
dependency? Should there instead be some new interface in Core?
The main components should not depend on stuff in other SWCs. It seems
more ok for beads/plugins/add-ons to have dependencies on their host.
Really, parents/hosts should not make presumptions about children/beads
etc. It breaks deferred/lazy instantiation. The parent/host cannot be in
the main module and load children/beads later if there is a dependency on
those children/beads.
So, consider having dependencies on an Interface instead of a Class. But
it is better for Effects to depend on HTML than the other way around.
-Alex
RE: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends
on Effects, so order is changed.
Posted by Yishay Weiss <yi...@hotmail.com>.
Basically, it comes down to whether HTML dependes on Effects or the other way around. I guess I can reverse it, but that would mean Effects will have a new dependency. I’ll try not to mess up Jenkins’ build this time.
From: Alex Harui<ma...@adobe.com>
Sent: Wednesday, November 16, 2016 8:13 PM
To: dev@flex.apache.org<ma...@flex.apache.org>
Subject: Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on Effects, so order is changed.
On 11/16/16, 9:46 AM, "Yishay Weiss" <yi...@hotmail.com> wrote:
>I agree, and don’t mind reversing that. The question is where would that
>bead exist. The only dependency one Effects in HTML now, is in the form
>of an optional bead that depends on HTML and Effects, namely
>EasyAccordionCollapseBead. Where do you propose to put it?
IMO, EasyAccordionCollapseBead should be renamed to
EasingAccordionCollapseBead, and be in the Effects.swc if it relies on
classes in Effects.swc.
-Alex
Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends
on Effects, so order is changed.
Posted by Alex Harui <ah...@adobe.com>.
On 11/16/16, 9:46 AM, "Yishay Weiss" <yi...@hotmail.com> wrote:
>I agree, and don’t mind reversing that. The question is where would that
>bead exist. The only dependency one Effects in HTML now, is in the form
>of an optional bead that depends on HTML and Effects, namely
>EasyAccordionCollapseBead. Where do you propose to put it?
IMO, EasyAccordionCollapseBead should be renamed to
EasingAccordionCollapseBead, and be in the Effects.swc if it relies on
classes in Effects.swc.
-Alex
RE: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends
on Effects, so order is changed.
Posted by Yishay Weiss <yi...@hotmail.com>.
I agree, and don’t mind reversing that. The question is where would that bead exist. The only dependency one Effects in HTML now, is in the form of an optional bead that depends on HTML and Effects, namely EasyAccordionCollapseBead. Where do you propose to put it?
From: Alex Harui<ma...@adobe.com>
Sent: Wednesday, November 16, 2016 6:00 PM
To: dev@flex.apache.org<ma...@flex.apache.org>; commits@flex.apache.org<ma...@flex.apache.org>
Subject: Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on Effects, so order is changed.
Hi Yishay,
Why should HTML components be dependent on Effects? IMO, basic components
should not presume the existence of any effects/animation subsystem. In
theory, HTML components might dispatch events that beads can watch and run
effects if requested.
-Alex
On 11/16/16, 2:20 AM, "yishayw@apache.org" <yi...@apache.org> wrote:
>Repository: flex-asjs
>Updated Branches:
> refs/heads/develop 0491e484a -> 23740bcee
>
>
>HTML now depends on Effects, so order is changed.
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/23740bce
>Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/23740bce
>Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/23740bce
>
>Branch: refs/heads/develop
>Commit: 23740bceecef86fddba25a6d7d10f5999e561100
>Parents: 0491e48
>Author: yishayw <yi...@hotmail.com>
>Authored: Wed Nov 16 12:20:40 2016 +0200
>Committer: yishayw <yi...@hotmail.com>
>Committed: Wed Nov 16 12:20:40 2016 +0200
>
>----------------------------------------------------------------------
> frameworks/build.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/23740bce/frameworks/
>build.xml
>----------------------------------------------------------------------
>diff --git a/frameworks/build.xml b/frameworks/build.xml
>index 40a3bf3..e5662a1 100644
>--- a/frameworks/build.xml
>+++ b/frameworks/build.xml
>@@ -81,11 +81,11 @@
> <antcall target="Graphics"/>
> <antcall target="Binding"/>
> <antcall target="Collections"/>
>+ <antcall target="Effects"/>
> <antcall target="HTML"/>
> <antcall target="Flat"/>
> <antcall target="Charts"/>
> <antcall target="DragDrop"/>
>- <antcall target="Effects"/>
> <antcall target="Formatters"/>
> <antcall target="GoogleMaps"/>
> <antcall target="CreateJS"/>
>
Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends
on Effects, so order is changed.
Posted by Alex Harui <ah...@adobe.com>.
Hi Yishay,
Why should HTML components be dependent on Effects? IMO, basic components
should not presume the existence of any effects/animation subsystem. In
theory, HTML components might dispatch events that beads can watch and run
effects if requested.
-Alex
On 11/16/16, 2:20 AM, "yishayw@apache.org" <yi...@apache.org> wrote:
>Repository: flex-asjs
>Updated Branches:
> refs/heads/develop 0491e484a -> 23740bcee
>
>
>HTML now depends on Effects, so order is changed.
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/23740bce
>Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/23740bce
>Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/23740bce
>
>Branch: refs/heads/develop
>Commit: 23740bceecef86fddba25a6d7d10f5999e561100
>Parents: 0491e48
>Author: yishayw <yi...@hotmail.com>
>Authored: Wed Nov 16 12:20:40 2016 +0200
>Committer: yishayw <yi...@hotmail.com>
>Committed: Wed Nov 16 12:20:40 2016 +0200
>
>----------------------------------------------------------------------
> frameworks/build.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/23740bce/frameworks/
>build.xml
>----------------------------------------------------------------------
>diff --git a/frameworks/build.xml b/frameworks/build.xml
>index 40a3bf3..e5662a1 100644
>--- a/frameworks/build.xml
>+++ b/frameworks/build.xml
>@@ -81,11 +81,11 @@
> <antcall target="Graphics"/>
> <antcall target="Binding"/>
> <antcall target="Collections"/>
>+ <antcall target="Effects"/>
> <antcall target="HTML"/>
> <antcall target="Flat"/>
> <antcall target="Charts"/>
> <antcall target="DragDrop"/>
>- <antcall target="Effects"/>
> <antcall target="Formatters"/>
> <antcall target="GoogleMaps"/>
> <antcall target="CreateJS"/>
>
Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends
on Effects, so order is changed.
Posted by Alex Harui <ah...@adobe.com>.
Hi Yishay,
Why should HTML components be dependent on Effects? IMO, basic components
should not presume the existence of any effects/animation subsystem. In
theory, HTML components might dispatch events that beads can watch and run
effects if requested.
-Alex
On 11/16/16, 2:20 AM, "yishayw@apache.org" <yi...@apache.org> wrote:
>Repository: flex-asjs
>Updated Branches:
> refs/heads/develop 0491e484a -> 23740bcee
>
>
>HTML now depends on Effects, so order is changed.
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/23740bce
>Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/23740bce
>Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/23740bce
>
>Branch: refs/heads/develop
>Commit: 23740bceecef86fddba25a6d7d10f5999e561100
>Parents: 0491e48
>Author: yishayw <yi...@hotmail.com>
>Authored: Wed Nov 16 12:20:40 2016 +0200
>Committer: yishayw <yi...@hotmail.com>
>Committed: Wed Nov 16 12:20:40 2016 +0200
>
>----------------------------------------------------------------------
> frameworks/build.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/23740bce/frameworks/
>build.xml
>----------------------------------------------------------------------
>diff --git a/frameworks/build.xml b/frameworks/build.xml
>index 40a3bf3..e5662a1 100644
>--- a/frameworks/build.xml
>+++ b/frameworks/build.xml
>@@ -81,11 +81,11 @@
> <antcall target="Graphics"/>
> <antcall target="Binding"/>
> <antcall target="Collections"/>
>+ <antcall target="Effects"/>
> <antcall target="HTML"/>
> <antcall target="Flat"/>
> <antcall target="Charts"/>
> <antcall target="DragDrop"/>
>- <antcall target="Effects"/>
> <antcall target="Formatters"/>
> <antcall target="GoogleMaps"/>
> <antcall target="CreateJS"/>
>