You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by do...@apache.org on 2013/01/07 22:17:21 UTC

svn commit: r1430017 - in /buildr/trunk: CHANGELOG addon/buildr/findbugs.rb

Author: donaldp
Date: Mon Jan  7 21:17:20 2013
New Revision: 1430017

URL: http://svn.apache.org/viewvc?rev=1430017&view=rev
Log:
Findbugs addon correctly handles String dependencies (vs task dependencies)

Modified:
    buildr/trunk/CHANGELOG
    buildr/trunk/addon/buildr/findbugs.rb

Modified: buildr/trunk/CHANGELOG
URL: http://svn.apache.org/viewvc/buildr/trunk/CHANGELOG?rev=1430017&r1=1430016&r2=1430017&view=diff
==============================================================================
--- buildr/trunk/CHANGELOG (original)
+++ buildr/trunk/CHANGELOG Mon Jan  7 21:17:20 2013
@@ -1,4 +1,6 @@
 1.4.10 (Pending)
+* Fixed:  Findbugs addon correctly handles String dependencies
+          (vs task dependencies)
 * Fixed:  Checkstyle addon correctly handles String dependencies
           (vs task dependencies)
 * Added:  Created an addon 'buildr/wsgen' for generating wsdls from java

Modified: buildr/trunk/addon/buildr/findbugs.rb
URL: http://svn.apache.org/viewvc/buildr/trunk/addon/buildr/findbugs.rb?rev=1430017&r1=1430016&r2=1430017&view=diff
==============================================================================
--- buildr/trunk/addon/buildr/findbugs.rb (original)
+++ buildr/trunk/addon/buildr/findbugs.rb Mon Jan  7 21:17:20 2013
@@ -46,7 +46,7 @@ module Buildr
 
       def findbugs(output_file, source_paths, analyze_paths, options = { })
         dependencies = (options[:dependencies] || []) + self.dependencies
-        cp = Buildr.artifacts(dependencies).each(&:invoke).map(&:to_s).join(File::PATH_SEPARATOR)
+        cp = Buildr.artifacts(dependencies).each { |a| a.invoke() if a.respond_to?(:invoke) }.map(&:to_s).join(File::PATH_SEPARATOR)
 
         args = {
             :output => "xml:withMessages",
@@ -79,7 +79,7 @@ module Buildr
             end
             if options[:extra_dependencies]
               ant.auxClasspath do |aux|
-                Buildr.artifacts(options[:extra_dependencies]).each(&:invoke).each do |dep|
+                Buildr.artifacts(options[:extra_dependencies]).each { |a| a.invoke() if a.respond_to?(:invoke) }.each do |dep|
                   aux.pathelement :location => dep.to_s
                 end
               end