[GitHub] thrift pull request: Stopped adding period before enum name unless...

[mreve <gi...@git.apache.org>]

GitHub user mreve opened a pull request:

    https://github.com/apache/thrift/pull/490

    Stopped adding period before enum name unless namespace is provided

    Using the example from issue's description:
    
    IDL file contains:
    ```
    struct Params {
        1: optional Color bColor = Color.BLACK; 
    }
    ```
    Compiled to java (no namespace):
    ```
    public Params() {
        this.bColor = .Color.BLACK;
    }
    ```
    How it looks like with namespace `enumtest`:
    ```
    public Params() {
        this.bColor = enumtest.Color.BLACK;
    }
    ```
    
    This fix prevents adding the period sign when there's no java namespacec provided in the IDL file.
    
    Compare:
    https://issues.apache.org/jira/browse/THRIFT-3089

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mreve/thrift THRIFT-3089

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/490.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #490
    
----
commit ea51c05a5a2ad5b983089a1efb838a1a57e68fea
Author: Anna Dymek <aa...@gmail.com>
Date:   2015-05-12T19:54:20Z

    Stopped adding period before enum name unless namespace is provided

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT 3089 - stop adding period before enum ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/490


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---