You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/30 05:47:59 UTC
[GitHub] [apisix-dashboard] tokers opened a new issue #1154: Resource create request should return the ultimate data
tokers opened a new issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154
# Feature request
## Please describe your feature
When create resources like Route without specifying id, the ultimate data should be returned, otherwise people cannot reference the just created resource by id.
## Describe the solution you'd like
Output the data in the response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey closed issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey closed issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-761802990
> > we also need to fix that for HTTP PUT methods
>
> This is needed.
@juzhiyuan yep, I will commit an PR for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-753740569
Agree with it.
IMO, we need to keep the same response as apisix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
Hi all, since both #1277 and #1322 had been merged, I would close this issue. Please feel free to reopen it if anything unexpected. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
@tokers @juzhiyuan since both #1277 and #1322 had been merged, I would close this issue. Please feel free to reopen it if anything unexpected. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-758719587
@tokers @starsz @membphis Users could create a resource via `POST` or `PUT` methods. No way to refer the new object only occurs at `POST` method. Shall we also return the ultimate data when using `PUT` method? FYI, the answer is yes for APISIX, need to make manager-api the same as Admin API?
Looking forward to your insights. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-761729212
> we also need to fix that for HTTP PUT methods
This is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
@tokers @juzhiyuan since both #1277 and #1322 had been merged, I could close this issue. Please feel free to reopen it if anything unexpected. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-759259060
> > Shall we also return the ultimate data when using PUT method? FYI, the answer is yes for APISIX, need to make manager-api the same as Admin API?
>
> the Admin API and Manager API should work in the same way.
> So I think the answer is yes, they should return the final data at the same time, whether it is PUT or POST method.
@membphis copy. Thanks for the directions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
@tokers @juzhiyuan since both #1277 and #1322 had been merged, I could close this issue. Please feel free to reopen it if anything unexpected. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-758719587
@tokers @starsz @membphis @juzhiyuan Users could create a resource via `POST` or `PUT` methods. No way to refer the new object only occurs at `POST` method. Shall we also return the ultimate data when using `PUT` method? FYI, the answer is yes for APISIX, need to make manager-api the same as Admin API?
Looking forward to your insights and will help me complete PR #1277 . Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey closed issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
imjoey closed issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-757925352
agree with this too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1154: Resource create request should return the ultimate data
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-759254816
> Shall we also return the ultimate data when using PUT method? FYI, the answer is yes for APISIX, need to make manager-api the same as Admin API?
the Admin API and Manager API should work in the same way.
So I think the answer is yes, they should return the final data at the same time, whether it is PUT or POST method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org