You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Amir Akhmedov <am...@gmail.com> on 2018/05/08 02:54:09 UTC

Re: IGNITE-3999 review

Hi Nikolay, Dmitry Pavlov,
Can you take a look at this PR or maybe you have an idea when it probably
can be reviewed?

Thanks,
Amir

On Wed, Apr 11, 2018 at 10:57 AM, Nikolay Izhikov <ni...@apache.org>
wrote:

> Hello, Amir.
>
> Sorry, but no.
>
> I will take a look in a next few days.
>
>
> В Ср, 11/04/2018 в 14:51 +0000, Amir Akhmedov пишет:
> > Hi Nikolay,
> >
> > Did you have a chance to check my changes?
> >
> > Thanks,
> > Amir
>

Re: IGNITE-3999 review

Posted by Dmitry Pavlov <dp...@gmail.com>.

Hi Amir,

I've updated How To Contribute (
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute )
section 'beginning work':

(OPTIONAL) It is recommended to clarify the relevance and correctness of
the ticket in the community before doing actual implementation. To do this,
you can write a letter to the dev.list <de...@ignite.apache.org> and wait
for answer.

This article has one note in 'tickets' section related to dev list:
"... unassigned
and unscheduled tickets after discussion on project's dev list. " ,- but it
is not so obivious that it is good practice.

I've used optional because some of contributors can be quite sure ticket is
actual, so I think it is not required to mandate everyone to start
discussion.

Sincerely,
Dmitriy Pavlov

вт, 8 мая 2018 г. в 19:43, Amir Akhmedov <am...@gmail.com>:

> Hi All,
> It's definitely my bad, I had to synch up with community on ticket's
> relevance.
> Would be nice for future contributors to mention "do get updates on
> ticket's relevance for outdated tickets" in Ignite's "How to contribute"
> webpage.
>
> Thanks,
> Amir
>
> On Tue, May 8, 2018 at 8:39 AM, Dmitriy Setrakyan <ds...@apache.org>
> wrote:
>
> > Igniters, let's make sure we add ticket description to the email subject
> in
> > future, so the community will know what the ticket is about. Not everyone
> > has time to look for the ticket, especially when the link is not even
> > provided in the email.
> >
> > For example, the subject of this thread should have been: "IGNITE-3999:
> > Support case insensitive search in SQL"
> >
> > D.
> >
> > On Tue, May 8, 2018 at 2:28 PM, Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> >
> > > Hi Vladimir, thank you for stepping in.
> > >
> > > This case confirms the usefulness of the practice of discussing the
> > problem
> > > at the devlist before implementation.
> > >
> > > вт, 8 мая 2018 г. в 10:12, Vladimir Ozerov <vo...@gridgain.com>:
> > >
> > > > Hi,
> > > >
> > > > I provided my comments in the ticket.
> > > >
> > > > On Tue, May 8, 2018 at 5:54 AM, Amir Akhmedov <
> amir.akhmedov@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hi Nikolay, Dmitry Pavlov,
> > > > > Can you take a look at this PR or maybe you have an idea when it
> > > probably
> > > > > can be reviewed?
> > > > >
> > > > > Thanks,
> > > > > Amir
> > > > >
> > > > > On Wed, Apr 11, 2018 at 10:57 AM, Nikolay Izhikov <
> > nizhikov@apache.org
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hello, Amir.
> > > > > >
> > > > > > Sorry, but no.
> > > > > >
> > > > > > I will take a look in a next few days.
> > > > > >
> > > > > >
> > > > > > В Ср, 11/04/2018 в 14:51 +0000, Amir Akhmedov пишет:
> > > > > > > Hi Nikolay,
> > > > > > >
> > > > > > > Did you have a chance to check my changes?
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Amir
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-3999 review

Posted by Amir Akhmedov <am...@gmail.com>.

Hi All,
It's definitely my bad, I had to synch up with community on ticket's
relevance.
Would be nice for future contributors to mention "do get updates on
ticket's relevance for outdated tickets" in Ignite's "How to contribute"
webpage.

Thanks,
Amir

On Tue, May 8, 2018 at 8:39 AM, Dmitriy Setrakyan <ds...@apache.org>
wrote:

> Igniters, let's make sure we add ticket description to the email subject in
> future, so the community will know what the ticket is about. Not everyone
> has time to look for the ticket, especially when the link is not even
> provided in the email.
>
> For example, the subject of this thread should have been: "IGNITE-3999:
> Support case insensitive search in SQL"
>
> D.
>
> On Tue, May 8, 2018 at 2:28 PM, Dmitry Pavlov <dp...@gmail.com>
> wrote:
>
> > Hi Vladimir, thank you for stepping in.
> >
> > This case confirms the usefulness of the practice of discussing the
> problem
> > at the devlist before implementation.
> >
> > вт, 8 мая 2018 г. в 10:12, Vladimir Ozerov <vo...@gridgain.com>:
> >
> > > Hi,
> > >
> > > I provided my comments in the ticket.
> > >
> > > On Tue, May 8, 2018 at 5:54 AM, Amir Akhmedov <amir.akhmedov@gmail.com
> >
> > > wrote:
> > >
> > > > Hi Nikolay, Dmitry Pavlov,
> > > > Can you take a look at this PR or maybe you have an idea when it
> > probably
> > > > can be reviewed?
> > > >
> > > > Thanks,
> > > > Amir
> > > >
> > > > On Wed, Apr 11, 2018 at 10:57 AM, Nikolay Izhikov <
> nizhikov@apache.org
> > >
> > > > wrote:
> > > >
> > > > > Hello, Amir.
> > > > >
> > > > > Sorry, but no.
> > > > >
> > > > > I will take a look in a next few days.
> > > > >
> > > > >
> > > > > В Ср, 11/04/2018 в 14:51 +0000, Amir Akhmedov пишет:
> > > > > > Hi Nikolay,
> > > > > >
> > > > > > Did you have a chance to check my changes?
> > > > > >
> > > > > > Thanks,
> > > > > > Amir
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-3999 review

Posted by Dmitriy Setrakyan <ds...@apache.org>.

Igniters, let's make sure we add ticket description to the email subject in
future, so the community will know what the ticket is about. Not everyone
has time to look for the ticket, especially when the link is not even
provided in the email.

For example, the subject of this thread should have been: "IGNITE-3999:
Support case insensitive search in SQL"

D.

On Tue, May 8, 2018 at 2:28 PM, Dmitry Pavlov <dp...@gmail.com> wrote:

> Hi Vladimir, thank you for stepping in.
>
> This case confirms the usefulness of the practice of discussing the problem
> at the devlist before implementation.
>
> вт, 8 мая 2018 г. в 10:12, Vladimir Ozerov <vo...@gridgain.com>:
>
> > Hi,
> >
> > I provided my comments in the ticket.
> >
> > On Tue, May 8, 2018 at 5:54 AM, Amir Akhmedov <am...@gmail.com>
> > wrote:
> >
> > > Hi Nikolay, Dmitry Pavlov,
> > > Can you take a look at this PR or maybe you have an idea when it
> probably
> > > can be reviewed?
> > >
> > > Thanks,
> > > Amir
> > >
> > > On Wed, Apr 11, 2018 at 10:57 AM, Nikolay Izhikov <nizhikov@apache.org
> >
> > > wrote:
> > >
> > > > Hello, Amir.
> > > >
> > > > Sorry, but no.
> > > >
> > > > I will take a look in a next few days.
> > > >
> > > >
> > > > В Ср, 11/04/2018 в 14:51 +0000, Amir Akhmedov пишет:
> > > > > Hi Nikolay,
> > > > >
> > > > > Did you have a chance to check my changes?
> > > > >
> > > > > Thanks,
> > > > > Amir
> > > >
> > >
> >
>

Re: IGNITE-3999 review

Posted by Dmitry Pavlov <dp...@gmail.com>.

Hi Vladimir, thank you for stepping in.

This case confirms the usefulness of the practice of discussing the problem
at the devlist before implementation.

вт, 8 мая 2018 г. в 10:12, Vladimir Ozerov <vo...@gridgain.com>:

> Hi,
>
> I provided my comments in the ticket.
>
> On Tue, May 8, 2018 at 5:54 AM, Amir Akhmedov <am...@gmail.com>
> wrote:
>
> > Hi Nikolay, Dmitry Pavlov,
> > Can you take a look at this PR or maybe you have an idea when it probably
> > can be reviewed?
> >
> > Thanks,
> > Amir
> >
> > On Wed, Apr 11, 2018 at 10:57 AM, Nikolay Izhikov <ni...@apache.org>
> > wrote:
> >
> > > Hello, Amir.
> > >
> > > Sorry, but no.
> > >
> > > I will take a look in a next few days.
> > >
> > >
> > > В Ср, 11/04/2018 в 14:51 +0000, Amir Akhmedov пишет:
> > > > Hi Nikolay,
> > > >
> > > > Did you have a chance to check my changes?
> > > >
> > > > Thanks,
> > > > Amir
> > >
> >
>

Re: IGNITE-3999 review

Posted by Vladimir Ozerov <vo...@gridgain.com>.

Hi,

I provided my comments in the ticket.

On Tue, May 8, 2018 at 5:54 AM, Amir Akhmedov <am...@gmail.com>
wrote:

> Hi Nikolay, Dmitry Pavlov,
> Can you take a look at this PR or maybe you have an idea when it probably
> can be reviewed?
>
> Thanks,
> Amir
>
> On Wed, Apr 11, 2018 at 10:57 AM, Nikolay Izhikov <ni...@apache.org>
> wrote:
>
> > Hello, Amir.
> >
> > Sorry, but no.
> >
> > I will take a look in a next few days.
> >
> >
> > В Ср, 11/04/2018 в 14:51 +0000, Amir Akhmedov пишет:
> > > Hi Nikolay,
> > >
> > > Did you have a chance to check my changes?
> > >
> > > Thanks,
> > > Amir
> >
>