[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime

["Jon Haddad (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891568#comment-15891568 ] 

Jon Haddad commented on CASSANDRA-12661:
----------------------------------------

Was this merged by someone else?  I tried to take a look at this but git errored out saying it's already been applied:

{code}
(cassandra) jhaddad@rustyrazorblade ~/dev/cassandra$ git am -3 12661.patch 
Applying: CASSANDRA-12661 gc_log and gc_warn runtime setabble and minor cleanup
Using index info to reconstruct a base tree...
M	conf/cassandra.yaml
M	src/java/org/apache/cassandra/config/Config.java
M	src/java/org/apache/cassandra/service/GCInspector.java
M	src/java/org/apache/cassandra/service/GCInspectorMXBean.java
.git/rebase-apply/patch:96: trailing whitespace.

.git/rebase-apply/patch:111: trailing whitespace.
        catch (RuntimeException | InstanceAlreadyExistsException | MBeanRegistrationException |
.git/rebase-apply/patch:126: trailing whitespace.

.git/rebase-apply/patch:151: trailing whitespace.
            throw new IllegalArgumentException("Threashold must be greater than gcLogTreasholdInMs which is currently "
.git/rebase-apply/patch:168: trailing whitespace.
            throw new IllegalArgumentException("Threashold must be less than gcWarnTreasholdInMs which is currently "
warning: squelched 11 whitespace errors
warning: 16 lines add whitespace errors.
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
{code}

> Make gc_log and gc_warn settable at runtime
> -------------------------------------------
>
>                 Key: CASSANDRA-12661
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)