[GitHub] [trafficserver] bneradt commented on issue #8542: Performance Tuning documentation page missing

[GitBox <gi...@apache.org>]

bneradt commented on issue #8542:
URL: https://github.com/apache/trafficserver/issues/8542#issuecomment-985066692


   Thanks for pointing this out Dave!
   
   There's two unrelated things mentioned in this thread:
   
   Should this https://docs.trafficserver.apache.org/records.config
   > <https://urldefense.proofpoint.com/v2/url?u=https-3A__docs.trafficserver.apache.org_records.config&d=DwMCaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=QqpSWgNGj0TQqWr3_U9U8a-TyrKRt3NR6Cr-LMDTUZE&m=BTSkUOqzmvd6nfkF3JY2ba0Z20zvKL2lHcON3iUvylg&s=jF8Wrl9rzw8O0_mkRTGzgt6oZvvBiEWw7geFXXuXIjU&e=>
   >  page even exist? I was expecting something with a documentation version
   > in the path:
   >
   This understandably looks strangely short, but this is fine. As Evan
   pointed out, this is an intentionally configured shortcut that allows easy
   linking to records.config documentation. The shortcut is in place because
   it is frequently accessed.
   
   They all say "See Timeout Settings for more discussion on Traffic Server
   > timeouts." but if you click on the link you get 404.
   >
   
   This, on the other hand, is definitely not fine and it's a problem. In this
   case that you point out, they are generated via
   :ref:`admin-performance-timeouts` references in various places in our
   records.config.en.rst code here:
   https://github.com/apache/trafficserver/blame/master/doc/admin-guide/files/records.config.en.rst#L469
   
   That label is defined here:
   https://github.com/apache/trafficserver/blame/master/doc/admin-guide/performance/index.en.rst#L212
   
   
   Here's another, different link to a different label that is broken:
   https://docs.trafficserver.apache.org/records.config#overridable
   
   Following the " Configuration Remap Plugin" link also results in a 404.
   
   Are all our internal links to labels broken? I'll look into this.
   
   On Wed, Dec 1, 2021 at 2:01 PM Evan Zelkowitz ***@***.***>
   wrote:
   
   > This came up during the CI rework. There are a handful of placeholders
   > like that because some people, mainly @zwoop
   > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_zwoop&d=DwMCaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=QqpSWgNGj0TQqWr3_U9U8a-TyrKRt3NR6Cr-LMDTUZE&m=NanTA10xQwpqW8FjXP8AQQ45tD1JmUdI67pcCrgUoGQ&s=EKNC1UB6AXSOyPYv6J2EhWJYqP3qgEGrfAIN3uyuH1E&e=>
   > :), liked having those shorthand shortcuts to specific files. So we have
   > specific remaps for specific files like that
   >
   > We did have to fix them once already but maybe we are still missing some
   > for them
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_trafficserver_issues_8542-23issuecomment-2D984008027&d=DwMCaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=QqpSWgNGj0TQqWr3_U9U8a-TyrKRt3NR6Cr-LMDTUZE&m=NanTA10xQwpqW8FjXP8AQQ45tD1JmUdI67pcCrgUoGQ&s=bF-17PUGeU1ALczmdXSwNy4yHE8wyUPBak70Aqzo0bY&e=>,
   > or unsubscribe
   > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ACMJMY6OFZFAKDWA54GFCOLUOZ5KXANCNFSM5JEN6O4A&d=DwMCaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=QqpSWgNGj0TQqWr3_U9U8a-TyrKRt3NR6Cr-LMDTUZE&m=NanTA10xQwpqW8FjXP8AQQ45tD1JmUdI67pcCrgUoGQ&s=Y3uiWjxYvfXxcIvDZPD25yTG49VMLKU3zWzeT_Rkp8Y&e=>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org