You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/05 19:06:47 UTC

Review Request 55221: Avoided needless copies in log tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55221/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Also did some minor code cleanup.

Spotted with clang-tidy.


Diffs
-----

  src/tests/log_tests.cpp 06efd1b68c713f3e121d0ba064dd10fd1171d284 

Diff: https://reviews.apache.org/r/55221/diff/


Testing
-------

`make check` on OSX and Linux, plus internal CI.


Thanks,

Neil Conway

Re: Review Request 55221: Avoided needless copies in log tests.

Posted by Michael Park <mp...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55221/#review160986
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Jan. 5, 2017, 11:06 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55221/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 11:06 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also did some minor code cleanup.
> 
> Spotted with clang-tidy.
> 
> 
> Diffs
> -----
> 
>   src/tests/log_tests.cpp 06efd1b68c713f3e121d0ba064dd10fd1171d284 
> 
> Diff: https://reviews.apache.org/r/55221/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX and Linux, plus internal CI.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>