You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by smalenfant <gi...@git.apache.org> on 2017/02/13 20:58:06 UTC
[GitHub] incubator-trafficcontrol pull request #279: [TC-145] Add defines to compile ...
GitHub user smalenfant opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/279
[TC-145] Add defines to compile against multiple version of TS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smalenfant/incubator-trafficcontrol astats-tc-145
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #279
----
commit 4cc9b70b45df23b2a6beeb5ecd633f939a7b6025
Author: smalenfa <sm...@apache.org>
Date: 2017-02-13T20:52:01Z
This closes #TC-145
Add compile time defines depending on version of traffic server installed
commit 21ab758b5eaea7dd03b6395d71be4239ebb13454
Author: smalenfa <sm...@apache.org>
Date: 2017-02-13T20:53:49Z
Removing tabs
commit 6f88cb27dbc6ec4dc99e30c8e2ef02147733d142
Author: smalenfa <sm...@apache.org>
Date: 2017-02-13T20:55:20Z
Fixing tab/space again
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #279: [TC-145] Add defines to compile ...
Posted by alficles <gi...@git.apache.org>.
Github user alficles commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/279#discussion_r100902511
--- Diff: traffic_server/plugins/astats_over_http/astats_over_http.c ---
@@ -538,9 +538,15 @@ void TSPluginInit(int argc, const char *argv[]) {
info.support_email = "justin@fp-x.com";
astatsLoad = time(NULL);
- if (TSPluginRegister(&info) != TS_SUCCESS) {
- TSError("Plugin registration failed. \n");
- }
+ #if (TS_VERSION_NUMBER < 3000000)
+ if (TSPluginRegister(TS_SDK_VERSION_2_0, &info) != TS_SUCCESS) {
+ #elif (TS_VERSION_NUMBER < 6000000)
+ if (TSPluginRegister(TS_SDK_VERSION_3_0, &info) != TS_SUCCESS) {
+ #else
+ if (TSPluginRegister(&info) != TS_SUCCESS) {
+ TSError("Plugin registration failed. \n");
--- End diff --
Is this line intended to be inside the #if? It makes the first two options expand to empty tests, which seems wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #279: [TC-145] Add defines to compile ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---