You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@madlib.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/14 19:13:41 UTC
[jira] [Commented] (MADLIB-1078) Skip install check for PMML
modules
[ https://issues.apache.org/jira/browse/MADLIB-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969419#comment-15969419 ]
ASF GitHub Bot commented on MADLIB-1078:
----------------------------------------
GitHub user njayaram2 opened a pull request:
https://github.com/apache/incubator-madlib/pull/115
Task: Skip install-check for pmml
JIRA: MADLIB-1078
Skip install-check for pmml when run without the '-t' option. We
can still run install-check for pmml if the '-t' option is
specified.
@iyerr3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/njayaram2/incubator-madlib task/install_check/skip-pmml
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit e1b9ea91a9add21f6325385876909436a48bcaf2
Author: Nandish Jayaram <nj...@apache.org>
Date: 2017-04-14T18:45:35Z
Task: Skip install-check for pmml
JIRA: MADLIB-1078
Skip install-check for pmml when run without the '-t' option. We
can still run install-check for pmml if the '-t' option is
specified.
----
> Skip install check for PMML modules
> -----------------------------------
>
> Key: MADLIB-1078
> URL: https://issues.apache.org/jira/browse/MADLIB-1078
> Project: Apache MADlib
> Issue Type: Task
> Components: Build System
> Reporter: Frank McQuillan
> Priority: Minor
> Fix For: v1.11
>
>
> Comments from Ed Espino on 1.10 RC-2 review on thread
> https://mail-archives.apache.org/mod_mbox/incubator-madlib-user/201703.mbox/%3CCAHAuQDzarS7K4u-rOsLLhbwSHCyFn5cKSyjLinE%2BZ%3DjSpU59qw%40mail.gmail.com%3E
> {code}
> BUILD, INSTALL and INSTALL-CHECK
> I was able to build the package and successfully ran MADlib
> install-check against PostgreSQL 9.6.2.
> Issue: There is no obvious reference to the PostgreSQL libxml
> dependency in dev documentation. The madpack install-check
> has failures (see below) if "--with-libxml" configure
> option is not specified for PostgreSQL.
> install-check errors encountered due to PostgreSQL
> configuration without "--with-libxml" option:
> psql:/tmp/madlib.0UIPlZ/pmml/test/table_to_pmml.sql_in.tmp:73: ERROR: unsupported XML feature
> DETAIL: This functionality requires the server to be built with libxml support.
> HINT: You need to rebuild PostgreSQL using --with-libxml.
> CONTEXT: while creating return value
> PL/Python function "pmml"
> {code}
> Story
> As a MADlib installer, I want IC tests that use lib-xml to be skipped, so that my install is clean and I do not have to wonder if there is a problem. For now this is only PMML modules, so just skip those ICs.
> More: if at PMML export is called that requires lib-xml, then it will fail with a run-time db error which is fine. This is not a commonly used function.
> Acceptance:
> 1) madpack install succeeds and IC passes even tho PG does not have libxml installed
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)