You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <ji...@apache.org> on 2008/06/03 23:36:45 UTC
[jira] Created: (DERBY-3706) NetworkServer console messages should
print a time stamp
NetworkServer console messages should print a time stamp
--------------------------------------------------------
Key: DERBY-3706
URL: https://issues.apache.org/jira/browse/DERBY-3706
Project: Derby
Issue Type: Improvement
Components: Network Server, Newcomer
Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
Reporter: Kathey Marsden
Priority: Minor
Network Server console messages should print a time stamp. Methods that need to be changed are
NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3706:
-------------------------------------
Attachment: derby-3706-2.diff
Attaching a remade diff (derby-3706-2.diff) because previous one had an issue when applying.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610675#action_12610675 ]
Kathey Marsden commented on DERBY-3706:
---------------------------------------
I just see one failure with this patch.
*** Start: derbyrunjartest jdk1.5.0 derbyall:derbytools 2008-07-04 13:23:59 ***
29 del
< No command given.
29a29
> xxxxxxFILTERED-TIMESTAMPxxxxxGMT : No command given.
Test Failed.
*** End: derbyrunjartest jdk1.5.0 derbyall:derbytools 2008-07-04 13:24:06 ***
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3706:
-------------------------------------
Attachment: derby-3706-5.diff
Sorry about missing that one.
This patch (derby-3706-5.diff) takes care of that derbyrunjartest test failure.
Thanks.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706-5.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden closed DERBY-3706.
---------------------------------
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.2.0, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706-5.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3706:
-------------------------------------
Attachment: derby-3706-3.diff
derby-3706-3.diff
Reverted white space diffs. In the previous patch, I removed those extra newlines because I thought it would be good to make the code more style compliant.
Changed timestamp display order to
<timestamp> : <message>
Removed the " at " from the end of startup and shutdown messages.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610025#action_12610025 ]
Kristian Waagan commented on DERBY-3706:
----------------------------------------
I think the approach is acceptable.
To minimize changes you could consider to let the methods without the boolean argument forward to the new methods and only use the new ones where required, i.e:
public void consolePropertyMessage(String str) {
consolePropertyMessage(str, true);
}
public void consolePropertyMessage(String str, boolean printTimeStamp) {
// The implementation goes here.
}
I leave it up to you to decide, or give others in the community a chance to chime in.
It's just two different ways of doing things.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden resolved DERBY-3706.
-----------------------------------
Resolution: Fixed
Fix Version/s: 10.5.0.0
This patch was committed with revision 674354
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706-5.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702099#action_12702099 ]
Kathey Marsden commented on DERBY-3706:
---------------------------------------
Typically we don't make release notes for message text changes. I would think it would be most common for scripts to check the exit code value from ping which returns a non-zero value for a failed ping. I think it would be fine though to add a releaseNote to this issue if you think others may hit the same problem, but I wouldn't hold up the release for it.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.2.0, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706-5.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607395#action_12607395 ]
Kathey Marsden commented on DERBY-3706:
---------------------------------------
I didn't run all the tests but saw 7 failures in derbynetclientmats. Please run the tests and update the masters if necessary.
one thing I noticed that looks kind of strange is the usage message. We now get a timestamp before each line, which doesn't look quite right. Maybe we should have an exception for this case.
kmarsden@kmarsden-ln2:~/test> java org.apache.derby.drda.NetworkServerControl
2008-06-24 01:14:11.209 GMT : No command given.
2008-06-24 01:14:11.211 GMT : Usage: NetworkServerControl <commands>
2008-06-24 01:14:11.212 GMT : Commands:
2008-06-24 01:14:11.212 GMT : start [-h <host>] [-p <portnumber>] [-noSecurityManager] [-ssl <sslmo
2008-06-24 01:14:11.212 GMT : shutdown [-h <host>][-p <portnumber>] [-ssl <sslmode>] [-user <userna
word>]
2008-06-24 01:14:11.212 GMT : ping [-h <host>][-p <portnumber>] [-ssl <sslmode>]
2008-06-24 01:14:11.212 GMT : sysinfo [-h <host>][-p <portnumber>] [-ssl <sslmode>]
2008-06-24 01:14:11.212 GMT : runtimeinfo [-h <host>][-p <portnumber>] [-ssl <sslmode>]
2008-06-24 01:14:11.213 GMT : logconnections {on|off}[-h <host>][-p <portnumber>] [-ssl <sslmode>]
2008-06-24 01:14:11.213 GMT : maxthreads <max>[-h <host>][-p <portnumber>] [-ssl <sslmode>]
2008-06-24 01:14:11.213 GMT : timeslice <milliseconds>[-h <host>][-p <portnumber>] [-ssl <sslmode>]
2008-06-24 01:14:11.213 GMT : trace {on|off} [-s <session id>][-h <host>][-p <portnumber>] [-ssl <s
2008-06-24 01:14:11.214 GMT : tracedirectory <traceDirectory>[-h <host>][-p <portnumber>] [-ssl <ss
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607027#action_12607027 ]
Bryan Pendleton commented on DERBY-3706:
----------------------------------------
derby-3706-3.diff is a nice clean diff, thank you very much for the attention to detail!
What risks do we run by not changing the message files for the other locales?
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3706:
-------------------------------------
Attachment: derby-3706.diff
consoleMessage() will now append " : <timestamp>" to every message.
Removed getFormattedTimeStamp() calls from other places.
Edited messages_en.properties to remove timestamp placeholder.
Did not edit message properties files for other languages. Is that acceptable?
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "John H. Embretsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607526#action_12607526 ]
John H. Embretsen commented on DERBY-3706:
------------------------------------------
Kathey wrote:
> We now get a timestamp before each line, which doesn't look quite right. Maybe we should have an exception for this case.
Absolutely, +1.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604584#action_12604584 ]
Kathey Marsden commented on DERBY-3706:
---------------------------------------
Are you able to post your database? I am not able to reproduce with a simple 10.1 database
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607041#action_12607041 ]
Suran Jayathilaka commented on DERBY-3706:
------------------------------------------
All console messages will have the timestamp at the beginning. The problem would arise when the other language messages say something like " at <timestamp>". Since the placeholder for timestamp will not receive a valuefrom the code, it will be empty and the message might seem weird.
I did try to fix other language messages as well, but decided not to, since my unfamiliarity with those languages might mean that I mess up the message even worse than just having a weird " at ".
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606839#action_12606839 ]
Kathey Marsden commented on DERBY-3706:
---------------------------------------
Thanks Suran for the patch. There are some whitespace only diffs in NetworkServerControlImpl, otherwise it looks fine. Please fix those up and attach another patch and I will commit.
This comment is late in the game so I don't think you have to change it unless you want to, but it might look better and match the current derby.log format better to have <timestamp>: <message> instead of <message>: <timestamp>. Again no need to change unless you are feeling ambitious.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka reassigned DERBY-3706:
----------------------------------------
Assignee: Suran Jayathilaka
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3706:
-------------------------------------
Attachment: derby-3706-4.diff
Added an extra boolean argument named 'printTimeStamp' to the following methods, so now they are
consolePropertyMessage(String, boolean)
consolePropertyMessageWork(string, string[], boolean)
consoleMessage(string, boolean).
This was added in order to provide a mechanism for message that do not want a timestamp to be prepended to say so. Is this approach acceptable?
Changed master files
maxthreads.out
timeslice.out
Ran tests.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701909#action_12701909 ]
Ole Solberg commented on DERBY-3706:
------------------------------------
One of our release tests (SunCTS) failed to start because a setup script was expecting ".NetworkServerControl ping" to return something like
"Connection obtained for host: ....." but with 10.5.1.1 it got
"2009-04-23 11:13:48.285 GMT : Connection obtained for host: ....."
Is a release note required?
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.2.0, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706-5.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3706:
----------------------------------
Comment: was deleted
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607350#action_12607350 ]
Bryan Pendleton commented on DERBY-3706:
----------------------------------------
Yes, definitely we should proceed. I think the patch is solid and clean, and
as you say the localized messages can be addressed subsequently.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607349#action_12607349 ]
Kathey Marsden commented on DERBY-3706:
---------------------------------------
Bryan, what do you think. Should we go ahead with this patch. I think it is ok to change it on trunk and let the other languages catch up. Hopefully we will get localized messages for the release.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3706) NetworkServer console messages should
print a time stamp
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3706:
-------------------------------------
Derby Info: [Patch Available]
Derby Categories: [Newcomer]
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3706) NetworkServer console messages
should print a time stamp
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610319#action_12610319 ]
Kathey Marsden commented on DERBY-3706:
---------------------------------------
The patch looks fine to me. I think it is ok to just have the method that takes a boolean parameter. If nobody has objections, I'll run tests and commit.
> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
> Key: DERBY-3706
> URL: https://issues.apache.org/jira/browse/DERBY-3706
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Suran Jayathilaka
> Priority: Minor
> Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp. Methods that need to be changed are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.